[APM] Improve open transaction/span/error in Discover (#125431)

docs/apm/transactions.asciidoc

@@ -151,7 +151,7 @@ Learn more about a trace sample in the *Metadata* tab:
 * User - Requires additional configuration, but allows you to see which user experienced the current transaction.
 
 TIP: All of this data is stored in documents in Elasticsearch.
-This means you can select "Actions - View sample document" to see the actual Elasticsearch document under the discover tab.
+This means you can select "Actions - View transaction in Discover" to see the actual Elasticsearch document under the discover tab.
 
 *Trace sample logs*
 

x-pack/plugins/apm/public/components/app/error_group_details/detail_view/__snapshots__/index.test.tsx.snap

@@ -34,11 +34,7 @@ exports[`DetailView should render Discover button 1`] = `
   }
   kuery=""
 >
-  <EuiButtonEmpty
-    iconType="discoverApp"
-  >
   View 10 occurrences in Discover.
-  </EuiButtonEmpty>
 </DiscoverErrorLink>
 `;
 

x-pack/plugins/apm/public/components/app/error_group_details/detail_view/index.tsx

@@ -6,7 +6,6 @@
  */
 
 import {
-  EuiButtonEmpty,
   EuiIcon,
   EuiPanel,
   EuiSpacer,
@@ -100,7 +99,6 @@ export function DetailView({ errorGroup, urlParams, kuery }: Props) {
           </h3>
         </EuiTitle>
         <DiscoverErrorLink error={error} kuery={kuery}>
-          <EuiButtonEmpty iconType="discoverApp">
           {i18n.translate(
             'xpack.apm.errorGroupDetails.viewOccurrencesInDiscoverButtonLabel',
             {
@@ -109,7 +107,6 @@ export function DetailView({ errorGroup, urlParams, kuery }: Props) {
               values: { occurrencesCount },
             }
           )}
-          </EuiButtonEmpty>
         </DiscoverErrorLink>
       </HeaderContainer>
 

x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/index.tsx

@@ -7,7 +7,6 @@
 
 import {
   EuiBadge,
-  EuiButtonEmpty,
   EuiCallOut,
   EuiFlexGroup,
   EuiFlexItem,
@@ -126,14 +125,12 @@ export function SpanFlyout({
             </EuiFlexItem>
             <EuiFlexItem grow={false}>
               <DiscoverSpanLink span={span}>
-                <EuiButtonEmpty iconType="discoverApp">
                 {i18n.translate(
                   'xpack.apm.transactionDetails.spanFlyout.viewSpanInDiscoverButtonLabel',
                   {
                     defaultMessage: 'View span in Discover',
                   }
                 )}
-                </EuiButtonEmpty>
               </DiscoverSpanLink>
             </EuiFlexItem>
           </EuiFlexGroup>

x-pack/plugins/apm/public/components/shared/transaction_action_menu/sections.test.ts

@@ -67,7 +67,7 @@ describe('Transaction action menu', () => {
           actions: [
             {
               key: 'sampleDocument',
-              label: 'View sample document',
+              label: 'View transaction in Discover',
               href: 'some-basepath/app/discover#/?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(index:apm_static_index_pattern_id,interval:auto,query:(language:kuery,query:\'processor.event:"transaction" AND transaction.id:"123" AND trace.id:"123"\'))',
               condition: true,
             },
@@ -134,7 +134,7 @@ describe('Transaction action menu', () => {
           actions: [
             {
               key: 'sampleDocument',
-              label: 'View sample document',
+              label: 'View transaction in Discover',
               href: 'some-basepath/app/discover#/?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(index:apm_static_index_pattern_id,interval:auto,query:(language:kuery,query:\'processor.event:"transaction" AND transaction.id:"123" AND trace.id:"123"\'))',
               condition: true,
             },
@@ -200,7 +200,7 @@ describe('Transaction action menu', () => {
           actions: [
             {
               key: 'sampleDocument',
-              label: 'View sample document',
+              label: 'View transaction in Discover',
               href: 'some-basepath/app/discover#/?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(index:apm_static_index_pattern_id,interval:auto,query:(language:kuery,query:\'processor.event:"transaction" AND transaction.id:"123" AND trace.id:"123"\'))',
               condition: true,
             },

x-pack/plugins/apm/public/components/shared/transaction_action_menu/sections.ts

@@ -191,7 +191,7 @@ export const getSections = ({
       label: i18n.translate(
         'xpack.apm.transactionActionMenu.viewSampleDocumentLinkLabel',
         {
-          defaultMessage: 'View sample document',
+          defaultMessage: 'View transaction in Discover',
         }
       ),
       href: getDiscoverHref({

x-pack/plugins/apm/public/components/shared/transaction_action_menu/transaction_action_menu.test.tsx

@@ -74,7 +74,7 @@ describe('TransactionActionMenu component', () => {
       Transactions.transactionWithMinimalData
     );
 
-    expect(queryByText('View sample document')).not.toBeNull();
+    expect(queryByText('View transaction in Discover')).not.toBeNull();
   });
 
   it('always renders the trace logs link', async () => {

x-pack/plugins/observability/public/components/shared/exploratory_view/series_editor/columns/series_actions.test.tsx

@@ -35,8 +35,8 @@ describe('SeriesActions', function () {
       expect(screen.getByLabelText('Series actions list')).toBeVisible();
     });
 
-    it('should display a view sample link', function () {
+    it('should display a view transaction link', function () {
-      expect(screen.getByLabelText('View sample documents')).toBeVisible();
+      expect(screen.getByLabelText('View transaction in Discover')).toBeVisible();
     });
 
     it('should display a hide series link', function () {

x-pack/plugins/observability/public/components/shared/exploratory_view/series_editor/columns/series_actions.tsx

@@ -182,7 +182,7 @@ const DELETE_SERIES_TOOLTIP_LABEL = i18n.translate(
 const VIEW_SAMPLE_DOCUMENTS_LABEL = i18n.translate(
   'xpack.observability.seriesEditor.sampleDocuments',
   {
-    defaultMessage: 'View sample documents',
+    defaultMessage: 'View transaction in Discover',
   }
 );