github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover][DocViewer] Adjust bottom margin in flyout (#183478)

Browse source 
## Summary

This PR updates the bottom margin so the JSON view can be scrolled
properly inside DocViewer flyout. It's a follow up for
https://github.com/elastic/kibana/pull/183468 (fixes the scrolling to be
limited to flyout height) and
https://github.com/elastic/kibana/pull/166406 (taller footer was added
with Close button in it).
This commit is contained in:
Julia Rechkunova 2024-05-17 16:09:09 +02:00 • committed by GitHub
parent 2a6090ff39
commit d6af74431c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/plugins/unified_doc_viewer/public/components/doc_viewer_source/get_height.test.tsx
View file

@ -8,6 +8,7 @@
import { monaco } from '@kbn/monaco';
import { getHeight } from './get_height';
import { MARGIN_BOTTOM } from './source';
describe('getHeight', () => {
Object.defineProperty(window, 'innerHeight', { writable: true, configurable: true, value: 500 });
@ -32,7 +33,7 @@ describe('getHeight', () => {
const monacoMock = getMonacoMock(500, 0);
const height = getHeight(monacoMock, true);
expect(height).toBe(475);
expect(height).toBe(500 - MARGIN_BOTTOM);
});
test('when using document explorer, returning the available height in the flyout has a minimun guarenteed height', () => {

2
src/plugins/unified_doc_viewer/public/components/doc_viewer_source/source.tsx
View file

@ -36,7 +36,7 @@ interface SourceViewerProps {
// inline limitation was necessary to enable virtualized scrolling, which improves performance
export const MAX_LINES_CLASSIC_TABLE = 500;
// Displayed margin of the code editor to the window bottom when rendered in the document explorer flyout
export const MARGIN_BOTTOM = 25;
export const MARGIN_BOTTOM = 80; // DocViewer flyout has a footer
// Minimum height for the source content to guarantee minimum space when the flyout is scrollable.
export const MIN_HEIGHT = 400;