github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Update scripted bool filter workaround (#9713)

Browse source 
Backports PR #9611

**Commit 1:**
Update scripted bool filter workaround

https://github.com/elastic/kibana/pull/8691 fixed the creation of
filters on boolean scripted fields when clicking on a visualization. The
issue was caused by the fact that aggregations would return strings
("true"/"false") instead of actual booleans as their bucket key. This
behavior occurred because Elasticsearch didn't support the
`"valueType": "boolean"` flag we were sending. Elasticsearch now
understands that (flag)[1] but as a (result)[2] it returns 1 and 0 instead of
"true" and "false". Eventually we'll get actual boolean values, but
we'll have to (wait)[3] till 6.0.

So this PR simply updates our workaround to check for 1/0 instead of
"true"/"false".

[1]: https://github.com/elastic/elasticsearch/pull/22135
[2]: https://github.com/elastic/elasticsearch/pull/22201
[3]:
https://github.com/elastic/elasticsearch/pull/22201#issuecomment-268634732

* Original sha: 8eea4dd9c9
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-12-22T16:14:21Z
This commit is contained in:
jasper 2017-01-03 19:19:25 -05:00 • committed by Matt Bargar
parent 5613c053eb
commit d6b1937567
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/ui/public/filter_manager/lib/phrase.js
View file

@ -4,14 +4,14 @@ export default function buildPhraseFilter(field, value, indexPattern) {
if (field.scripted) {
// See https://github.com/elastic/elasticsearch/issues/20941 and https://github.com/elastic/kibana/issues/8677
// for the reason behind this change. ES doesn't handle boolean types very well, so they come
// back as strings.
// and https://github.com/elastic/elasticsearch/pull/22201
// for the reason behind this change. Aggs now return boolean buckets with a key of 1 or 0.
let convertedValue = value;
if (typeof value !== 'boolean' && field.type === 'boolean') {
if (value !== 'true' && value !== 'false') {
if (value !== 1 && value !== 0) {
throw new Error('Boolean scripted fields must return true or false');
}
convertedValue = value === 'true' ? true : false;
convertedValue = value === 1 ? true : false;
}
const script = buildInlineScriptForPhraseFilter(field);