github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.8] [ML] Reenable data visualizer tests (#158568) (#158839)

Browse source 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Reenable data visualizer tests
(#158568)](https://github.com/elastic/kibana/pull/158568)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Oskamp","email":"robert.oskamp@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T15:25:11Z","message":"[ML]
Reenable data visualizer tests (#158568)\n\n## Summary\r\n\r\nThis PR
stabilizes the data visualizer tests by making sure global\r\nloading is
done around time picker and sampler selections. It also\r\nre-enables
the index data visualizer test
suite.","sha":"d4b20ab4c85cf1a12535bbfec9697338f31e35ed","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","backport:prev-minor","v8.9.0","v8.8.1"],"number":158568,"url":"https://github.com/elastic/kibana/pull/158568","mergeCommit":{"message":"[ML]
Reenable data visualizer tests (#158568)\n\n## Summary\r\n\r\nThis PR
stabilizes the data visualizer tests by making sure global\r\nloading is
done around time picker and sampler selections. It also\r\nre-enables
the index data visualizer test
suite.","sha":"d4b20ab4c85cf1a12535bbfec9697338f31e35ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158568","number":158568,"mergeCommit":{"message":"[ML]
Reenable data visualizer tests (#158568)\n\n## Summary\r\n\r\nThis PR
stabilizes the data visualizer tests by making sure global\r\nloading is
done around time picker and sampler selections. It also\r\nre-enables
the index data visualizer test
suite.","sha":"d4b20ab4c85cf1a12535bbfec9697338f31e35ed"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
This commit is contained in:
Kibana Machine 2023-06-01 12:27:28 -04:00 • committed by GitHub
parent c2e616a1ee
commit d841880951
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts
View file

@ -34,6 +34,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await ml.jobSourceSelection.selectSourceForIndexBasedDataVisualizer(
testData.sourceIndexOrSavedSearch
);
await headerPage.waitUntilLoadingHasFinished();
});
it(`${testData.suiteTitle} displays index details`, async () => {
@ -140,9 +141,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
});
}
// Failing: See https://github.com/elastic/kibana/issues/137032
// Failing: See https://github.com/elastic/kibana/issues/154452
describe.skip('index based', function () {
describe('index based', function () {
this.tags(['ml']);
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote');

3
x-pack/test/functional/services/ml/data_visualizer_index_based.ts
View file

@ -14,7 +14,7 @@ export function MachineLearningDataVisualizerIndexBasedProvider({
}: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const retry = getService('retry');
const PageObjects = getPageObjects(['discover']);
const PageObjects = getPageObjects(['discover', 'header']);
const queryBar = getService('queryBar');
const filterBar = getService('filterBar');
const browser = getService('browser');
@ -46,6 +46,7 @@ export function MachineLearningDataVisualizerIndexBasedProvider({
await retry.tryForTime(30 * 1000, async () => {
await testSubjects.clickWhenNotDisabledWithoutRetry('mlDatePickerButtonUseFullData');
await testSubjects.clickWhenNotDisabledWithoutRetry('superDatePickerApplyTimeButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await this.setRandomSamplingOption(randomSamplerOption);
await await this.assertTotalDocumentCount(expectedFormattedTotalDocCount);
});