[Serverless] Unify Dashboard app IDs in functional tests (#166377)

Removes all usages of `PageObjects.common.navigateToApp('dashboard')` in favour of a Dashboard page method.
This commit is contained in:
Devon Thomson 2023-09-18 11:41:12 -04:00 committed by GitHub
parent 05e0666d23
commit d8c112e9b7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
103 changed files with 170 additions and 167 deletions

View file

@ -282,7 +282,7 @@ export class DashboardPlugin
if (home) {
home.featureCatalogue.register({
id: LEGACY_DASHBOARD_APP_ID,
id: DASHBOARD_APP_ID,
title: dashboardAppTitle,
subtitle: i18n.translate('dashboard.featureCatalogue.dashboardSubtitle', {
defaultMessage: 'Analyze data in dashboards.',
@ -291,7 +291,7 @@ export class DashboardPlugin
defaultMessage: 'Display and share a collection of visualizations and saved searches.',
}),
icon: 'dashboardApp',
path: `/app/dashboards#${LANDING_PAGE_PATH}`,
path: `/app/${DASHBOARD_APP_ID}#${LANDING_PAGE_PATH}`,
showOnHomePage: false,
category: 'data',
solutionId: 'kibana',

View file

Before

Width:  |  Height:  |  Size: 9.1 KiB

After

Width:  |  Height:  |  Size: 9.1 KiB

Before After
Before After

View file

@ -162,7 +162,7 @@ export const Overview: FC<Props> = ({ newsFetchResult, solutions, features }) =>
};
// Dashboard and discover are displayed in larger cards
const mainApps = ['dashboard', 'discover'];
const mainApps = ['dashboards', 'discover'];
const remainingApps = kibanaApps.map(({ id }) => id).filter((id) => !mainApps.includes(id));
const onDataViewCreated = () => {

View file

@ -134,7 +134,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.saveSearch('my search');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -136,7 +136,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.saveSearch('my classic search');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -30,7 +30,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('ensure toolbar popover closes on add', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.switchToEditMode();
await dashboardAddPanel.clickEditorMenuButton();
@ -44,7 +44,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('add new visualization link', () => {
before(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
});

View file

@ -42,7 +42,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
});

View file

@ -32,7 +32,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
await PageObjects.header.waitUntilLoadingHasFinished();
@ -71,7 +71,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.visualize.gotoVisualizationLandingPage();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.common.navigateToApp('dashboards');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('few panels');
await PageObjects.dashboard.waitForRenderComplete();
await validateQueryAndFilter();
@ -138,7 +138,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.visualize.gotoVisualizationLandingPage();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.common.navigateToApp('dashboards');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('few panels');
const currentPanelCount = await PageObjects.dashboard.getPanelCount();
expect(currentPanelCount).to.eql(unsavedPanelCount);

View file

@ -25,7 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
await PageObjects.dashboard.switchToEditMode();
@ -86,7 +86,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
redirectToOrigin: false,
});
await PageObjects.visualize.notLinkedToOriginatingApp();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
it('loses originatingApp connection after first save when redirectToOrigin is false', async () => {

View file

@ -50,7 +50,7 @@ export default function ({ getService, getPageObjects }) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {
@ -114,7 +114,7 @@ export default function ({ getService, getPageObjects }) {
});
it('visualize app menu navigates to the visualize listing page if the last opened visualization was linked to dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();
@ -133,7 +133,7 @@ export default function ({ getService, getPageObjects }) {
describe('by value', () => {
it('save and return button returns to dashboard after editing visualization with changes saved', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await createMarkdownVis();

View file

@ -31,7 +31,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
'doc_table:legacy': false,
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await filterBar.ensureFieldEditorModalIsClosed();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -114,7 +114,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.setTime({ from, to });
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
await elasticChart.setNewChartUiDebugFlag(true);

View file

@ -60,7 +60,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('applied on dashboard', async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.loadSavedDashboard('dashboard with table');
await dashboard.waitForRenderComplete();
const fieldLink = await visChart.getFieldLinkInVisTable(`${fieldName}: Descending`);

View file

@ -47,7 +47,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {

View file

@ -66,7 +66,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.gotoDashboardLandingPage();
});

View file

@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
});

View file

@ -25,7 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
});

View file

@ -46,7 +46,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard(fewPanelsTitle);
await PageObjects.dashboard.waitForRenderComplete();

View file

@ -34,7 +34,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.savedObjects.clean({ types: ['search', 'index-pattern'] });
log.debug('load kibana with no data');
await kibanaServer.importExport.unload(kbnDirectory);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {
@ -54,7 +54,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.savedObjects.clean({ types: ['search', 'index-pattern'] });
// create the new data view from the dashboards/create route in order to test that the dashboard is loaded properly as soon as the data view is created...
await PageObjects.common.navigateToApp('dashboard', { hash: '/create' });
await PageObjects.common.navigateToApp('dashboards', { hash: '/create' });
const button = await testSubjects.find('createDataViewButton');
button.click();

View file

@ -24,7 +24,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
after(async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
describe('dashboard without stored timed', () => {

View file

@ -25,7 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
});

View file

@ -33,7 +33,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.importExport.load(
'test/functional/fixtures/kbn_archiver/dashboard_error_cases.json'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {

View file

@ -29,7 +29,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('dashboard with filter');
});

View file

@ -28,7 +28,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
await PageObjects.dashboard.switchToEditMode();

View file

@ -30,7 +30,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('dashboard with everything');
await PageObjects.dashboard.waitForRenderComplete();

View file

@ -49,7 +49,7 @@ export default function ({
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('dashboard with everything');

View file

@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
});

View file

@ -38,7 +38,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.importExport.load(
'test/functional/fixtures/kbn_archiver/dashboard/current/kibana'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.addVisualization('Rendering-Test:-animal-sounds-pie');
await PageObjects.dashboard.saveDashboard('legacyTest', { waitDialogIsClosed: true });
@ -109,7 +109,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('resolves markdown link from dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.addVisualization('legacy url markdown');
(await find.byLinkText('abc')).click();

View file

@ -32,7 +32,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.setTime({ from, to });
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await filterBar.ensureFieldEditorModalIsClosed();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -109,7 +109,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const from = 'Sep 19, 2017 @ 06:31:44.000';
const to = 'Sep 23, 2018 @ 18:31:44.000';
await PageObjects.common.setTime({ from, to });
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
await PageObjects.dashboard.switchToEditMode();

View file

@ -25,7 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('few panels');
await PageObjects.dashboard.switchToEditMode();

View file

@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {

View file

@ -43,7 +43,7 @@ export default function ({
await browser.setScreenshotSize(1000, 500);
// adding this navigate adds the timestamp hash to the url which invalidates previous
// session. If we don't do this, the colors on the visualizations are different and the screenshots won't match.
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async function () {

View file

@ -28,7 +28,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
});

View file

@ -29,7 +29,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.replace({
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
});

View file

@ -55,7 +55,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
/* then, create our testing dashboard */
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.gotoDashboardLandingPage();
await dashboard.clickNewDashboard();
await timePicker.setDefaultDataRange();

View file

@ -14,15 +14,11 @@ import { FtrProviderContext } from '../../../../ftr_provider_context';
export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const find = getService('find');
const { dashboardControls, common, dashboard } = getPageObjects([
'dashboardControls',
'dashboard',
'common',
]);
const { dashboardControls, dashboard } = getPageObjects(['dashboardControls', 'dashboard']);
describe('Dashboard control group settings', () => {
before(async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.gotoDashboardLandingPage();
await dashboard.clickNewDashboard();
await dashboard.saveDashboard('Test Control Group Settings');

View file

@ -13,11 +13,7 @@ export default function ({ loadTestFile, getService, getPageObjects }: FtrProvid
const kibanaServer = getService('kibanaServer');
const security = getService('security');
const { dashboardControls, common, dashboard } = getPageObjects([
'dashboardControls',
'dashboard',
'common',
]);
const { dashboardControls, dashboard } = getPageObjects(['dashboardControls', 'dashboard']);
async function setup() {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
@ -31,9 +27,9 @@ export default function ({ loadTestFile, getService, getPageObjects }: FtrProvid
});
// enable the controls lab and navigate to the dashboard listing page to start
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboardControls.enableControlsLab();
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.preserveCrossAppState();
}

View file

@ -49,9 +49,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
from: 'Oct 22, 2018 @ 00:00:00.000',
to: 'Dec 3, 2018 @ 00:00:00.000',
});
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboardControls.enableControlsLab();
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.preserveCrossAppState();
await dashboard.gotoDashboardLandingPage();
await dashboard.clickNewDashboard();

View file

@ -50,7 +50,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
let controlId: string;
before(async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader', 'animals']);
await dashboard.gotoDashboardLandingPage();
await dashboard.clickNewDashboard();

View file

@ -17,12 +17,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const kibanaServer = getService('kibanaServer');
const { dashboardControls, discover, timePicker, common, dashboard } = getPageObjects([
const { dashboardControls, discover, timePicker, dashboard } = getPageObjects([
'dashboardControls',
'discover',
'timePicker',
'dashboard',
'common',
]);
describe('Time Slider Control', async () => {
@ -55,7 +54,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('create, edit, and delete', async () => {
before(async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.preserveCrossAppState();
await dashboard.gotoDashboardLandingPage();
await dashboard.clickNewDashboard();
@ -132,7 +131,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('panel interactions', async () => {
describe('saved search', async () => {
before(async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.loadSavedDashboard('timeslider and saved search');
await dashboard.waitForRenderComplete();
});

View file

@ -16,7 +16,7 @@ export default function ({ loadTestFile, getService, getPageObjects }: FtrProvid
const kibanaServer = getService('kibanaServer');
const security = getService('security');
const { timePicker, dashboard, common } = getPageObjects(['timePicker', 'dashboard', 'common']);
const { timePicker, dashboard } = getPageObjects(['timePicker', 'dashboard']);
const setup = async () => {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
@ -29,7 +29,7 @@ export default function ({ loadTestFile, getService, getPageObjects }: FtrProvid
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.gotoDashboardLandingPage();
await dashboard.clickNewDashboard();
await timePicker.setDefaultDataRange();

View file

@ -42,7 +42,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
before(async () => {
await setAllowExpensiveQueries(false);
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.clickNewDashboard();
await dashboard.ensureDashboardIsInEditMode();
await timePicker.setDefaultDataRange();

View file

@ -39,7 +39,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
let controlId: string;
const returnToDashboard = async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await header.waitUntilLoadingHasFinished();
await elasticChart.setNewChartUiDebugFlag();
await dashboard.loadSavedDashboard(OPTIONS_LIST_DASHBOARD_NAME);

View file

@ -30,7 +30,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
defaultIndex: '0bf35f60-3dc9-11e8-8660-4d65aa086b3c',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.switchToEditMode();
});

View file

@ -44,7 +44,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
beforeEach(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await filterBar.ensureFieldEditorModalIsClosed();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -15,7 +15,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const elasticChart = getService('elasticChart');
const kibanaServer = getService('kibanaServer');
const security = getService('security');
const PageObjects = getPageObjects(['settings', 'common', 'discover', 'header', 'timePicker']);
const PageObjects = getPageObjects([
'timePicker',
'dashboard',
'settings',
'discover',
'common',
'header',
]);
const defaultSettings = {
defaultIndex: 'long-window-logstash-*',
'dateFormat:tz': 'Europe/Berlin',
@ -253,7 +260,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
// go to dashboard
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.header.waitUntilLoadingHasFinished();
// go to discover

View file

@ -170,7 +170,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();
// open searches on dashboard
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await filterBar.ensureFieldEditorModalIsClosed();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const kibanaServer = getService('kibanaServer');
const security = getService('security');
const PageObjects = getPageObjects(['common', 'discover', 'header', 'timePicker']);
const PageObjects = getPageObjects(['common', 'discover', 'header', 'timePicker', 'dashboard']);
const defaultSettings = {
defaultIndex: 'logstash-*',
@ -46,7 +46,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.toggleChartVisibility();
expect(await PageObjects.discover.isChartVisible()).to.be(false);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.common.navigateToApp('discover');
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.header.waitUntilLoadingHasFinished();

View file

@ -102,7 +102,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.saveSearch('my search');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -120,7 +120,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.discover.saveSearch('expand-cell-search');
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.header.waitUntilLoadingHasFinished();

View file

@ -33,7 +33,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
});
const apps = ['dashboard', 'discover', 'canvas', 'maps', 'ml'];
const apps = ['dashboards', 'discover', 'canvas', 'maps', 'ml'];
it('should display Analytics apps cards', async () => {
const kbnOverviewAppsCards = await find.allByCssSelector('.kbnOverviewApps__item');

View file

@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('when false, dashboard state is unhashed', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.timePicker.setDefaultAbsoluteRange();
const globalState = await getStateFromUrl();
@ -73,7 +73,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('when true, dashboard state is hashed', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.timePicker.setDefaultAbsoluteRange();
const globalState = await getStateFromUrl();

View file

@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// test to cover bug #54548 - add this visualization to a dashboard and filter
it('should add to dashboard and allow filtering', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.addVisualization(vizName1);

View file

@ -158,7 +158,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('adding a new metric to an existing dashboard by value', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.addVisualizations(['Visualization AreaChart']);
@ -188,7 +188,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('adding a new metric to an existing dashboard by reference', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.addVisualizations(['Visualization AreaChart']);
@ -220,7 +220,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('adding a existing metric to an existing dashboard by value', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.addVisualizations(['Visualization AreaChart']);
@ -265,7 +265,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('adding a existing metric to an existing dashboard by reference', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.addVisualizations(['Visualization AreaChart']);

View file

@ -195,7 +195,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const cleanup = async () => {
const discardDashboardPromptButton = 'discardDashboardPromptButton';
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
if (await testSubjects.exists(discardDashboardPromptButton)) {
await dashboard.clickUnsavedChangesDiscard(discardDashboardPromptButton, true);
}

View file

@ -51,12 +51,18 @@ export class DashboardPageObject extends FtrService {
? 'test/functional/fixtures/kbn_archiver/ccs/dashboard/legacy/legacy.json'
: 'test/functional/fixtures/kbn_archiver/dashboard/legacy/legacy.json';
public readonly APP_ID = 'dashboards';
async initTests({ kibanaIndex = this.kibanaIndex, defaultIndex = this.logstashIndex } = {}) {
this.log.debug('load kibana index with visualizations and log data');
await this.kibanaServer.savedObjects.cleanStandardList();
await this.kibanaServer.importExport.load(kibanaIndex);
await this.kibanaServer.uiSettings.replace({ defaultIndex });
await this.common.navigateToApp('dashboard');
await this.navigateToApp();
}
public async navigateToApp() {
await this.common.navigateToApp(this.APP_ID);
}
public async expectAppStateRemovedFromURL() {

View file

@ -42,7 +42,7 @@ export class TimeToVisualizePageObject extends FtrService {
}
public async resetNewDashboard() {
await this.common.navigateToApp('dashboard');
await this.dashboard.navigateToApp();
await this.dashboard.gotoDashboardLandingPage();
await this.dashboard.clickNewDashboard(false);
}

View file

@ -183,13 +183,13 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
it(`allows a visualization to be edited`, async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardEditMode('A Dashboard');
await panelActions.expectExistsEditPanelAction();
});
it(`allows a map to be edited`, async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardEditMode('dashboard with map');
await panelActions.expectExistsEditPanelAction();
});

View file

@ -88,7 +88,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
describe('lens by value works without library save permissions', () => {
before(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
});
@ -169,13 +169,13 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const modifiedMarkdownText = 'Modified markdown text';
before(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
});
it('can add a markdown panel by value', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.waitForRenderComplete();

View file

@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('goes back to last opened url', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('A Dashboard');
await PageObjects.common.navigateToApp('home');
await appsMenu.clickLink('Dashboard', { category: 'kibana' });
@ -47,7 +47,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('remembers url after switching spaces', async function () {
// default space
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('A Dashboard');
await PageObjects.spaceSelector.openSpacesNav();

View file

@ -128,7 +128,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should launch sample flights data set dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('[Flights] Global Flight Dashboard');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.timePicker.setCommonlyUsedTime('sample_data range');

View file

@ -22,7 +22,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await kibanaServer.importExport.load(
'x-pack/test/functional/fixtures/kbn_archiver/lens/lens_basic.json'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
});

View file

@ -73,7 +73,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
}
async function createNewDashboard() {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
}

View file

@ -41,7 +41,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
beforeEach(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await filterBar.ensureFieldEditorModalIsClosed();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -23,8 +23,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const queryBar = getService('queryBar');
const { common, settings, savedObjects, dashboard, dashboardControls } = getPageObjects([
'common',
const { settings, savedObjects, dashboard, dashboardControls } = getPageObjects([
'settings',
'dashboard',
'savedObjects',
@ -57,7 +56,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('should render all panels on the dashboard', async () => {
await dashboardControls.enableControlsLab();
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.loadSavedDashboard('[8.0.0] Controls Dashboard');
// dashboard should load properly

View file

@ -46,7 +46,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should render all panels on the dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('[7.12.1] Lens By Value Test Dashboard');
// dashboard should load properly

View file

@ -36,7 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should render all panels on the dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('TSVB Index Pattern Smoke Test');
// dashboard should load properly
@ -101,7 +101,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should render all panels on the dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('TSVB 7.13.3');
// dashboard should load properly

View file

@ -46,7 +46,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should render all panels on the dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('[7.12.1] Visualize Test Dashboard');
// dashboard should load properly

View file

@ -34,7 +34,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.importExport.load(
'x-pack/test/functional/fixtures/kbn_archiver/lens/lens_basic.json'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.saveDashboard(DASHBOARD_NAME);

View file

@ -36,7 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.importExport.load(
'x-pack/test/functional/fixtures/kbn_archiver/lens/lens_basic.json'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.saveDashboard(DASHBOARD_NAME);

View file

@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should sync colors on dashboard by default', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await elasticChart.setNewChartUiDebugFlag(true);
await PageObjects.dashboard.clickCreateDashboardPrompt();
await dashboardAddPanel.clickCreateNewLink();

View file

@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
before(async () => {
log.debug('Dashboard Drilldowns:initTests');
await security.testUser.setRoles(['test_logstash_reader', 'global_dashboard_all']);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await elasticChart.setNewChartUiDebugFlag();
@ -399,7 +399,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// Actually use copied dashboards in a new space:
await PageObjects.common.navigateToApp('dashboard', {
await PageObjects.common.navigateToApp('dashboards', {
basePath: `/s/${destinationSpaceId}`,
});
await PageObjects.dashboard.preserveCrossAppState();

View file

@ -22,7 +22,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('Dashboard to URL drilldown', function () {
before(async () => {
log.debug('Dashboard to URL:initTests');
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
});

View file

@ -28,7 +28,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('Explore underlying data - chart action', () => {
describe('value click action', () => {
it('action exists in chart click popup menu', async () => {
await common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await dashboard.preserveCrossAppState();
await dashboard.loadSavedDashboard(drilldowns.DASHBOARD_WITH_PIE_CHART_NAME);
await pieChart.clickOnPieSlice('160,000');
@ -60,7 +60,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
let originalTimeRangeDurationHours: number | undefined;
it('action exists in chart brush popup menu', async () => {
await common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await dashboard.preserveCrossAppState();
await dashboard.loadSavedDashboard(drilldowns.DASHBOARD_WITH_AREA_CHART_NAME);

View file

@ -13,7 +13,7 @@ const ACTION_TEST_SUBJ = `embeddablePanelAction-${ACTION_ID}`;
export default function ({ getService, getPageObjects }: FtrProviderContext) {
const drilldowns = getService('dashboardDrilldownsManage');
const { dashboard, discover, common, timePicker } = getPageObjects([
const { dashboard, discover, timePicker } = getPageObjects([
'dashboard',
'discover',
'common',
@ -33,7 +33,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
before('start on Dashboard landing page', async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.preserveCrossAppState();
});
@ -42,7 +42,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
after('clean-up custom time range on panel', async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.gotoDashboardEditMode(drilldowns.DASHBOARD_WITH_PIE_CHART_NAME);
await panelActions.customizePanel();
@ -75,7 +75,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('carries over panel time range', async () => {
await common.navigateToApp('dashboard');
await dashboard.navigateToApp();
await dashboard.gotoDashboardEditMode(drilldowns.DASHBOARD_WITH_PIE_CHART_NAME);

View file

@ -33,7 +33,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const navigateToDashboardApp = async () => {
log.debug('in navigateToDashboardApp');
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await retry.tryForTime(10000, async () => {
expect(await PageObjects.dashboard.onDashboardLandingPage()).to.be(true);
});

View file

@ -84,7 +84,7 @@ export default function ({
describe('Print PDF button', () => {
it('is available if new', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.reporting.openPdfReportingPanel();
expect(await PageObjects.reporting.isGenerateReportButtonDisabled()).to.be(null);
@ -110,7 +110,7 @@ export default function ({
// Generating and then comparing reports can take longer than the default 60s timeout because the comparePngs
// function is taking about 15 seconds per comparison in jenkins.
this.timeout(300000);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard');
await PageObjects.reporting.openPdfReportingPanel();
await PageObjects.reporting.checkUsePrintLayout();
@ -133,7 +133,7 @@ export default function ({
});
it('is available if new', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.reporting.openPngReportingPanel();
expect(await PageObjects.reporting.isGenerateReportButtonDisabled()).to.be(null);
@ -158,7 +158,7 @@ export default function ({
it('downloads a PDF file with saved search given EuiDataGrid enabled', async function () {
await kibanaServer.uiSettings.update({ 'doc_table:legacy': false });
this.timeout(300000);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard');
await PageObjects.reporting.openPdfReportingPanel();
await PageObjects.reporting.clickGenerateReportButton();
@ -187,7 +187,7 @@ export default function ({
'x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce_76.json'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('[K7.6-eCommerce] Revenue Dashboard');
await PageObjects.reporting.openPngReportingPanel();

View file

@ -97,7 +97,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.discover.saveSearch('search with warning');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();

View file

@ -48,7 +48,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// FLAKY: https://github.com/elastic/kibana/issues/104578
describe.skip('Customize time range', () => {
it('should be possible to customize time range for saved searches on dashboards', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.addSavedSearch('Ecommerce Data');

View file

@ -41,7 +41,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
};
const createAndSaveDashboard = async (dashboardName: string) => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsXYvis');

View file

@ -42,7 +42,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('lens dashboard tests', () => {
before(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await security.testUser.setRoles(
[
'global_dashboard_all',
@ -68,7 +68,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should be able to add filters/timerange by clicking in XYChart', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsXYvis');
@ -97,7 +97,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should be able to add filters by right clicking in XYChart', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsXYvis');
@ -121,7 +121,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// Requires xpack.discoverEnhanced.actions.exploreDataInContextMenu.enabled
// setting set in kibana.yml to test (not enabled by default)
it('should hide old "explore underlying data" action', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsXYvis');
@ -135,7 +135,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should be able to add filters by clicking in pie chart', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsPieVis');
@ -156,7 +156,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should not carry over filters if creating a new lens visualization from within dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.timePicker.setDefaultAbsoluteRange();
await filterBar.addFilter({ field: 'geo.src', operation: 'is', value: 'US' });
@ -174,7 +174,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('CSV export action exists in panel context menu', async () => {
const ACTION_ID = 'ACTION_EXPORT_CSV';
const ACTION_TEST_SUBJ = `embeddablePanelAction-${ACTION_ID}`;
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsPieVis');
@ -190,7 +190,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should show all data from all layers in the inspector', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickCreateNewLink();
await PageObjects.header.waitUntilLoadingHasFinished();
@ -234,7 +234,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('unlink lens panel from embeddable library', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsPieVis');
@ -270,7 +270,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should show validation messages if any error appears', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickCreateNewLink();
@ -300,7 +300,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should recover lens panel in an error state when fixing search query', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
await dashboardAddPanel.filterEmbeddableNames('lnsXYvis');

View file

@ -87,7 +87,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'x-pack/test/functional/fixtures/kbn_archiver/lens/missing_fields'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard(
'dashboard containing vis with missing fields'
);
@ -135,7 +135,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'x-pack/test/functional/fixtures/kbn_archiver/lens/fundamental_config_errors_on_dashboard'
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('lens fundamental config errors dash');
const failureElements = await testSubjects.findAll('errorMessageMarkdown');

View file

@ -53,7 +53,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('should not cause PDF reports to fail', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await listingTable.clickItemLink('dashboard', 'Lens reportz');
await PageObjects.reporting.openPdfReportingPanel();
await PageObjects.reporting.clickGenerateReportButton();

View file

@ -33,7 +33,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.clickNewDashboard();
});

View file

@ -83,7 +83,7 @@ export default function ({ getPageObjects, getService }) {
});
it('should allow new map be added by value to an existing dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.saveDashboard('My Very Cool Dashboard');
@ -113,7 +113,7 @@ export default function ({ getPageObjects, getService }) {
});
it('should allow existing maps be added by value to an existing dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.saveDashboard('My Wonderful Dashboard');
@ -185,7 +185,7 @@ export default function ({ getPageObjects, getService }) {
});
it('should allow new map be added by reference to an existing dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.saveDashboard('My Super Cool Dashboard');
@ -215,7 +215,7 @@ export default function ({ getPageObjects, getService }) {
});
it('should allow existing maps be added by reference to an existing dashboard', async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await PageObjects.dashboard.saveDashboard('My Amazing Dashboard');

View file

@ -35,7 +35,7 @@ export default function ({ getPageObjects, getService }) {
defaultIndex: 'c698b940-e149-11e8-a35a-370a8516603a',
[UI_SETTINGS.COURIER_IGNORE_FILTER_IF_FIELD_NOT_IN_INDEX]: true,
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('map embeddable example');
await PageObjects.dashboard.waitForRenderComplete();
});
@ -164,7 +164,7 @@ export default function ({ getPageObjects, getService }) {
// see https://github.com/elastic/kibana/issues/61596 on why it is specific to maps
it("dashboard's back button should navigate to previous page", async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('map embeddable example');
await PageObjects.dashboard.waitForRenderComplete();

View file

@ -31,7 +31,7 @@ export default function ({ getPageObjects, getService }) {
await kibanaServer.uiSettings.replace({
defaultIndex: 'c698b940-e149-11e8-a35a-370a8516603a',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickEditorMenuButton();
await PageObjects.visualize.clickMapsApp();

View file

@ -21,7 +21,7 @@ export default function ({ getPageObjects, getService }) {
await kibanaServer.uiSettings.replace({
defaultIndex: 'c698b940-e149-11e8-a35a-370a8516603a',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.addEmbeddable('document example', 'map');

View file

@ -19,7 +19,7 @@ export default function ({ getPageObjects, getService }) {
['test_logstash_reader', 'global_maps_all', 'global_dashboard_all'],
{ skipBrowserRefresh: true }
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardEditMode('filter by map extent dashboard');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();

View file

@ -41,7 +41,7 @@ export default function ({ getPageObjects, getService }) {
describe('new map', () => {
beforeEach(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickEditorMenuButton();
await dashboardAddPanel.clickVisType('maps');
@ -73,7 +73,7 @@ export default function ({ getPageObjects, getService }) {
describe('edit existing map', () => {
beforeEach(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('map embeddable example');
await PageObjects.dashboard.switchToEditMode();
await dashboardPanelActions.editPanelByTitle('join example');

View file

@ -30,7 +30,7 @@ export default function ({ getPageObjects, getService }) {
defaultIndex: 'c698b940-e149-11e8-a35a-370a8516603a',
});
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.preserveCrossAppState();
await PageObjects.dashboard.loadSavedDashboard('dash for tooltip filter action test');

View file

@ -61,7 +61,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('PNG file matches the baseline image, using sample geo data', async function () {
await reporting.initEcommerce();
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('Ecommerce Map');
await PageObjects.reporting.openPngReportingPanel();
await PageObjects.reporting.clickGenerateReportButton();
@ -73,7 +73,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
it('PNG file matches the baseline image, using embeddable example', async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.loadSavedDashboard('map embeddable example');
await PageObjects.reporting.openPngReportingPanel();
await PageObjects.reporting.clickGenerateReportButton();

View file

@ -59,7 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
testData.jobConfig,
testData.datafeedConfig
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {

View file

@ -80,7 +80,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
testDataList.map((d) => d.dashboardSavedObject)
);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {
@ -92,7 +92,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const { dashboardSavedObject, panelTitle, type } = testData;
describe(`for ${panelTitle}`, function () {
before(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
after(async () => {

View file

@ -55,7 +55,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
beforeEach(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
afterEach(async () => {

View file

@ -107,7 +107,7 @@ export default function ({ getService, getPageObject, getPageObjects }: FtrProvi
});
beforeEach(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
let tabsCount = 1;

View file

@ -47,7 +47,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
beforeEach(async () => {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
});
afterEach(async () => {

View file

@ -58,7 +58,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it(`displays Field statistics table in Dashboard when enabled`, async function () {
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.addSavedSearch(savedSearchTitle);
@ -96,7 +96,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it(`doesn't display Field statistics table in Dashboard when disabled`, async function () {
await ml.testResources.setAdvancedSettingProperty(SHOW_FIELD_STATISTICS, false);
await PageObjects.common.navigateToApp('dashboard');
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.gotoDashboardEditMode(dashboardTitle);
await PageObjects.header.waitUntilLoadingHasFinished();

Some files were not shown because too many files have changed in this diff Show more