github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixing the object diff so it only changes add and changed keys

Browse source
This commit is contained in:
Chris Cowan 2014-08-11 12:10:22 -07:00
parent a7a139ce5a
commit d9b7b8ed28
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/kibana/utils/diff_object.js
View file

@ -49,8 +49,10 @@ define(function (require) {
delete target[key];
});
// Assign the source to the target
_.assign(target, _.pick(source, sourceKeys));
// Assign the changed to the source to the target
_.assign(target, _.pick(source, diff.changed));
// Assign the added to the source to the target
_.assign(target, _.pick(source, diff.added));
return diff;

8
test/unit/specs/utils/diff_object.js
View file

@ -64,5 +64,13 @@ define(function (require) {
expect(results.changed).to.be.empty();
});
it('should only change keys that actually changed', function () {
var obj = { 'message': 'foo' };
var target = { obj: obj, message: 'foo' };
var source = { obj: _.cloneDeep(obj), message: 'test' };
var results = diff(target, source);
expect(target.obj).to.be(obj);
});
});
});