github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Quick Wins][Cloud Security] Update Confirm Agent Enrollment waiting message for CSP integrations (#170995)

Browse source 
## Summary

This PR is part of Quick Wins
This PR updates the message on Confirm Agent Enrollment sections for CSP
integrations.
When Adding Integrations for CSP, instead of getting 'Listening for
agent...' User will see 'Listening for agent... this can take several
minutes'

CSP
<img width="1427" alt="Screenshot 2023-11-09 at 3 54 56 PM"
src="cf7cb24c-c03e-4bd1-bff7-58682b46fb0e">

Non-CSP
<img width="1538" alt="Screenshot 2023-11-09 at 3 56 16 PM"
src="a941000e-74b6-4bea-9456-4c86ed23730c">
This commit is contained in:
Rickyanto Ang 2023-11-15 09:50:45 -08:00 • committed by GitHub
parent 4a0b967e38
commit dcd8687a60
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

17
x-pack/plugins/fleet/public/components/agent_enrollment_flyout/confirm_agent_enrollment.tsx
View file

@ -25,6 +25,7 @@ interface Props {
onClickViewAgents?: () => void;
agentCount: number;
showLoading?: boolean;
isLongEnrollment?: boolean;
}
interface UsePollingAgentCountOptions {
@ -97,6 +98,7 @@ export const ConfirmAgentEnrollment: React.FunctionComponent<Props> = ({
onClickViewAgents,
agentCount,
showLoading = false,
isLongEnrollment = false,
}) => {
const { getHref } = useLink();
const { application } = useStartServices();
@ -139,10 +141,17 @@ export const ConfirmAgentEnrollment: React.FunctionComponent<Props> = ({
color="primary"
iconType={EuiLoadingSpinner}
title={
<FormattedMessage
id="xpack.fleet.agentEnrollment.loading.listening"
defaultMessage="Listening for agent..."
/>
isLongEnrollment ? (
<FormattedMessage
id="xpack.fleet.agentEnrollment.loading.listeninglongenrollemnt"
defaultMessage="Listening for agent... this can take several minutes"
/>
) : (
<FormattedMessage
id="xpack.fleet.agentEnrollment.loading.listening"
defaultMessage="Listening for agent"
/>
)
}
/>
<EuiSpacer size="m" />

3
x-pack/plugins/fleet/public/components/agent_enrollment_flyout/steps/agent_enrollment_confirmation_step.tsx
View file

@ -46,6 +46,7 @@ export const AgentEnrollmentConfirmationStep = ({
agentCount,
showLoading,
poll = true,
isLongEnrollment = false,
}: {
selectedPolicyId?: string;
troubleshootLink: string;
@ -53,6 +54,7 @@ export const AgentEnrollmentConfirmationStep = ({
agentCount: number;
poll?: boolean;
showLoading?: boolean;
isLongEnrollment?: boolean;
}): EuiContainedStepProps => {
const isComplete = !!agentCount;
return {
@ -71,6 +73,7 @@ export const AgentEnrollmentConfirmationStep = ({
onClickViewAgents={onClickViewAgents}
agentCount={agentCount}
showLoading={!isComplete || showLoading}
isLongEnrollment={isLongEnrollment}
/>
) : (
<AgentEnrollmentPrePollInstructions troubleshootLink={troubleshootLink} />

1
x-pack/plugins/fleet/public/components/agent_enrollment_flyout/steps/compute_steps.tsx
View file

@ -319,6 +319,7 @@ export const ManagedSteps: React.FunctionComponent<InstructionProps> = ({
onClickViewAgents,
troubleshootLink: link,
agentCount: enrolledAgentIds.length,
isLongEnrollment: cloudSecurityIntegration !== undefined,
})
);
}