github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Avoid using deprecated camelCase parameters for SAML APIs. (#103091)

Browse source
This commit is contained in:
Aleh Zasypkin 2021-06-24 18:22:14 +02:00 • committed by GitHub
parent 7e32f934aa
commit dd20b8adb6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/security/server/authentication/providers/saml.test.ts
View file

@ -1186,7 +1186,7 @@ describe('SAMLAuthenticationProvider', () => {
expect(mockOptions.client.asInternalUser.transport.request).toHaveBeenCalledWith({
method: 'POST',
path: '/_security/saml/invalidate',
body: { queryString: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
body: { query_string: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
});
});
@ -1286,7 +1286,7 @@ describe('SAMLAuthenticationProvider', () => {
expect(mockOptions.client.asInternalUser.transport.request).toHaveBeenCalledWith({
method: 'POST',
path: '/_security/saml/invalidate',
body: { queryString: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
body: { query_string: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
});
});
@ -1305,7 +1305,7 @@ describe('SAMLAuthenticationProvider', () => {
expect(mockOptions.client.asInternalUser.transport.request).toHaveBeenCalledWith({
method: 'POST',
path: '/_security/saml/invalidate',
body: { queryString: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
body: { query_string: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
});
});
@ -1324,7 +1324,7 @@ describe('SAMLAuthenticationProvider', () => {
expect(mockOptions.client.asInternalUser.transport.request).toHaveBeenCalledWith({
method: 'POST',
path: '/_security/saml/invalidate',
body: { queryString: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
body: { query_string: 'SAMLRequest=xxx%20yyy', realm: 'test-realm' },
});
});

4
x-pack/plugins/security/server/authentication/providers/saml.ts
View file

@ -624,9 +624,9 @@ export class SAMLAuthenticationProvider extends BaseAuthenticationProvider {
await this.options.client.asInternalUser.transport.request({
method: 'POST',
path: '/_security/saml/invalidate',
// Elasticsearch expects `queryString` without leading `?`, so we should strip it with `slice`.
// Elasticsearch expects `query_string` without leading `?`, so we should strip it with `slice`.
body: {
queryString: request.url.search ? request.url.search.slice(1) : '',
query_string: request.url.search ? request.url.search.slice(1) : '',
realm: this.realm,
},
})