github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.18] [ES|QL] Fixes the values control FT (#211159) (#211280)

Browse source 
# Backport

This will backport the following commits from `main` to `8.18`:
- [[ES|QL] Fixes the values control FT
(#211159)](https://github.com/elastic/kibana/pull/211159)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-02-14T17:00:03Z","message":"[ES|QL]
Fixes the values control FT (#211159)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/208454\n\nAttempt to make the
value controls FR more
stable","sha":"d3fd2ed7701b54f6048046d3f93e1bc8929dd686","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Presentation","Feature:ES|QL","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ES|QL]
Fixes the values control
FT","number":211159,"url":"https://github.com/elastic/kibana/pull/211159","mergeCommit":{"message":"[ES|QL]
Fixes the values control FT (#211159)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/208454\n\nAttempt to make the
value controls FR more
stable","sha":"d3fd2ed7701b54f6048046d3f93e1bc8929dd686"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211159","number":211159,"mergeCommit":{"message":"[ES|QL]
Fixes the values control FT (#211159)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/208454\n\nAttempt to make the
value controls FR more
stable","sha":"d3fd2ed7701b54f6048046d3f93e1bc8929dd686"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This commit is contained in:
Kibana Machine 2025-02-15 05:48:41 +11:00 • committed by GitHub
parent d916369824
commit dd449b3158
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
test/functional/apps/dashboard/esql_controls/value_control.ts
View file

@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const browser = getService('browser');
const comboBox = getService('comboBox');
describe('dashboard - add an value type ES|QL control', function () {
describe('dashboard - add a value type ES|QL control', function () {
before(async () => {
await kibanaServer.savedObjects.cleanStandardList();
await kibanaServer.importExport.load(
@ -86,19 +86,20 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// Check Lens editor has been updated accordingly
const editorValue = await esql.getEsqlEditorQuery();
expect(editorValue).to.contain('FROM logstash-* | WHERE geo.dest == ?geo_dest');
});
it('should update the Lens chart accordingly', async () => {
// change the table to keep only the column with the control
await esql.setEsqlEditorQuery(
'FROM logstash-* | WHERE geo.dest == ?geo_dest | KEEP geo.dest'
);
// run the query
await testSubjects.click('ESQLEditor-run-query-button');
await dashboard.waitForRenderComplete();
// save the changes
await testSubjects.click('applyFlyoutButton');
});
it('should update the Lens chart accordingly', async () => {
await dashboard.waitForRenderComplete();
// change the control value
await comboBox.set('esqlControlValuesDropdown', 'AO');
await dashboard.waitForRenderComplete();
@ -107,7 +108,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(tableContent).to.contain('AO');
});
it('should handle properly a query to retrieve the values that returns more than one column', async () => {
it('should handle properly a query to retrieve the values that return more than one column', async () => {
const firstId = (await dashboardControls.getAllControlIds())[0];
await dashboardControls.editExistingControl(firstId);