github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[input controls] use KuiCheckBoxLabel to ensure proper spacing between checkbox and label (#15301) (#15330)

Browse source 
* use KuiCheckBoxLabel to ensure proper spacing between checkbox and label

* upper case Kibana

* fix broken jest test
This commit is contained in:
Nathan Reese 2017-11-30 16:43:33 -07:00 • committed by GitHub
parent 1f99c049bc
commit de8988397c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/core_plugins/input_control_vis/public/components/editor/__snapshots__/options_tab.test.js.snap
View file

@ -14,16 +14,13 @@ exports[`renders OptionsTab 1`] = `
<KuiFieldGroupSection
isWide={false}
>
<label>
<input
checked={false}
className="kuiCheckBox"
data-test-subj="inputControlEditorUpdateFiltersOnChangeCheckbox"
onChange={[Function]}
type="checkbox"
/>
Update kibana filters on each change
</label>
<KuiCheckBoxLabel
data-test-subj="inputControlEditorUpdateFiltersOnChangeCheckbox"
isChecked={false}
isDisabled={false}
onChange={[Function]}
text="Update Kibana filters on each change"
/>
</KuiFieldGroupSection>
</KuiFieldGroup>
</div>

21
src/core_plugins/input_control_vis/public/components/editor/options_tab.js
View file

@ -1,7 +1,10 @@
import _ from 'lodash';
import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { KuiFieldGroup, KuiFieldGroupSection } from 'ui_framework/components';
import {
KuiFieldGroup,
KuiFieldGroupSection,
KuiCheckBoxLabel } from 'ui_framework/components';
export class OptionsTab extends Component {
constructor(props) {
@ -28,16 +31,12 @@ export class OptionsTab extends Component {
<div className="vis-editor-agg-header">
<KuiFieldGroup>
<KuiFieldGroupSection>
<label>
<input
className="kuiCheckBox"
type="checkbox"
checked={this.props.scope.vis.params.updateFiltersOnChange}
onChange={this.handleUpdateFiltersChange}
data-test-subj="inputControlEditorUpdateFiltersOnChangeCheckbox"
/>
Update kibana filters on each change
</label>
<KuiCheckBoxLabel
text="Update Kibana filters on each change"
isChecked={this.props.scope.vis.params.updateFiltersOnChange}
onChange={this.handleUpdateFiltersChange}
data-test-subj="inputControlEditorUpdateFiltersOnChangeCheckbox"
/>
</KuiFieldGroupSection>
</KuiFieldGroup>
</div>

2
src/core_plugins/input_control_vis/public/components/editor/options_tab.test.js
View file

@ -32,7 +32,7 @@ test('updateFiltersOnChange', () => {
scope={scopeMock}
stageEditorParams={stageEditorParams}
/>);
const checkbox = component.find('[data-test-subj="inputControlEditorUpdateFiltersOnChangeCheckbox"]');
const checkbox = component.find('[data-test-subj="inputControlEditorUpdateFiltersOnChangeCheckbox"] input[type="checkbox"]');
checkbox.simulate('change', { target: { checked: true } });
const expectedParams = {
updateFiltersOnChange: true