github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixes Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/builtin_alert_types/index_threshold/alert·ts - alerting api integration spaces only Alerting builtin alertTypes index_threshold rule runs correctly: avg all (#144266)

Browse source 
* Unskipping test

* Adding logger

* i dunno

* Separate test

* Increasing lookback window

* trying this fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Ying Mao 2022-11-07 08:59:50 -05:00 • committed by GitHub
parent 2782a22a7c
commit decfde6663
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 43 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

50
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/builtin_alert_types/index_threshold/alert.ts
View file

@ -14,6 +14,7 @@ import {
ES_TEST_INDEX_NAME,
getUrlPrefix,
ObjectRemover,
getEventLog,
} from '../../../../../common/lib';
import { createEsDocumentsWithGroups } from '../lib/create_test_data';
import { createDataStream, deleteDataStream } from '../lib/create_test_data';
@ -37,8 +38,7 @@ export default function ruleTests({ getService }: FtrProviderContext) {
const esTestIndexTool = new ESTestIndexTool(es, retry);
const esTestIndexToolOutput = new ESTestIndexTool(es, retry, ES_TEST_OUTPUT_INDEX_NAME);
// Failing: See https://github.com/elastic/kibana/issues/142335
describe.skip('rule', async () => {
describe('rule', async () => {
let endDate: string;
let connectorId: string;
const objectRemover = new ObjectRemover(supertest);
@ -194,14 +194,12 @@ export default function ruleTests({ getService }: FtrProviderContext) {
// write documents from now to the future end date in 3 groups
await createEsDocumentsInGroups(3);
// this never fires because of bad fields error
await createRule({
name: 'never fire',
timeField: 'source', // bad field for time
aggType: 'avg',
aggField: 'source', // bad field for agg
aggField: 'testedValue',
groupBy: 'all',
thresholdComparator: '>',
thresholdComparator: '<',
threshold: [0],
});
@ -210,6 +208,7 @@ export default function ruleTests({ getService }: FtrProviderContext) {
aggType: 'avg',
aggField: 'testedValue',
groupBy: 'all',
timeWindowSize: RULE_INTERVAL_SECONDS * 10,
thresholdComparator: '>=',
threshold: [0],
});
@ -224,7 +223,7 @@ export default function ruleTests({ getService }: FtrProviderContext) {
expect(name).to.be('always fire');
const messagePattern =
/alert 'always fire' is active for group \'all documents\':\n\n- Value: .*\n- Conditions Met: avg\(testedValue\) is greater than or equal to 0 over 15s\n- Timestamp: \d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z/;
/alert 'always fire' is active for group \'all documents\':\n\n- Value: .*\n- Conditions Met: avg\(testedValue\) is greater than or equal to 0 over 30s\n- Timestamp: \d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}.\d{3}Z/;
expect(message).to.match(messagePattern);
}
});
@ -533,6 +532,43 @@ export default function ruleTests({ getService }: FtrProviderContext) {
expect(message).to.contain('Value: 5');
});
it('runs and gracefully handles ES errors', async () => {
// write documents from now to the future end date in 3 groups
await createEsDocumentsInGroups(3);
// this never fires because of bad fields error
const ruleId = await createRule({
name: 'never fire',
timeField: 'source', // bad field for time
aggType: 'avg',
aggField: 'source', // bad field for agg
groupBy: 'all',
thresholdComparator: '>',
threshold: [0],
});
// create some more documents in the first group
await createEsDocumentsInGroups(1);
// get the events we're expecting
const events = await retry.try(async () => {
return await getEventLog({
getService,
spaceId: Spaces.space1.id,
type: 'alert',
id: ruleId,
provider: 'alerting',
actions: new Map([['execute', { gte: 2 }]]),
});
});
for (const event of events) {
expect(event?.rule?.name).to.eql('never fire');
expect(event?.kibana?.alerting?.outcome).to.eql('success');
expect(event?.message).to.eql(`rule executed: .index-threshold:${ruleId}: 'never fire'`);
}
});
async function createEsDocumentsInGroups(
groups: number,
indexName: string = ES_TEST_INDEX_NAME