github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.6] Fix typos in @kbn/handlebars package (#146385) (#146392)

Browse source 
# Backport

This will backport the following commits from `main` to `8.6`:
- [Fix typos in @kbn/handlebars package
(#146385)](https://github.com/elastic/kibana/pull/146385)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thomas
Watson","email":"watson@elastic.co"},"sourceCommit":{"committedDate":"2022-11-28T13:39:55Z","message":"Fix
typos in @kbn/handlebars package (#146385)\n\nAs a follow up to #146174
here's a PR containing the typo-fixes found
by\r\n@azasypkin.","sha":"185993c4b903062100cdb95f7cc73c2d17007dca","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:prev-minor","v8.7.0"],"number":146385,"url":"https://github.com/elastic/kibana/pull/146385","mergeCommit":{"message":"Fix
typos in @kbn/handlebars package (#146385)\n\nAs a follow up to #146174
here's a PR containing the typo-fixes found
by\r\n@azasypkin.","sha":"185993c4b903062100cdb95f7cc73c2d17007dca"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146385","number":146385,"mergeCommit":{"message":"Fix
typos in @kbn/handlebars package (#146385)\n\nAs a follow up to #146174
here's a PR containing the typo-fixes found
by\r\n@azasypkin.","sha":"185993c4b903062100cdb95f7cc73c2d17007dca"}}]}]
BACKPORT-->

Co-authored-by: Thomas Watson <watson@elastic.co>
This commit is contained in:
Kibana Machine 2022-11-28 10:08:29 -05:00 • committed by GitHub
parent 857c20a1f3
commit e1a755107c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/kbn-handlebars/README.md
View file

@ -69,7 +69,7 @@ The tests for `@kbn/handlebars` are integrated into the regular test suite of Ki
node scripts/jest packages/kbn-handlebars
```
By default each test will run both the original `handlebars` code and the modified `@kbn/handlebars` code to compare if the output of the two are identical. To isolate a test run to just one or the other, you can use the following environment variables:
By default, each test will run both the original `handlebars` code and the modified `@kbn/handlebars` code to compare if the output of the two are identical. To isolate a test run to just one or the other, you can use the following environment variables:
- `EVAL=1` - Set to only run the original `handlebars` implementation that uses `eval`.
- `AST=1` - Set to only run the modified `@kbn/handlebars` implementation that doesn't use `eval`.
@ -84,7 +84,7 @@ Some of the tests have been copied from the upstream `handlebars` project and mo
If the script outputs a diff for a given file, it means that this file has been updated.
_Note: that this will look for chanages in the `4.x` branch of the `handlebars.js` repo only. Changes in the `master` branch are ignored._
_Note: that this will look for changes in the `4.x` branch of the `handlebars.js` repo only. Changes in the `master` branch are ignored._
Once all updates have been manually merged with our versions of the files, run the following script to "lock" us into the new updates:
@ -196,4 +196,4 @@ You can pretty print just the generated code using this command:
node -e 'process.stdin.on(`data`, c => console.log(`(${eval(`(${c})`).code})`))' | \
npx prettier --write --stdin-filepath template.js | \
npx cli-highlight -l javascript
```
```

2
packages/kbn-handlebars/src/upstream/index.builtins.test.ts
View file

@ -276,7 +276,7 @@ describe('builtin helpers', () => {
// TODO: This test has been added to the `4.x` branch of the handlebars.js repo along with a code-fix,
// but a new version of the handlebars package containing this fix has not yet been published to npm.
//
// Before enabling this code, a new version of handlebars needs to be released and the corrosponding
// Before enabling this code, a new version of handlebars needs to be released and the corresponding
// updates needs to be applied to this implementation.
//
// See: https://github.com/handlebars-lang/handlebars.js/commit/30dbf0478109ded8f12bb29832135d480c17e367