github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ESLint I18n Rule] Cleanup (#181959)

Browse source 
## Summary

Just a tiny cleanup PR that was leftover.
This commit is contained in:
Coen Warmer 2024-04-29 15:23:30 +02:00 • committed by GitHub
parent 694acf7040
commit e28cb6eca6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

28
packages/kbn-eslint-plugin-i18n/rules/i18n_translate_should_start_with_the_right_id.ts
View file

@ -78,25 +78,35 @@ export const I18nTranslateShouldStartWithTheRightId: Rule.RuleModule = {
}
if (identifier && !identifier.startsWith(`${i18nAppId}.`)) {
const oldI18nIdentifierArray = identifier.split('.');
const i18nIdentifierRange = node.arguments[0].range;
const newI18nIdentifier =
const oldI18nIdentifierArray = identifier.split('.');
const correctI18nIdentifier =
oldI18nIdentifierArray[0] === 'xpack'
? `${i18nAppId}.${oldI18nIdentifierArray.slice(2).join('.')}`
: `${i18nAppId}.${oldI18nIdentifierArray.slice(1).join('.')}`;
const opts = node.arguments[1]
? sourceCode.getText().slice(node.arguments[1].range[0], node.arguments[1].range[1])
: "{ defaultMessage: '' }";
const hasExistingOpts = node.arguments.length > 1;
report({
node: node as any,
message: RULE_WARNING_MESSAGE,
fix(fixer) {
return fixer.replaceTextRange(
node.range,
`i18n.translate('${newI18nIdentifier}', ${opts})`
);
return [
hasExistingOpts
? // if there are existing options, only replace the i18n identifier and keep the options
fixer.replaceTextRange(i18nIdentifierRange, `\'${correctI18nIdentifier}\'`)
: // if there are no existing options, add an options object with an empty default message
fixer.replaceTextRange(
i18nIdentifierRange,
`\'${correctI18nIdentifier}\', { defaultMessage: '' }`
),
!hasI18nImportLine && rangeToAddI18nImportLine
? replaceMode === 'replace'
? fixer.replaceTextRange(rangeToAddI18nImportLine, i18nImportLine)
: fixer.insertTextAfterRange(rangeToAddI18nImportLine, `\n${i18nImportLine}`)
: null,
].filter(isTruthy);
},
});
}