github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Lens] Unification of filtering labels (#163389)

Browse source 
## Summary

Changes the texts as proposed
[here](https://github.com/elastic/kibana/issues/160872) (for both lens
and aggbased visualizations)

<img width="996" alt="image"
src="f7e29a36-a6d3-4ad2-832c-4d58505a8a51">

<img width="1073" alt="image"
src="74b74773-f1f4-4ba5-b727-e144eef955f2">
This commit is contained in:
Stratoula Kalafateli 2023-08-09 09:40:36 +03:00 • committed by GitHub
parent da0fb1d987
commit e3e0558aa4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/plugins/chart_expressions/expression_partition_vis/public/utils/get_legend_actions.tsx
View file

@ -64,7 +64,7 @@ export const getLegendActions = (
panelItems.push(
{
name: i18n.translate('expressionPartitionVis.legend.filterForValueButtonAriaLabel', {
defaultMessage: 'Filter for value',
defaultMessage: 'Filter for',
}),
'data-test-subj': `legend-${title}-filterIn`,
icon: <EuiIcon type="plusInCircle" size="m" />,
@ -75,7 +75,7 @@ export const getLegendActions = (
},
{
name: i18n.translate('expressionPartitionVis.legend.filterOutValueButtonAriaLabel', {
defaultMessage: 'Filter out value',
defaultMessage: 'Filter out',
}),
'data-test-subj': `legend-${title}-filterOut`,
icon: <EuiIcon type="minusInCircle" size="m" />,

4
src/plugins/chart_expressions/expression_xy/public/components/legend_action_popover.tsx
View file

@ -56,7 +56,7 @@ export const LegendActionPopover: React.FunctionComponent<LegendActionPopoverPro
items: [
{
name: i18n.translate('expressionXY.legend.filterForValueButtonAriaLabel', {
defaultMessage: 'Filter for value',
defaultMessage: 'Filter for',
}),
'data-test-subj': `legend-${label}-filterIn`,
icon: <EuiIcon type="plusInCircle" size="m" />,
@ -67,7 +67,7 @@ export const LegendActionPopover: React.FunctionComponent<LegendActionPopoverPro
},
{
name: i18n.translate('expressionXY.legend.filterOutValueButtonAriaLabel', {
defaultMessage: 'Filter out value',
defaultMessage: 'Filter out',
}),
'data-test-subj': `legend-${label}-filterOut`,
icon: <EuiIcon type="minusInCircle" size="m" />,

8
src/plugins/vis_types/table/public/components/table_vis_columns.tsx
View file

@ -69,13 +69,13 @@ export const createGridColumns = (
const filterForText = i18n.translate(
'visTypeTable.tableCellFilter.filterForValueText',
{
defaultMessage: 'Filter for value',
defaultMessage: 'Filter for',
}
);
const filterForAriaLabel = i18n.translate(
'visTypeTable.tableCellFilter.filterForValueAriaLabel',
{
defaultMessage: 'Filter for value: {cellContent}',
defaultMessage: 'Filter for: {cellContent}',
values: {
cellContent,
},
@ -105,13 +105,13 @@ export const createGridColumns = (
const filterOutText = i18n.translate(
'visTypeTable.tableCellFilter.filterOutValueText',
{
defaultMessage: 'Filter out value',
defaultMessage: 'Filter out',
}
);
const filterOutAriaLabel = i18n.translate(
'visTypeTable.tableCellFilter.filterOutValueAriaLabel',
{
defaultMessage: 'Filter out value: {cellContent}',
defaultMessage: 'Filter out: {cellContent}',
values: {
cellContent,
},

4
src/plugins/vis_types/vislib/public/vislib/components/legend/legend_item.tsx
View file

@ -65,7 +65,7 @@ const VisLegendItemComponent = ({
{
id: 'filterIn',
label: i18n.translate('visTypeVislib.vislib.legend.filterForValueButtonAriaLabel', {
defaultMessage: 'Filter for value {legendDataLabel}',
defaultMessage: 'Filter for {legendDataLabel}',
values: { legendDataLabel: item.label },
}),
iconType: 'plusInCircle',
@ -74,7 +74,7 @@ const VisLegendItemComponent = ({
{
id: 'filterOut',
label: i18n.translate('visTypeVislib.vislib.legend.filterOutValueButtonAriaLabel', {
defaultMessage: 'Filter out value {legendDataLabel}',
defaultMessage: 'Filter out {legendDataLabel}',
values: { legendDataLabel: item.label },
}),
iconType: 'minusInCircle',

4
x-pack/plugins/lens/public/shared_components/legend/action/legend_action_popover.tsx
View file

@ -40,7 +40,7 @@ export const LegendActionPopover: React.FunctionComponent<LegendActionPopoverPro
items: [
{
name: i18n.translate('xpack.lens.shared.legend.filterForValueButtonAriaLabel', {
defaultMessage: 'Filter for value',
defaultMessage: 'Filter for',
}),
'data-test-subj': `legend-${label}-filterIn`,
icon: <EuiIcon type="plusInCircle" size="m" />,
@ -51,7 +51,7 @@ export const LegendActionPopover: React.FunctionComponent<LegendActionPopoverPro
},
{
name: i18n.translate('xpack.lens.shared.legend.filterOutValueButtonAriaLabel', {
defaultMessage: 'Filter out value',
defaultMessage: 'Filter out',
}),
'data-test-subj': `legend-${label}-filterOut`,
icon: <EuiIcon type="minusInCircle" size="m" />,

12
x-pack/plugins/lens/public/visualizations/datatable/components/columns.tsx
View file

@ -91,13 +91,13 @@ export const createGridColumns = (
const filterForText = i18n.translate(
'xpack.lens.table.tableCellFilter.filterForValueText',
{
defaultMessage: 'Filter for value',
defaultMessage: 'Filter for',
}
);
const filterForAriaLabel = i18n.translate(
'xpack.lens.table.tableCellFilter.filterForValueAriaLabel',
{
defaultMessage: 'Filter for value: {cellContent}',
defaultMessage: 'Filter for: {cellContent}',
values: {
cellContent,
},
@ -129,13 +129,13 @@ export const createGridColumns = (
const filterOutText = i18n.translate(
'xpack.lens.table.tableCellFilter.filterOutValueText',
{
defaultMessage: 'Filter out value',
defaultMessage: 'Filter out',
}
);
const filterOutAriaLabel = i18n.translate(
'xpack.lens.table.tableCellFilter.filterOutValueAriaLabel',
{
defaultMessage: 'Filter out value: {cellContent}',
defaultMessage: 'Filter out: {cellContent}',
values: {
cellContent,
},
@ -230,7 +230,7 @@ export const createGridColumns = (
onClick: () => handleTransposedColumnClick(bucketValues, false),
iconType: 'plusInCircle',
label: i18n.translate('xpack.lens.table.columnFilter.filterForValueText', {
defaultMessage: 'Filter for column',
defaultMessage: 'Filter for',
}),
'data-test-subj': 'lensDatatableHide',
});
@ -241,7 +241,7 @@ export const createGridColumns = (
onClick: () => handleTransposedColumnClick(bucketValues, true),
iconType: 'minusInCircle',
label: i18n.translate('xpack.lens.table.columnFilter.filterOutValueText', {
defaultMessage: 'Filter out column',
defaultMessage: 'Filter out',
}),
'data-test-subj': 'lensDatatableHide',
});