github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-27 18:51:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ES|QL] Simplify function to retrieve categorize column (#225281)

Browse source 
## Summary

Simplifies the function to extract the categorize function field. The
unit tests we had pass for the new implementation so I am sure we don't
introduce new bugs
This commit is contained in:
Stratoula Kalafateli 2025-06-26 17:22:50 +02:00 • committed by GitHub
parent 26d56b5060
commit e401aa4c07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/platform/packages/shared/kbn-esql-utils/src/utils/query_parsing_helpers.ts
View file

@ -369,47 +369,17 @@ export const getArgsFromRenameFunction = (
*/
export const getCategorizeField = (esql: string): string[] => {
const { root } = parse(esql);
const statsCommand = root.commands.find(({ name }) => name === 'stats');
if (!statsCommand) {
return [];
}
const options: ESQLCommandOption[] = [];
const columns: string[] = [];
walk(statsCommand, {
visitCommandOption: (node) => options.push(node),
});
const statsByOptions = options.find(({ name }) => name === 'by');
// categorize is part of the stats by command
if (!statsByOptions) {
return [];
}
const categorizeOptions = statsByOptions.args.filter((arg) => {
return (arg as ESQLFunction).text.toLowerCase().indexOf('categorize') !== -1;
const functions = Walker.matchAll(root.commands, {
type: 'function',
name: 'categorize',
}) as ESQLFunction[];
if (categorizeOptions.length) {
categorizeOptions.forEach((arg) => {
// ... STATS ... BY CATEGORIZE(field)
if (isFunctionExpression(arg) && arg.name === 'categorize') {
walk(arg, {
visitColumn: (node) => columns.push(node.name),
});
} else {
// ... STATS ... BY pattern = CATEGORIZE(field)
walk(arg, {
visitFunction: (node) => {
if (node.name === 'categorize') {
const columnArgs = node.args.filter((a) => isColumn(a));
columnArgs.forEach((c) => columns.push((c as ESQLColumn).name));
}
},
});
}
if (functions.length) {
functions.forEach((func) => {
for (const arg of func.args) if (isColumn(arg)) columns.push(arg.name);
});
return columns;
}
return columns;