[eslint] reenable no-extra-semi and quotes rules (#9473)

* [eslint] re-enable no-extra-semi and quotes rules

* [eslint] update to version 0.2.2 of eslint config

* [eslint] autofix

.eslintrc

@@ -2,5 +2,3 @@
 extends: '@elastic/kibana'
 rules:
   no-unused-vars: off
-  no-extra-semi: off
-  quotes: off

package.json

@@ -169,7 +169,7 @@
     "wreck": "6.2.0"
   },
   "devDependencies": {
-    "@elastic/eslint-config-kibana": "0.2.1",
+    "@elastic/eslint-config-kibana": "0.2.2",
     "angular-mocks": "1.4.7",
     "auto-release-sinon": "1.0.3",
     "babel-eslint": "6.1.2",

src/cli_plugin/install/cleanup.js

@@ -19,7 +19,7 @@ export function cleanPrevious(settings, logger) {
       resolve();
     }
   });
-};
+}
 
 export function cleanArtifacts(settings) {
   // delete the working directory.
@@ -29,4 +29,4 @@ export function cleanArtifacts(settings) {
     rimraf.sync(settings.plugins[0].path);
   }
   catch (e) {} // eslint-disable-line no-empty
-};
+}

src/cli_plugin/install/download.js

@@ -42,4 +42,4 @@ export function download(settings, logger) {
   }
 
   return tryNext();
-};
+}

src/cli_plugin/install/index.js

@@ -49,4 +49,4 @@ export default function pluginInstall(program) {
   install file:///Path/to/my/x-pack.zip
   install https://path.to/my/x-pack.zip`)
   .action(processCommand);
-};
+}

src/cli_plugin/install/pack.js

@@ -140,4 +140,4 @@ export async function extract(settings, logger) {
     logger.error(err);
     throw new Error('Error extracting plugin archive');
   }
-};
+}

src/cli_plugin/install/settings.js

@@ -21,7 +21,7 @@ export function parseMilliseconds(val) {
   }
 
   return result;
-};
+}
 
 export function parse(command, options, kbnPackage) {
   const settings = {
@@ -44,4 +44,4 @@ export function parse(command, options, kbnPackage) {
   };
 
   return settings;
-};
+}

src/cli_plugin/lib/errors.js

@@ -1 +1 @@
-export class UnsupportedProtocolError extends Error {};
+export class UnsupportedProtocolError extends Error {}

src/cli_plugin/lib/logger.js

@@ -41,6 +41,6 @@ export default class Logger {
     }
     process.stderr.write(`${data}\n`);
     this.previousLineEnded = true;
-  };
+  }
 
 }

src/cli_plugin/list/index.js

@@ -29,4 +29,4 @@ export default function pluginList(program) {
     )
     .description('list installed plugins')
     .action(processCommand);
-};
+}

src/cli_plugin/list/settings.js

@@ -6,4 +6,4 @@ export function parse(command, options) {
   };
 
   return settings;
-};
+}

src/cli_plugin/remove/index.js

@@ -39,4 +39,4 @@ export default function pluginRemove(program) {
 `common examples:
   remove x-pack`)
   .action(processCommand);
-};
+}

src/cli_plugin/remove/settings.js

@@ -12,4 +12,4 @@ export function parse(command, options) {
   settings.pluginPath = resolve(settings.pluginDir, settings.plugin);
 
   return settings;
-};
+}

src/core_plugins/console/public/src/app.js

@@ -110,4 +110,4 @@ export default function init(input, output, sourceLocation = 'stored') {
   loadSavedState();
   setupAutosave();
   mappings.retrieveAutocompleteInfoFromServer();
-};
+}

src/core_plugins/console/public/src/input.js

@@ -242,8 +242,8 @@ export function initializeInput($el, $actionsEl, $copyAsCurlEl, output) {
   require('./input_resize')(input, output);
 
   return input;
-};
+}
 
 export default function getInput() {
   return input;
-};
+}

src/core_plugins/console/public/src/output.js

@@ -65,8 +65,8 @@ export function initializeOutput($el) {
   }
 
   return output;
-};
+}
 
 export default function getOutput() {
   return output;
-};
+}

src/core_plugins/elasticsearch/lib/create_proxy.js

@@ -39,7 +39,7 @@ function createProxy(server, method, route, config) {
   assign(options.config, config);
 
   server.route(options);
-};
+}
 
 createProxy.createPath = function createPath(path) {
   const pre = '/elasticsearch';

src/core_plugins/elasticsearch/lib/map_uri.js

@@ -45,4 +45,4 @@ export default function mapUri(server, prefix) {
     const mappedUrl = formatUrl(mappedUrlComponents);
     done(null, mappedUrl, mappedHeaders);
   };
-};
+}

src/core_plugins/kbn_doc_views/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/kbn_vislib_vis_types/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/area.js

@@ -83,4 +83,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/histogram.js

@@ -79,4 +79,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/line.js

@@ -89,4 +89,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/pie.js

@@ -70,4 +70,4 @@ export default function HistogramVisType(Private) {
       }
     ])
   });
-};
+}

src/core_plugins/kbn_vislib_vis_types/public/tile_map.js

@@ -113,4 +113,4 @@ export default function TileMapVisType(Private, getAppState, courier, config) {
       }
     ])
   });
-};
+}

src/core_plugins/kibana/public/dashboard/__tests__/dashboard_panels.js

@@ -24,7 +24,7 @@ describe('dashboard panels', function () {
       $compile($el)($scope);
       $scope.$digest();
     });
-  };
+  }
 
   function findPanelWithVisualizationId(id) {
     return $scope.state.panels.find((panel) => { return panel.id === id; });

src/core_plugins/kibana/public/dashboard/components/panel/lib/load_panel.js

@@ -15,4 +15,4 @@ export function loadPanelProvider(Private) { // Inject services here
     }
 
   };
-};
+}

src/core_plugins/kibana/public/dashboard/components/panel/lib/search.js

@@ -21,4 +21,4 @@ export function searchLoaderProvider(savedSearches, Private) { // Inject service
         };
       });
   };
-};
+}

src/core_plugins/kibana/public/dashboard/components/panel/lib/visualization.js

@@ -20,4 +20,4 @@ export function visualizationLoaderProvider(savedVisualizations, Private) { // I
       };
     });
   };
-};
+}

src/core_plugins/kibana/public/dashboard/directives/grid.js

@@ -106,7 +106,7 @@ app.directive('dashboardGrid', function ($compile, Notifier) {
             });
 
             added.forEach(addPanel);
-          };
+          }
 
           // ensure that every panel can be serialized now that we are done
           $state.panels.forEach(PanelUtils.makeSerializeable);

src/core_plugins/kibana/public/dashboard/services/saved_dashboard_register.js

@@ -1,3 +1,3 @@
 export function savedDashboardRegister(savedDashboards) {
   return savedDashboards;
-};
+}

src/core_plugins/kibana/public/discover/controllers/discover.js

@@ -593,4 +593,4 @@ function discoverController($scope, config, courier, $route, $window, Notifier,
   }
 
   init();
-};
+}

src/core_plugins/kibana/public/discover/saved_searches/saved_search_register.js

@@ -1,3 +1,3 @@
 export default function savedSearchObjectFn(savedSearches) {
   return savedSearches;
-};
+}

src/core_plugins/kibana/public/management/sections/indices/_date_scripts.js

@@ -23,4 +23,4 @@ export default function (indexPattern) {
   });
 
   return dateScripts;
-};
+}

src/core_plugins/kibana/public/management/sections/indices/_edit_sections.js

@@ -30,4 +30,4 @@ export default function GetFieldTypes() {
       }
     ];
   };
-};
+}

src/core_plugins/kibana/public/management/sections/indices/_refresh_kibana_index.js

@@ -4,4 +4,4 @@ export default function RefreshKibanaIndexFn(es, kbnIndex) {
       index: kbnIndex
     });
   };
-};
+}

src/core_plugins/kibana/public/visualize/editor/editor.js

@@ -363,4 +363,4 @@ function VisEditor($scope, $route, timefilter, AppState, $location, kbnUrl, $tim
   }
 
   init();
-};
+}

src/core_plugins/kibana/public/visualize/saved_visualizations/saved_visualization_register.js

@@ -1,3 +1,3 @@
 export default function savedVisualizationFn(savedVisualizations) {
   return savedVisualizations;
-};
+}

src/core_plugins/markdown_vis/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/metric_vis/index.js

@@ -10,4 +10,4 @@ export default function (kibana) {
 
   });
 
-};
+}

src/core_plugins/spy_modes/index.js

@@ -7,4 +7,4 @@ export default function (kibana) {
       ]
     }
   });
-};
+}

src/core_plugins/status_page/index.js

@@ -9,4 +9,4 @@ export default function (kibana) {
       }
     }
   });
-};
+}

src/core_plugins/table_vis/index.js

@@ -8,4 +8,4 @@ export default function (kibana) {
     }
   });
 
-};
+}

src/core_plugins/tagcloud/index.js

@@ -5,4 +5,4 @@ export default function (kibana) {
       visTypes: ['plugins/tagcloud/tag_cloud_vis']
     }
   });
-};
+}

src/core_plugins/tagcloud/public/tag_cloud.js

@@ -226,7 +226,7 @@ class TagCloud extends EventEmitter {
       resolveWhenDone();
     });
 
-  };
+  }
 
   _makeTextSizeMapper() {
     const mapSizeToFontSize = D3_SCALING_FUNCTIONS[this._textScale]();

src/core_plugins/timelion/public/app.js

@@ -158,7 +158,7 @@ app.controller('timelion', function (
           if (!$scope.running) $scope.search();
           startRefresh();
         }, interval.value);
-      };
+      }
       startRefresh();
     }
   });
@@ -234,7 +234,7 @@ app.controller('timelion', function (
         }
       }
     });
-  };
+  }
 
   function saveExpression(title) {
     savedVisualizations.get({type: 'timelion'}).then(function (savedExpression) {
@@ -248,7 +248,7 @@ app.controller('timelion', function (
         if (id) notify.info('Saved expression as "' + savedExpression.title + '"');
       });
     });
-  };
+  }
 
   function dismissNotifications() {
     unsafeNotifications.splice(0, unsafeNotifications.length);

src/core_plugins/timelion/public/directives/docs.js

@@ -22,7 +22,7 @@ define(function (require) {
           };
           getFunctions();
           checkElasticsearch();
-        };
+        }
 
         function getFunctions() {
           return $http.get('../api/timelion/functions').then(function (resp) {
@@ -61,7 +61,7 @@ define(function (require) {
             }
             return $scope.es.valid;
           });
-        };
+        }
         init();
       }
     };

src/core_plugins/timelion/public/directives/expression_directive.js

@@ -215,11 +215,11 @@ app.directive('timelionExpression', function ($compile, $http, $timeout, $rootSc
         });
 
         return bestFunction;
-      };
+      }
 
       function getCaretPos() {
         return $elem[0].selectionStart;
-      };
+      }
 
       function digest() {
         $rootScope.$$phase || $scope.$digest();

src/core_plugins/timelion/public/lib/calculate_interval.js

@@ -40,4 +40,4 @@ function roundInterval(interval) {
     default:
       return '1y';
   }
-};
+}

src/core_plugins/timelion/public/panels/timechart/xaxis_formatter.js

@@ -19,7 +19,7 @@ module.exports = function xaxisFormatterProvider(config, timefilter) {
     }
 
     return config.get('dateFormat');
-  };
+  }
 
   return function (esInterval) {
     return getFormat(esInterval);

src/core_plugins/timelion/server/lib/get_namespaced_settings.js

@@ -15,7 +15,7 @@ module.exports = function () {
       });
     }(nestedObj));
     return flatObj;
-  };
+  }
 
   const timelionDefaults = flattenWith('.', configFile);
   return _.reduce(timelionDefaults, (result, value, key) => {

src/core_plugins/timelion/server/series_functions/es/lib/agg_response_to_series_list.js

@@ -46,4 +46,4 @@ export default function toSeriesList(aggs, config) {
       label: name
     };
   });
-};
+}

src/core_plugins/timelion/server/series_functions/holt/lib/tes.js

@@ -35,7 +35,7 @@ function initSeasonalComponents(samplePoints, seasonLength) {
   });
 
   return seasonals;
-};
+}
 
 // This is different from the DES method of establishing trend because it looks for
 // the difference in points between seasons

src/core_plugins/timelion/server/series_functions/props.js

@@ -19,7 +19,7 @@ function unflatten(data) {
   });
 
   return result[''] || result;
-};
+}
 
 module.exports = new Chainable('props', {
   args: [

src/fixtures/agg_resp/geohash_grid.js

@@ -78,4 +78,4 @@ export default function GeoHashGridAggResponseFixture() {
       }
     }
   };
-};
+}

src/fixtures/agg_resp/range.js

@@ -1,35 +1,35 @@
 export default {
-  "took": 35,
-  "timed_out": false,
-  "_shards": {
-    "total": 7,
-    "successful": 7,
-    "failed": 0
+  'took': 35,
+  'timed_out': false,
+  '_shards': {
+    'total': 7,
+    'successful': 7,
+    'failed': 0
   },
-  "hits": {
-    "total": 218512,
-    "max_score": 0,
-    "hits": []
+  'hits': {
+    'total': 218512,
+    'max_score': 0,
+    'hits': []
   },
-  "aggregations": {
-    "1": {
-      "buckets": {
-        "*-1024.0": {
-          "to": 1024,
-          "to_as_string": "1024.0",
-          "doc_count": 20904
+  'aggregations': {
+    '1': {
+      'buckets': {
+        '*-1024.0': {
+          'to': 1024,
+          'to_as_string': '1024.0',
+          'doc_count': 20904
         },
-        "1024.0-2560.0": {
-          "from": 1024,
-          "from_as_string": "1024.0",
-          "to": 2560,
-          "to_as_string": "2560.0",
-          "doc_count": 23358
+        '1024.0-2560.0': {
+          'from': 1024,
+          'from_as_string': '1024.0',
+          'to': 2560,
+          'to_as_string': '2560.0',
+          'doc_count': 23358
         },
-        "2560.0-*": {
-          "from": 2560,
-          "from_as_string": "2560.0",
-          "doc_count": 174250
+        '2560.0-*': {
+          'from': 2560,
+          'from_as_string': '2560.0',
+          'doc_count': 174250
         }
       }
     }

src/fixtures/fake_row.js

@@ -17,4 +17,4 @@ export default function (id, mapping) {
     $$_partialFormatted: fakeVals('formatted'),
     $$_flattened: fakeVals('_flattened')
   };
-};
+}

src/fixtures/hits.js

@@ -19,4 +19,4 @@ export default function fitsFixture() {
       _index: 'test-index'
     });
   });
-};
+}

src/fixtures/mock_courier.js

@@ -13,4 +13,4 @@ export default function (Private, Promise) {
   };
 
   return courier;
-};
+}

src/fixtures/stubbed_logstash_index_pattern.js

@@ -22,4 +22,4 @@ export default function stubbedLogstashIndexPatternService(Private) {
 
   return indexPattern;
 
-};
+}

src/fixtures/stubbed_search_source.js

@@ -35,4 +35,4 @@ export default function stubSearchSource(Private, $q, Promise) {
     }
   };
 
-};
+}

src/server/config/complete.js

@@ -8,4 +8,4 @@ export default function (kbnServer, server, config) {
   for (const [key, val] of config.getPendingSets()) {
     server.log(['warning', 'config'], { key, val, tmpl });
   }
-};
+}

src/server/config/deep_clone_with_buffers.js

@@ -8,4 +8,4 @@ function cloneBuffersCustomizer(val) {
 
 export default function (vals) {
   return cloneDeep(vals, cloneBuffersCustomizer);
-};
+}

src/server/http/__tests__/version_check.js

@@ -31,7 +31,7 @@ describe('version_check request filter', function () {
     });
 
     return kbnServer;
-  };
+  }
 
   let kbnServer;
   beforeEach(async () => kbnServer = await makeServer());

src/server/http/short_url_lookup.js

@@ -100,4 +100,4 @@ export default function (server) {
       }
     }
   };
-};
+}

src/server/lib/commander_extensions.js

@@ -6,4 +6,4 @@ export default function (program) {
   program.isCommandSpecified = function () {
     return program.args.some(isCommand);
   };
-};
+}

src/server/logging/index.js

@@ -12,4 +12,4 @@ export default function (kbnServer, server, config) {
       options: loggingConfiguration(config)
     }, cb);
   });
-};
+}

src/server/logging/log_interceptor.js

@@ -69,4 +69,4 @@ export class LogInterceptor extends Stream.Transform {
     this.push(downgraded || event);
     next();
   }
-};
+}

src/server/status/index.js

@@ -49,4 +49,4 @@ export default function (kbnServer, server, config) {
       return reply.renderStatusPage();
     }
   }));
-};
+}

src/test_utils/simulate_keys.js

@@ -101,4 +101,4 @@ export default function ($el, sequence) {
     const $event = new $.Event(type, _.defaults({ keyCode: keyCode }, modifierState));
     $target.trigger($event);
   }
-};
+}

src/test_utils/stub_index_pattern.js

@@ -52,4 +52,4 @@ export default function (Private) {
   }
 
   return StubIndexPattern;
-};
+}

src/ui/public/agg_response/geo_json/_tooltip_formatter.js

@@ -37,4 +37,4 @@ export default function TileMapTooltipFormatter($compile, $rootScope, Private) {
 
     return $el.html();
   };
-};
+}

src/ui/public/agg_response/geo_json/geo_json.js

@@ -40,4 +40,4 @@ export default function TileMapConverterFn(Private, timefilter, $compile, $rootS
       }
     };
   };
-};
+}

src/ui/public/agg_response/hierarchical/_array_to_linked_list.js

@@ -9,4 +9,4 @@ export default function (buckets) {
     previous = bucket;
   });
   return buckets;
-};
+}

src/ui/public/agg_response/hierarchical/_build_split.js

@@ -13,4 +13,4 @@ export default function biuldSplitProvider(Private) {
     split.names = collectKeys(split.slices.children);
     return split;
   };
-};
+}

src/ui/public/agg_response/hierarchical/_collect_keys.js

@@ -7,4 +7,4 @@ export default function collectKeys(children) {
   .flattenDeep()
   .union(keys)
   .value();
-};
+}

src/ui/public/agg_response/hierarchical/_create_raw_data.js

@@ -89,4 +89,4 @@ export default function (vis, resp) {
   walkBuckets(buckets[0], resp.aggregations);
 
   return results;
-};
+}

src/ui/public/agg_response/hierarchical/_extract_buckets.js

@@ -10,4 +10,4 @@ export default function (bucket, agg) {
   } else {
     return bucket && bucket.buckets || [];
   }
-};
+}

src/ui/public/agg_response/hierarchical/_hierarchical_tooltip_formatter.js

@@ -41,4 +41,4 @@ export default function HierarchicalTooltipFormaterProvider($rootScope, $compile
 
   };
 
-};
+}

src/ui/public/agg_response/hierarchical/_transform_aggregation.js

@@ -36,4 +36,4 @@ export default function transformAggregationProvider(Private) {
       return branch;
     });
   };
-};
+}

src/ui/public/agg_response/hierarchical/build_hierarchical_data.js

@@ -94,4 +94,4 @@ export default function buildHierarchicalDataProvider(Private, Notifier) {
 
     return result;
   };
-};
+}

src/ui/public/agg_response/index.js

@@ -10,4 +10,4 @@ export default function NormalizeChartDataFactory(Private) {
     tabify: Private(AggResponseTabifyTabifyProvider),
     geoJson: Private(AggResponseGeoJsonGeoJsonProvider)
   };
-};
+}

src/ui/public/agg_response/point_series/_add_to_siri.js

@@ -12,4 +12,4 @@ export default function PointSeriesAddToSiri() {
       values: [point]
     });
   };
-};
+}

src/ui/public/agg_response/point_series/_fake_x_aspect.js

@@ -27,4 +27,4 @@ export default function PointSeriesFakeXAxis(Private) {
       }
     };
   };
-};
+}

src/ui/public/agg_response/point_series/_get_aspects.js

@@ -55,4 +55,4 @@ export default function PointSeriesGetAspects(Private) {
 
     return aspects;
   };
-};
+}

src/ui/public/agg_response/point_series/_get_point.js

@@ -40,4 +40,4 @@ export default function PointSeriesGetPoint() {
 
     return point;
   };
-};
+}

src/ui/public/agg_response/point_series/_get_series.js

@@ -60,4 +60,4 @@ export default function PointSeriesGetSeries(Private) {
 
     return series;
   };
-};
+}

src/ui/public/agg_response/point_series/_init_y_axis.js

@@ -17,4 +17,4 @@ export default function PointSeriesInitYAxis() {
     const xAggOutput = x.agg.write();
     chart.yScale = xAggOutput.metricScale || null;
   };
-};
+}

src/ui/public/agg_response/point_series/_ordered_date_axis.js

@@ -24,4 +24,4 @@ export default function PointSeriesOrderedDateAxis(timefilter) {
       chart.ordered.endzones = false;
     }
   };
-};
+}

src/ui/public/agg_response/point_series/_tooltip_formatter.js

@@ -40,4 +40,4 @@ export default function PointSeriesTooltipFormatter($compile, $rootScope) {
     $tooltipScope.$apply();
     return $tooltip[0].outerHTML;
   };
-};
+}

src/ui/public/agg_response/point_series/point_series.js

@@ -33,4 +33,4 @@ export default function PointSeriesProvider(Private) {
     delete chart.aspects;
     return chart;
   };
-};
+}

src/ui/public/agg_response/tabify/_buckets.js

@@ -29,4 +29,4 @@ export default function AggResponseBucketsProvider() {
   };
 
   return Buckets;
-};
+}

src/ui/public/agg_response/tabify/_get_columns.js

@@ -47,4 +47,4 @@ export default function GetColumnsProvider(Private) {
 
     return columns;
   };
-};
+}

src/ui/public/agg_response/tabify/_response_writer.js

@@ -280,4 +280,4 @@ export default function TabbedAggResponseWriterProvider(Private) {
   };
 
   return TabbedAggResponseWriter;
-};
+}

src/ui/public/agg_response/tabify/_table.js

@@ -35,4 +35,4 @@ export default function TableProvider() {
 
 
   return Table;
-};
+}

src/ui/public/agg_response/tabify/_table_group.js

@@ -21,4 +21,4 @@ export default function TableGroupProvider() {
   };
 
   return TableGroup;
-};
+}

src/ui/public/agg_response/tabify/tabify.js

@@ -101,4 +101,4 @@ export default function tabifyAggResponseProvider(Private, Notifier) {
   }
 
   return notify.timed('tabify agg response', tabifyAggResponse);
-};
+}

src/ui/public/agg_types/agg_params.js

@@ -74,4 +74,4 @@ export default function AggParamsFactory(Private) {
   };
 
   return AggParams;
-};
+}

src/ui/public/agg_types/agg_type.js

@@ -147,4 +147,4 @@ export default function AggTypeFactory(Private) {
   };
 
   return AggType;
-};
+}

src/ui/public/agg_types/buckets/_bucket_agg_type.js

@@ -17,4 +17,4 @@ export default function BucketAggTypeProvider(Private) {
   };
 
   return BucketAggType;
-};
+}