github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix Data Streams and Rollups Jobs deep-link bugs (#70903)

Browse source 
* Add extractQueryParams to es_ui_shared/public/url. Update CCR, Remote Clusters, and Rollup to consume this service via shared_imports.
* Fix Data Streams bug in which clicking a data stream would apply a deep-link filter to the table.
* Fix Rollup Job deep-link bug.
This commit is contained in:
CJ Cenizal 2020-07-07 05:41:50 -07:00 • committed by GitHub
parent 648468dae1
commit e58cc173f1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
28 changed files with 89 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

3
x-pack/plugins/remote_clusters/public/application/sections/remote_cluster_add/remote_cluster_add.js
View file

@ -10,7 +10,8 @@ import { FormattedMessage } from '@kbn/i18n/react';
import { EuiPageContent } from '@elastic/eui';
import { getRouter, redirect, extractQueryParams } from '../../services';
import { extractQueryParams } from '../../../shared_imports';
import { getRouter, redirect } from '../../services';
import { setBreadcrumbs } from '../../services/breadcrumb';
import { RemoteClusterPageTitle, RemoteClusterForm } from '../components';

3
x-pack/plugins/remote_clusters/public/application/sections/remote_cluster_edit/remote_cluster_edit.js
View file

@ -21,7 +21,8 @@ import {
} from '@elastic/eui';
import { reactRouterNavigate } from '../../../../../../../src/plugins/kibana_react/public';
import { extractQueryParams, getRouter, redirect } from '../../services';
import { extractQueryParams } from '../../../shared_imports';
import { getRouter, redirect } from '../../services';
import { setBreadcrumbs } from '../../services/breadcrumb';
import { RemoteClusterPageTitle, RemoteClusterForm, ConfiguredByNodeWarning } from '../components';

2
x-pack/plugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_list.js
View file

@ -29,7 +29,7 @@ import {
} from '@elastic/eui';
import { reactRouterNavigate } from '../../../../../../../src/plugins/kibana_react/public';
import { extractQueryParams } from '../../services';
import { extractQueryParams } from '../../../shared_imports';
import { setBreadcrumbs } from '../../services/breadcrumb';
import { RemoteClusterTable } from './remote_cluster_table';

2
x-pack/plugins/remote_clusters/public/application/services/index.js
View file

@ -12,8 +12,6 @@ export { initRedirect, redirect } from './redirect';
export { isAddressValid, isPortValid } from './validate_address';
export { extractQueryParams } from './query_params';
export { setUserHasLeftApp, getUserHasLeftApp, registerRouter, getRouter } from './routing';
export { trackUiMetric, METRIC_TYPE } from './ui_metric';

8
x-pack/plugins/remote_clusters/public/application/store/actions/add_cluster.js
View file

@ -6,12 +6,8 @@
import { i18n } from '@kbn/i18n';
import {
addCluster as sendAddClusterRequest,
getRouter,
extractQueryParams,
redirect,
} from '../../services';
import { extractQueryParams } from '../../../shared_imports';
import { addCluster as sendAddClusterRequest, getRouter, redirect } from '../../services';
import { fatalError, toasts } from '../../services/notification';
import {

3
x-pack/plugins/remote_clusters/public/application/store/actions/detail_panel.js
View file

@ -4,7 +4,8 @@
* you may not use this file except in compliance with the Elastic License.
*/
import { extractQueryParams, getRouter } from '../../services';
import { extractQueryParams } from '../../../shared_imports';
import { getRouter } from '../../services';
import { OPEN_DETAIL_PANEL, CLOSE_DETAIL_PANEL } from '../action_types';
export const openDetailPanel = ({ name }) => (dispatch) => {

8
x-pack/plugins/remote_clusters/public/application/store/actions/edit_cluster.js
View file

@ -9,12 +9,8 @@ import { i18n } from '@kbn/i18n';
import { toasts, fatalError } from '../../services/notification';
import { loadClusters } from './load_clusters';
import {
editCluster as sendEditClusterRequest,
extractQueryParams,
getRouter,
redirect,
} from '../../services';
import { extractQueryParams } from '../../../shared_imports';
import { editCluster as sendEditClusterRequest, getRouter, redirect } from '../../services';
import {
EDIT_CLUSTER_START,

11
x-pack/plugins/remote_clusters/public/application/services/query_params.js → x-pack/plugins/remote_clusters/public/shared_imports.ts
View file

@ -4,13 +4,4 @@
* you may not use this file except in compliance with the Elastic License.
*/
import { parse } from 'query-string';
export function extractQueryParams(queryString) {
const hrefSplit = queryString.split('?');
if (!hrefSplit.length) {
return {};
}
return parse(hrefSplit[1], { sort: false });
}
export { extractQueryParams, indices } from '../../../../src/plugins/es_ui_shared/public';