github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #7521 from cjcenizal/style/html-multiple-attributes

Browse source 
Change HTML style guide. Specify that the opening tag's closing bracket goes on its own line.
This commit is contained in:
CJ Cenizal 2016-06-27 09:33:58 -07:00 • committed by GitHub
commit e5a60ef707
1 changed files with 18 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

26
style_guides/html_style_guide.md
View file

@ -3,16 +3,26 @@
## Multiple attribute values
When a node has multiple attributes that would cause it to exceed the 80-character line limit, each attribute including the first should be on its own line with a single indent. Also, when a node that is styled in this way has child nodes, there should be a blank line between the opening parent tag and the first child tag.
When a node has multiple attributes, each attribute including the first should be on its own line with a single indent.
The closing bracket should be on its own line. This allows attributes to be shuffled and edited without having to move the bracket around. It also makes it easier to scan vertically and match opening and closing brackets.
```
<ul
<div
attribute1="value1"
attribute2="value2"
attribute3="value3">
<li></li>
<li></li>
...
</ul>
attribute3="value3"
>
Hello
</div>
```
If the node doesn't have child notes, add the closing tag on the same line as the opening tag's closing bracket.
```
<div
attribute1="value1"
attribute2="value2"
attribute3="value3"
></div>
```