github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Use the same date for set alert timestmap (#192668)

Browse source 
## Summary

Looks like [there can
be](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6918#0191e0e0-8cde-48a7-a47e-d0919db0f220)
situation when new Date() can produce slightly different result for
those fields

So, I just extract them into 1 variable
This commit is contained in:
Khristinin Nikita 2024-09-13 13:16:48 +02:00 • committed by GitHub
parent bdcf9d56c4
commit e5f0134464
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts
View file

@ -65,16 +65,18 @@ const augmentAlerts = <T>({
intendedTimestamp: Date | undefined;
}) => {
const commonRuleFields = getCommonAlertFields(options);
const currentDate = new Date();
const timestampOverrideOrCurrent = currentTimeOverride ?? currentDate;
return alerts.map((alert) => {
return {
...alert,
_source: {
[ALERT_RULE_EXECUTION_TIMESTAMP]: new Date(),
[ALERT_START]: currentTimeOverride ?? new Date(),
[ALERT_LAST_DETECTED]: currentTimeOverride ?? new Date(),
[ALERT_RULE_EXECUTION_TIMESTAMP]: currentDate,
[ALERT_START]: timestampOverrideOrCurrent,
[ALERT_LAST_DETECTED]: timestampOverrideOrCurrent,
[ALERT_INTENDED_TIMESTAMP]: intendedTimestamp
? intendedTimestamp
: currentTimeOverride ?? new Date(),
: timestampOverrideOrCurrent,
[VERSION]: kibanaVersion,
...(options?.maintenanceWindowIds?.length
? { [ALERT_MAINTENANCE_WINDOW_IDS]: options.maintenanceWindowIds }