github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Attempt at fix for flaky Cases FTR tests (#156248)

Browse source
This commit is contained in:
Coen Warmer 2023-05-01 13:22:00 +02:00 • committed by GitHub
parent 4e88645b59
commit e6366c0432
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

11
x-pack/test/observability_functional/apps/observability/pages/alerts/add_to_case.ts
View file

@ -12,8 +12,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
const observability = getService('observability');
const retry = getService('retry');
// Failing: See https://github.com/elastic/kibana/issues/154726
describe.skip('Observability alerts / Add to case >', function () {
describe('Observability alerts / Add to case >', function () {
this.tags('includeFirefox');
before(async () => {
@ -26,7 +25,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
await esArchiver.unload('x-pack/test/functional/es_archives/observability/alerts');
});
describe('When user has all priviledges for cases', () => {
describe('When user has all privileges for cases', () => {
before(async () => {
await observability.users.setTestUserRole(
observability.users.defineBasicObservabilityRole({
@ -49,8 +48,10 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
});
});
it('opens a flyout when Add to new case is clicked', async () => {
await observability.alerts.addToCase.addToNewCaseButtonClick();
it('opens a flyout when "Add to new case" is clicked', async () => {
await retry.try(async () => {
await observability.alerts.addToCase.addToNewCaseButtonClick();
});
await retry.try(async () => {
await observability.alerts.addToCase.getCreateCaseFlyoutOrFail();

33
x-pack/test/observability_functional/apps/observability/pages/cases/case_details.ts
View file

@ -16,6 +16,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const observability = getService('observability');
const find = getService('find');
const PageObjects = getPageObjects(['common', 'header']);
const retry = getService('retry');
describe('Observability cases', () => {
before(async () => {
@ -38,25 +39,29 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
);
const owner = 'observability';
const caseData = await cases.api.createCase({
title: 'Sample case',
owner,
});
await cases.api.createAttachment({
caseId: caseData.id,
params: {
alertId: ['alert-id'],
index: ['.internal.alerts-observability.alerts-default-000001'],
rule: { id: 'rule-id', name: 'My rule name' },
type: CommentType.alert,
await retry.try(async () => {
const caseData = await cases.api.createCase({
title: 'Sample case',
owner,
},
});
await cases.api.createAttachment({
caseId: caseData.id,
params: {
alertId: ['alert-id'],
index: ['.internal.alerts-observability.alerts-default-000001'],
rule: { id: 'rule-id', name: 'My rule name' },
type: CommentType.alert,
owner,
},
});
});
});
after(async () => {
await cases.api.deleteAllCases();
await observability.users.restoreDefaultTestUserRole();
await retry.try(async () => {
await cases.api.deleteAllCases();
await observability.users.restoreDefaultTestUserRole();
});
});
it('should link to observability rule pages in case details', async () => {