github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Update eui deprecated components in screenshotting plugin (#164068)

Browse source 
## Summary

Partially addresses https://github.com/elastic/kibana/issues/161422

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Vadim Kibana 2023-09-11 20:50:05 +02:00 • committed by GitHub
parent 1b5f105c25
commit e72780ae80
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

42
x-pack/plugins/screenshotting/public/app/app.tsx
View file

@ -7,14 +7,6 @@
import './app.scss';
import React, { useContext, useMemo, useRef } from 'react';
import {
EuiFlexGroup,
EuiFlexItem,
EuiPage,
EuiPageBody,
EuiPageContent_Deprecated as EuiPageContent,
EuiPageContentBody_Deprecated as EuiPageContentBody,
} from '@elastic/eui';
import type { ExpressionRendererParams } from '@kbn/expressions-plugin/public';
import { useExpressionRenderer } from '@kbn/expressions-plugin/public';
import { SCREENSHOTTING_EXPRESSION, SCREENSHOTTING_EXPRESSION_INPUT } from '../../common';
@ -40,28 +32,16 @@ export function App() {
});
return (
<EuiPage paddingSize="none" data-shared-items-container data-shared-items-count={1}>
<EuiPageBody>
<EuiPageContent
borderRadius="none"
hasShadow={false}
paddingSize="none"
className="eui-fullHeight"
>
<EuiPageContentBody className="eui-fullHeight">
<EuiFlexGroup className="eui-fullHeight" gutterSize="none" direction="column">
<EuiFlexItem className="eui-fullHeight">
<div
data-shared-item={!isEmpty || !error || null}
data-render-error={!isEmpty && error ? error.message : null}
ref={elementRef}
className="scrExpression"
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageContentBody>
</EuiPageContent>
</EuiPageBody>
</EuiPage>
<div
data-shared-item={!isEmpty || !error || null}
data-render-error={!isEmpty && error ? error.message : null}
ref={elementRef}
className="scrExpression"
style={{
background: 'white',
width: '100vw',
height: '100vh',
}}
/>
);
}

36
x-pack/plugins/screenshotting/public/plugin.tsx
View file

@ -21,26 +21,24 @@ interface SetupDeps {
export class ScreenshottingPlugin implements Plugin<void, void, SetupDeps> {
setup({ application }: CoreSetup, { screenshotMode }: SetupDeps) {
if (!screenshotMode.isScreenshotMode()) {
return;
if (screenshotMode.isScreenshotMode()) {
application.register({
id: SCREENSHOTTING_APP_ID,
title: 'Screenshotting Expressions Renderer',
navLinkStatus: AppNavLinkStatus.hidden,
chromeless: true,
mount: async ({ element }: AppMountParameters) => {
ReactDOM.render(
<ScreenshotModeContext.Provider value={screenshotMode}>
<App />
</ScreenshotModeContext.Provider>,
element
);
return () => ReactDOM.unmountComponentAtNode(element);
},
});
}
application.register({
id: SCREENSHOTTING_APP_ID,
title: 'Screenshotting Expressions Renderer',
navLinkStatus: AppNavLinkStatus.hidden,
chromeless: true,
mount: async ({ element }: AppMountParameters) => {
ReactDOM.render(
<ScreenshotModeContext.Provider value={screenshotMode}>
<App />
</ScreenshotModeContext.Provider>,
element
);
return () => ReactDOM.unmountComponentAtNode(element);
},
});
}
start() {}