github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Upgrade assistant] Fix the "Fix" button for ML snapshots in need of upgrade (#119745) (#119850)

Browse source 
The deprecations for ML snapshots that are too old and need
upgrading are supposed to have a "Fix" button next to them.
Unfortunately this disappeared when a message was reworded
in elastic/elasticsearch#79387.

This change adjusts the regex that the upgrade assistant
uses to detect which deprecations to add the "Fix" button
to so that it will match both "Model snapshot" and "model
snapshot". The test data is also updated to match the new
backend text.

This change is designed to work with elastic/elasticsearch#81060.

Co-authored-by: David Roberts <dave.roberts@elastic.co>
This commit is contained in:
Kibana Machine 2021-11-29 11:08:51 -05:00 • committed by GitHub
parent 12d4882904
commit e792a294f4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/upgrade_assistant/server/lib/es_deprecations_status.ts
View file

@ -139,7 +139,7 @@ const getCorrectiveAction = (
);
const requiresReindexAction = /Index created before/.test(message);
const requiresIndexSettingsAction = Boolean(indexSettingDeprecation);
const requiresMlAction = /model snapshot/.test(message);
const requiresMlAction = /[Mm]odel snapshot/.test(message);
if (requiresReindexAction) {
return {

2
x-pack/plugins/upgrade_assistant/server/routes/ml_snapshots.ts
View file

@ -63,7 +63,7 @@ const verifySnapshotUpgrade = async (
const { body: deprecations } = await esClient.asCurrentUser.migration.deprecations();
const mlSnapshotDeprecations = deprecations.ml_settings.filter((deprecation) => {
return /model snapshot/.test(deprecation.message);
return /[Mm]odel snapshot/.test(deprecation.message);
});
// If there are no ML deprecations, we assume the deprecation was resolved successfully

5
x-pack/plugins/upgrade_assistant/server/routes/status.test.ts
View file

@ -49,9 +49,8 @@ describe('Status API', () => {
{
level: 'critical',
message:
'model snapshot [1] for job [deprecation_check_job] needs to be deleted or upgraded',
details:
'model snapshot [%s] for job [%s] supports minimum version [%s] and needs to be at least [%s]',
'Model snapshot [1] for job [deprecation_check_job] has an obsolete minimum version [6.3.0].',
details: 'Delete model snapshot [1] or update it to 7.0.0 or greater.',
url: 'doc_url',
correctiveAction: {
type: 'mlSnapshot',