github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.8] Unskips spaces nav test for Chrome, skips spaces selection suite for Firefox only (#158700) (#158740)

Browse source 
# Backport

This will backport the following commits from `main` to `8.8`:
- [Unskips spaces nav test for Chrome, skips spaces selection suite for
Firefox only (#158700)](https://github.com/elastic/kibana/pull/158700)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-05-31T15:20:45Z","message":"Unskips
spaces nav test for Chrome, skips spaces selection suite for Firefox
only (#158700)\n\n## Summary\r\n\r\nThe Firefox update to v113 has
resulted in slower test execution time\r\nand ultimately some timeout
failures. Auto-skip functionality skips the\r\ntest suite completely.
This PR removes Firefox testing for the spaces\r\nselection suite and
unskips the spaces nav test.\r\n\r\nFlaky Test Runner (just for good
measure):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2337","sha":"208e359aad16f6962cd1b125602b9010ae138c40","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.9.0","v8.8.1"],"number":158700,"url":"https://github.com/elastic/kibana/pull/158700","mergeCommit":{"message":"Unskips
spaces nav test for Chrome, skips spaces selection suite for Firefox
only (#158700)\n\n## Summary\r\n\r\nThe Firefox update to v113 has
resulted in slower test execution time\r\nand ultimately some timeout
failures. Auto-skip functionality skips the\r\ntest suite completely.
This PR removes Firefox testing for the spaces\r\nselection suite and
unskips the spaces nav test.\r\n\r\nFlaky Test Runner (just for good
measure):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2337","sha":"208e359aad16f6962cd1b125602b9010ae138c40"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158700","number":158700,"mergeCommit":{"message":"Unskips
spaces nav test for Chrome, skips spaces selection suite for Firefox
only (#158700)\n\n## Summary\r\n\r\nThe Firefox update to v113 has
resulted in slower test execution time\r\nand ultimately some timeout
failures. Auto-skip functionality skips the\r\ntest suite completely.
This PR removes Firefox testing for the spaces\r\nselection suite and
unskips the spaces nav test.\r\n\r\nFlaky Test Runner (just for good
measure):\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2337","sha":"208e359aad16f6962cd1b125602b9010ae138c40"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
This commit is contained in:
Kibana Machine 2023-05-31 12:19:44 -04:00 • committed by GitHub
parent f006d49dd1
commit e7f919889d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
x-pack/test/functional/apps/spaces/spaces_selection.ts
View file

@ -35,7 +35,11 @@ export default function spaceSelectorFunctionalTests({
}
});
this.tags('includeFirefox');
// FLAKY: https://github.com/elastic/kibana/issues/157760 (amongst others)
// Skipping only Firefox, as the flaky failures are caused by slow CI execution with new version of Firefox
// See also https://github.com/elastic/kibana/pull/158545
// Can un-comment line below when issue is resolved
// this.tags('includeFirefox');
describe('Login Space Selector', () => {
before(async () => {
await PageObjects.security.forceLogout();
@ -59,8 +63,7 @@ export default function spaceSelectorFunctionalTests({
});
});
// FLAKY: https://github.com/elastic/kibana/issues/157760
describe.skip('Space Navigation Menu', () => {
describe('Space Navigation Menu', () => {
before(async () => {
await PageObjects.security.forceLogout();
await PageObjects.security.login(undefined, undefined, {
@ -96,7 +99,6 @@ export default function spaceSelectorFunctionalTests({
});
describe('Search spaces in popover', function () {
this.tags('skipFirefox');
const spaceId = 'default';
before(async () => {
await PageObjects.security.forceLogout();
@ -129,7 +131,6 @@ export default function spaceSelectorFunctionalTests({
});
describe('Spaces Data', function () {
this.tags('skipFirefox');
const spaceId = 'another-space';
const sampleDataHash = '/tutorial_directory/sampleData';