github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.x] [EuiProvider] Hide unwanted toast until a fix can be done !! (#203244) (#203327)

Browse source 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[EuiProvider] Hide unwanted toast until a fix can be done !!
(#203244)](https://github.com/elastic/kibana/pull/203244)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-06T18:59:55Z","message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com/elastic/kibana/issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[EuiProvider]
Hide unwanted toast until a fix can be done
!!","number":203244,"url":"https://github.com/elastic/kibana/pull/203244","mergeCommit":{"message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com/elastic/kibana/issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203244","number":203244,"mergeCommit":{"message":"[EuiProvider]
Hide unwanted toast until a fix can be done !! (#203244)\n\n##
Summary\n\nHiding this until it can be fixed
via\nhttps://github.com/elastic/kibana/issues/201805 !!\n\n<img
width=\"1341\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/64d86aca-9c0e-4e94-9449-5f6a1c6a3288\">","sha":"354858264f84b624a6a4a1fc7a9b2961b7ba6ec0"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
This commit is contained in:
Kibana Machine 2024-12-07 07:45:49 +11:00 • committed by GitHub
parent f560d2d54a
commit e843309023
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx
View file

@ -182,6 +182,7 @@ export class ChromeService {
};
// Ensure developers are notified if working in a context that lacks the EUI Provider.
// @ts-expect-error
private handleEuiDevProviderWarning = (notifications: NotificationsStart) => {
const isDev = this.params.coreContext.env.mode.name === 'development';
if (isDev) {
@ -240,7 +241,8 @@ export class ChromeService {
}: StartDeps): Promise<InternalChromeStart> {
this.initVisibility(application);
this.handleEuiFullScreenChanges();
this.handleEuiDevProviderWarning(notifications);
// commented out until https://github.com/elastic/kibana/issues/201805 can be fixed
// this.handleEuiDevProviderWarning(notifications);
const globalHelpExtensionMenuLinks$ = new BehaviorSubject<ChromeGlobalHelpExtensionMenuLink[]>(
[]

3
test/plugin_functional/test_suites/shared_ux/eui_provider.ts
View file

@ -15,7 +15,8 @@ export default function ({ getPageObjects, getService }: PluginFunctionalProvide
const testSubjects = getService('testSubjects');
const browser = getService('browser');
describe('EUI Provider Dev Warning', () => {
// skipped until https://github.com/elastic/kibana/issues/201805 is resolved
describe.skip('EUI Provider Dev Warning', () => {
it('shows error toast to developer', async () => {
const pageTitle = 'EuiProvider test - Elastic';