[7.x] Update dependency eslint-plugin-import to v2.18.0 (#3993… (#39965)

* Update dependency eslint-plugin-import to v2.18.0

* fix new import order violations

package.json

@@ -361,7 +361,7 @@
     "eslint-config-prettier": "4.3.0",
     "eslint-plugin-babel": "5.3.0",
     "eslint-plugin-ban": "1.2.0",
-    "eslint-plugin-import": "2.17.3",
+    "eslint-plugin-import": "2.18.0",
     "eslint-plugin-jest": "22.7.1",
     "eslint-plugin-jsx-a11y": "6.2.1",
     "eslint-plugin-mocha": "5.3.0",

packages/eslint-config-kibana/package.json

@@ -22,7 +22,7 @@
     "eslint-plugin-babel": "5.3.0",
     "eslint-plugin-ban": "1.2.0",
     "eslint-plugin-jsx-a11y": "6.2.1",
-    "eslint-plugin-import": "2.17.3",
+    "eslint-plugin-import": "2.18.0",
     "eslint-plugin-jest": "^22.4.1",
     "eslint-plugin-mocha": "^5.3.0",
     "eslint-plugin-no-unsanitized": "3.0.2",

src/core/public/plugins/plugins_service.ts

@@ -17,7 +17,6 @@
  * under the License.
  */
 
-import { InternalCoreSetup, InternalCoreStart } from '..';
 import { PluginName } from '../../server';
 import { CoreService } from '../../types';
 import { CoreContext } from '../core_system';
@@ -27,6 +26,7 @@ import {
   createPluginSetupContext,
   createPluginStartContext,
 } from './plugin_context';
+import { InternalCoreSetup, InternalCoreStart } from '..';
 
 /** @internal */
 export type PluginsServiceSetupDeps = InternalCoreSetup;

src/core/server/http/cookie_session_storage.ts

@@ -20,9 +20,9 @@
 import { Request, Server } from 'hapi';
 import hapiAuthCookie from 'hapi-auth-cookie';
 
-import { Logger } from '..';
 import { KibanaRequest, ensureRawRequest } from './router';
 import { SessionStorageFactory, SessionStorage } from './session_storage';
+import { Logger } from '..';
 
 export interface SessionStorageCookieOptions<T> {
   name: string;

src/dev/i18n/tasks/extract_default_translations.ts

@@ -18,8 +18,8 @@
  */
 
 import chalk from 'chalk';
-import { ErrorReporter, extractMessagesFromPathToMap, filterConfigPaths, I18nConfig } from '..';
 import { createFailError } from '../../run';
+import { ErrorReporter, extractMessagesFromPathToMap, filterConfigPaths, I18nConfig } from '..';
 
 export function extractDefaultMessages({
   path,

src/dev/i18n/tasks/extract_untracked_translations.ts

@@ -17,6 +17,7 @@
  * under the License.
  */
 
+import { createFailError } from '../../run';
 import {
   I18nConfig,
   matchEntriesWithExctractors,
@@ -24,7 +25,6 @@ import {
   readFileAsync,
   ErrorReporter,
 } from '..';
-import { createFailError } from '../../run';
 
 function filterEntries(entries: string[], exclude: string[]) {
   return entries.filter((entry: string) =>

src/legacy/ui/public/agg_types/filter/agg_type_filters.ts

@@ -16,9 +16,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { AggType } from '..';
 import { IndexPattern } from '../../index_patterns';
 import { AggConfig } from '../../vis';
+import { AggType } from '..';
 
 type AggTypeFilter = (
   aggType: AggType,

src/legacy/ui/public/capabilities/react/inject_ui_capabilities.tsx

@@ -18,8 +18,8 @@
  */
 
 import React, { Component, ComponentClass, ComponentType } from 'react';
-import { UICapabilities } from '..';
 import { UICapabilitiesContext } from './ui_capabilities_context';
+import { UICapabilities } from '..';
 
 function getDisplayName(component: ComponentType<any>) {
   return component.displayName || component.name || 'Component';

src/legacy/ui/public/capabilities/react/ui_capabilities_provider.tsx

@@ -18,8 +18,8 @@
  */
 
 import React, { ReactNode } from 'react';
-import { capabilities } from '..';
 import { UICapabilitiesContext } from './ui_capabilities_context';
+import { capabilities } from '..';
 
 interface Props {
   children: ReactNode;

src/legacy/ui/public/vis/vis_types/vis_type.ts

@@ -18,8 +18,8 @@
  */
 
 import { IconType } from '@elastic/eui';
-import { RequestHandler, ResponseHandler, Vis } from '..';
 import { Status } from '../update_status';
+import { RequestHandler, ResponseHandler, Vis } from '..';
 
 export declare class VisualizationController {
   constructor(element: HTMLElement, vis: Vis);

x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/ErrorMetadata/index.tsx

@@ -5,9 +5,9 @@
  */
 
 import React from 'react';
-import { MetadataTable } from '..';
 import { ERROR_METADATA_SECTIONS } from './sections';
 import { APMError } from '../../../../../typings/es_schemas/ui/APMError';
+import { MetadataTable } from '..';
 
 interface Props {
   error: APMError;

x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/TransactionMetadata/index.tsx

@@ -5,9 +5,9 @@
  */
 
 import React from 'react';
-import { MetadataTable } from '..';
 import { TRANSACTION_METADATA_SECTIONS } from './sections';
 import { Transaction } from '../../../../../typings/es_schemas/ui/Transaction';
+import { MetadataTable } from '..';
 
 interface Props {
   transaction: Transaction;

x-pack/legacy/plugins/siem/public/components/open_timeline/open_timeline_modal/index.tsx

@@ -8,10 +8,9 @@ import { EuiButtonEmpty, EuiModal, EuiOverlayMask } from '@elastic/eui';
 import * as React from 'react';
 import styled from 'styled-components';
 
-import { StatefulOpenTimeline } from '..';
-
 import { ApolloConsumer } from 'react-apollo';
 import * as i18n from '../translations';
+import { StatefulOpenTimeline } from '..';
 
 export interface OpenTimelineModalButtonProps {
   /**

yarn.lock

@@ -11202,10 +11202,10 @@ eslint-plugin-es@^1.4.0:
     eslint-utils "^1.3.0"
     regexpp "^2.0.1"
 
-eslint-plugin-import@2.17.3:
-  version "2.17.3"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.17.3.tgz#00548b4434c18faebaba04b24ae6198f280de189"
-  integrity sha512-qeVf/UwXFJbeyLbxuY8RgqDyEKCkqV7YC+E5S5uOjAp4tOc8zj01JP3ucoBM8JcEqd1qRasJSg6LLlisirfy0Q==
+eslint-plugin-import@2.18.0:
+  version "2.18.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.18.0.tgz#7a5ba8d32622fb35eb9c8db195c2090bd18a3678"
+  integrity sha512-PZpAEC4gj/6DEMMoU2Df01C5c50r7zdGIN52Yfi7CvvWaYssG7Jt5R9nFG5gmqodxNOz9vQS87xk6Izdtpdrig==
   dependencies:
     array-includes "^3.0.3"
     contains-path "^0.1.0"