github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug in Discover no results screen caused by shard failure reason property being an object (#21601) (#21610)

Browse source
This commit is contained in:
CJ Cenizal 2018-08-02 12:13:47 -07:00 • committed by GitHub
parent 4065549d1d
commit ea4ec46021
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core_plugins/kibana/public/discover/directives/__snapshots__/no_results.test.js.snap
View file

@ -280,7 +280,7 @@ Array [
<code
class="euiCodeBlock__code"
>
Awful error
{"reason":"Awful error"}
</code>
</pre>
</div>
@ -309,7 +309,7 @@ Array [
<code
class="euiCodeBlock__code"
>
Bad error
{"reason":"Bad error"}
</code>
</pre>
</div>

2
src/core_plugins/kibana/public/discover/directives/no_results.js
View file

@ -48,7 +48,7 @@ export class DiscoverNoResults extends Component {
<EuiSpacer size="s" />
<EuiCodeBlock paddingSize="s">
{failure.reason}
{JSON.stringify(failure.reason)}
</EuiCodeBlock>
{index < shardFailures.length - 1 ? <EuiSpacer size="l" /> : undefined}

4
src/core_plugins/kibana/public/discover/directives/no_results.test.js
View file

@ -14,11 +14,11 @@ describe('DiscoverNoResults', () => {
const shardFailures = [{
index: 'A',
shard: '1',
reason: 'Awful error',
reason: { reason: 'Awful error' },
}, {
index: 'B',
shard: '2',
reason: 'Bad error',
reason: { reason: 'Bad error' },
}];
const component = render(