github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Filter out patterns starting with a comma (#17124) (#17151)

Browse source
This commit is contained in:
Chris Roberson 2018-03-14 13:05:29 -04:00 • committed by GitHub
parent b8fcf06336
commit ea7df636a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/__tests__/get_indices.test.js
View file

@ -19,6 +19,12 @@ describe('getIndices', () => {
expect((await getIndices(null, '*:')).length).toBe(0);
});
it('should ignore a single comma', async () => {
expect((await getIndices(null, ',')).length).toBe(0);
expect((await getIndices(null, ',*')).length).toBe(0);
expect((await getIndices(null, ',foobar')).length).toBe(0);
});
it('should trim the input', async () => {
let index;
const es = {

5
src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/get_indices.js
View file

@ -16,6 +16,11 @@ export async function getIndices(es, rawPattern, limit) {
return [];
}
// ES does not like just a `,*` and will throw a `[string_index_out_of_bounds_exception] String index out of range: 0`
if (pattern.startsWith(',')) {
return [];
}
// We need to always provide a limit and not rely on the default
if (!limit) {
throw '`getIndices()` was called without the required `limit` parameter.';