mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
* Add error when there is no histogram agg when using parent pipeline * Update error message * Update message * Add vis title to state * Revert unrelated changes * Update vis title when vis is renamed * Update title in url when renaming
This commit is contained in:
parent
bbb29c6416
commit
ebbe4d85ca
3 changed files with 10 additions and 3 deletions
|
@ -38,7 +38,11 @@ export const visualization = () => ({
|
|||
// special case in visualize, we need to render first (without executing the expression), for maps to work
|
||||
if (visConfig) {
|
||||
$rootScope.$apply(() => {
|
||||
handlers.vis.setCurrentState({ type: visType, params: visConfig });
|
||||
handlers.vis.setCurrentState({
|
||||
type: visType,
|
||||
params: visConfig,
|
||||
title: handlers.vis.title,
|
||||
});
|
||||
});
|
||||
}
|
||||
} else {
|
||||
|
|
|
@ -599,6 +599,10 @@ function VisEditor(
|
|||
} else if (savedVis.id === $route.current.params.id) {
|
||||
docTitle.change(savedVis.lastSavedTitle);
|
||||
chrome.breadcrumbs.set($injector.invoke(getEditBreadcrumbs));
|
||||
savedVis.vis.title = savedVis.title;
|
||||
savedVis.vis.description = savedVis.description;
|
||||
// it's needed to save the state to update url string
|
||||
$state.save();
|
||||
} else {
|
||||
kbnUrl.change(`${VisualizeConstants.EDIT_PATH}/{{id}}`, { id: savedVis.id });
|
||||
}
|
||||
|
|
|
@ -24,8 +24,7 @@ export default function ({ getService, getPageObjects }) {
|
|||
const retry = getService('retry');
|
||||
const PageObjects = getPageObjects(['common', 'visualize']);
|
||||
|
||||
// https://github.com/elastic/kibana/issues/37130
|
||||
describe.skip('data-shared-item', function indexPatternCreation() {
|
||||
describe('data-shared-item', function indexPatternCreation() {
|
||||
before(async function () {
|
||||
log.debug('navigateToApp visualize');
|
||||
await PageObjects.common.navigateToApp('visualize');
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue