github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Code] suppress error log if language server is not installed (#37541) (#37551)

Browse source
This commit is contained in:
Fuyao Zhao 2019-05-30 21:03:13 -07:00 • committed by GitHub
parent b80e0eceb2
commit ebd900251a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/plugins/code/server/indexer/lsp_indexer.ts
View file

@ -7,8 +7,11 @@
import fs from 'fs';
import util from 'util';
import { ResponseError } from 'vscode-jsonrpc';
import { ProgressReporter } from '.';
import { TEXT_FILE_LIMIT } from '../../common/file';
import { LanguageServerNotInstalled } from '../../common/lsp_error_codes';
import { toCanonicalUrl } from '../../common/uri_util';
import { Document, IndexStats, IndexStatsKey, LspIndexRequest, RepositoryUri } from '../../model';
import { GitOperations } from '../git_operations';
@ -231,8 +234,13 @@ export class LspIndexer extends AbstractIndexer {
this.log.debug(`Unsupported language. Skip symbols and references indexing.`);
}
} catch (error) {
this.log.error(`Index symbols or references error. Skip to file indexing.`);
this.log.error(error);
if (error instanceof ResponseError && error.code === LanguageServerNotInstalled) {
// TODO maybe need to report errors to the index task and warn user later
this.log.debug(`Index symbols or references error due to language server not installed`);
} else {
this.log.error(`Index symbols or references error.`);
this.log.error(error);
}
}
const language = await detectLanguage(filePath, Buffer.from(content));