github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-25 02:09:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix: Support columns with dots (#26659) (#26993)

Browse source 
Closes https://github.com/elastic/kibana/issues/26405

Upgrades tinymath so that columns with dots now work correctly.

---

To test, follow the details in #26405.

1. Get some data that has fields with dots in them. Beats data would work, or you can create a test index with just 2 documents as follows: 

```
POST test/test
{
  "string":"abc",
  "with.dot":"abc"
}
POST test/test
{
  "string":"abcd",
  "with.dot":"abcd"
}
```

2. Create a pie chart, splitting labels on one of the available fields.

Previously, given the POST info above, only `string` would work correctly. Now both (and both of their `.keyword` variants) work correctly.

![dec-04-2018 13-35-47](https://user-images.githubusercontent.com/404731/49473970-b2cf7a00-f7d0-11e8-995b-e1a5e2a2acba.gif)
This commit is contained in:
Joe Fleming 2018-12-11 15:44:41 -07:00 • committed by GitHub
parent 56fe06faa6
commit ebdba853e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -233,7 +233,7 @@
"style-loader": "0.23.1", "style-loader": "0.23.1",
"tar": "2.2.0", "tar": "2.2.0",
"tinygradient": "0.3.0", "tinygradient": "0.3.0",
"tinymath": "1.1.0", "tinymath": "1.1.1",
"topojson-client": "3.0.0", "topojson-client": "3.0.0",
"trunc-html": "1.0.2", "trunc-html": "1.0.2",
"trunc-text": "1.0.2", "trunc-text": "1.0.2",

2
x-pack/package.json
View file

@ -251,7 +251,7 @@
"styled-components": "3.3.3", "styled-components": "3.3.3",
"tar-fs": "1.13.0", "tar-fs": "1.13.0",
"tinycolor2": "1.3.0", "tinycolor2": "1.3.0",
"tinymath": "1.1.0", "tinymath": "1.1.1",
"tslib": "^1.9.3", "tslib": "^1.9.3",
"typescript-fsa": "^2.5.0", "typescript-fsa": "^2.5.0",
"typescript-fsa-reducers": "^0.4.5", "typescript-fsa-reducers": "^0.4.5",

8
yarn.lock
View file

@ -20039,10 +20039,10 @@ tinygradient@0.3.0:
dependencies: dependencies:
tinycolor2 "~1.0.0" tinycolor2 "~1.0.0"
tinymath@1.1.0: tinymath@1.1.1:
version "1.1.0" version "1.1.1"
resolved "https://registry.yarnpkg.com/tinymath/-/tinymath-1.1.0.tgz#1d26f1c4c65d70f9c62563fa7cdab87d66e39eaa" resolved "https://registry.yarnpkg.com/tinymath/-/tinymath-1.1.1.tgz#67f42ee0bb351508fe3a9ce4cb8db019ac4500ca"
integrity sha512-v3PNQ6zGKAqlj4labyqeTzndakdc9ODccx8IgrX1f+yzPW9mY0nlhKTRAPYOjay8gdvTyEnl2bik7huffZ5f/g== integrity sha512-dpnNUQvyO3AKvgJ5AtblOYuM/SJoSyjvhM7pstKzkVKUBRPMaSOi0+8h/QXMlfnOVFWV0qSpfxSAUAHKZ3XN2g==
title-case@^2.1.0: title-case@^2.1.0:
version "2.1.1" version "2.1.1"