github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[kbn-journey] disable APM for ES (#174848)

Browse source 
## Summary

Starting Friday noon our performance pipelines are failing on ES start:
```

  | 2024-01-12 18:24:35 CEST | proc [es]    │ info [o.e.b.Elasticsearch] [kb-static-ubuntu-01] fatal exception while booting Elasticsearch java.lang.IllegalArgumentException: Configuration [tracing.apm.agent.secret_token] is either prohibited or unknown.
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.telemetry.apm@8.13.0-SNAPSHOT/org.elasticsearch.telemetry.apm.internal.APMAgentSettings.lambda$static$5(APMAgentSettings.java:234)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.Setting.get(Setting.java:539)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.Setting.get(Setting.java:533)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:603)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:509)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:479)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:449)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.SettingsModule.<init>(SettingsModule.java:132)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.common.settings.SettingsModule.<init>(SettingsModule.java:50)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.node.NodeConstruction.validateSettings(NodeConstruction.java:479)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.node.NodeConstruction.prepareConstruction(NodeConstruction.java:246)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.node.Node.<init>(Node.java:192)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.bootstrap.Elasticsearch$2.<init>(Elasticsearch.java:236)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.bootstrap.Elasticsearch.initPhase3(Elasticsearch.java:236)
  | 2024-01-12 18:24:35 CEST | proc [es]    │      	at org.elasticsearch.server@8.13.0-SNAPSHOT/org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:73)
  | 2024-01-12 18:24:35 CEST | proc [es]    │ERROR ERROR: Elasticsearch did not exit normally - check the logs at /var/lib/buildkite-agent/builds/kb-static-ubuntu-01/elastic/kibana-single-user-performance/kibana/.es/8.13.0/logs/elasticsearch.log
  | 2024-01-12 18:24:35 CEST | proc [es]    │ERROR
  | 2024-01-12 18:24:37 CEST | proc [es]    │ERROR ERROR: Elasticsearch exited unexpectedly, with exit code 1
```

This PR temp disables APM for ES to unblock pipelines.

Update: we need to use elasticsearch keystore to provide
`tracing.apm.secret_token` for APM

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Dzmitry Lemechko 2024-01-15 23:21:26 +02:00 • committed by GitHub
parent c75f13a831
commit edb2439812
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/dev/performance/run_performance_cli.ts
View file

@ -11,7 +11,6 @@ import { run } from '@kbn/dev-cli-runner';
import { REPO_ROOT } from '@kbn/repo-info';
import fs from 'fs';
import path from 'path';
import { JOURNEY_APM_CONFIG } from '@kbn/journeys';
const JOURNEY_BASE_PATH = 'x-pack/performance/journeys';
@ -108,20 +107,21 @@ run(
'scripts/es',
'snapshot',
'--license=trial',
...(JOURNEY_APM_CONFIG.active
? [
'-E',
'tracing.apm.enabled=true',
'-E',
'tracing.apm.agent.transaction_sample_rate=1.0',
'-E',
`tracing.apm.agent.server_url=${JOURNEY_APM_CONFIG.serverUrl}`,
'-E',
`tracing.apm.agent.secret_token=${JOURNEY_APM_CONFIG.secretToken}`,
'-E',
`tracing.apm.agent.environment=${JOURNEY_APM_CONFIG.environment}`,
]
: []),
// Temporarily disabling APM
// ...(JOURNEY_APM_CONFIG.active
// ? [
// '-E',
// 'tracing.apm.enabled=true',
// '-E',
// 'tracing.apm.agent.transaction_sample_rate=1.0',
// '-E',
// `tracing.apm.agent.server_url=${JOURNEY_APM_CONFIG.serverUrl}`,
// '-E',
// `tracing.apm.agent.secret_token=${JOURNEY_APM_CONFIG.secretToken}`,
// '-E',
// `tracing.apm.agent.environment=${JOURNEY_APM_CONFIG.environment}`,
// ]
// : []),
],
cwd: REPO_ROOT,
wait: /kbn\/es setup complete/,

1
src/dev/tsconfig.json
View file

@ -39,7 +39,6 @@
"@kbn/get-repo-files",
"@kbn/import-locator",
"@kbn/config-schema",
"@kbn/journeys",
"@kbn/core-test-helpers-so-type-serializer",
"@kbn/core-test-helpers-kbn-server",
]