Fixed ci type check errors for alerting and actions properties for SIEM RouteHandlerContext (#59400) (#59442)

* Fixed ci type check errors for alerting and actions optional properties on RouteHandlerContext

* Reverted git revert b83f81458c

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.test.ts

@@ -63,7 +63,7 @@ describe('add_prepackaged_rules_route', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const request = addPrepackagedRulesRequest();
       const response = await server.inject(request, context);
 

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.ts

@@ -33,6 +33,9 @@ export const addPrepackedRulesRoute = (router: IRouter) => {
       const siemResponse = buildSiemResponse(response);
 
       try {
+        if (!context.alerting || !context.actions) {
+          return siemResponse.error({ statusCode: 404 });
+        }
         const alertsClient = context.alerting.getAlertsClient();
         const actionsClient = context.actions.getActionsClient();
         const clusterClient = context.core.elasticsearch.dataClient;

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.test.ts

@@ -39,7 +39,7 @@ describe('create_rules_bulk', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getReadBulkRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.ts

@@ -35,11 +35,14 @@ export const createRulesBulkRoute = (router: IRouter) => {
       },
     },
     async (context, request, response) => {
+      const siemResponse = buildSiemResponse(response);
+      if (!context.alerting || !context.actions) {
+        return siemResponse.error({ statusCode: 404 });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const actionsClient = context.actions.getActionsClient();
       const clusterClient = context.core.elasticsearch.dataClient;
       const siemClient = context.siem.getSiemClient();
-      const siemResponse = buildSiemResponse(response);
 
       if (!actionsClient || !alertsClient) {
         return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.test.ts

@@ -41,7 +41,7 @@ describe('create_rules', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getCreateRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.ts

@@ -59,6 +59,9 @@ export const createRulesRoute = (router: IRouter): void => {
       const siemResponse = buildSiemResponse(response);
 
       try {
+        if (!context.alerting || !context.actions) {
+          return siemResponse.error({ statusCode: 404 });
+        }
         const alertsClient = context.alerting.getAlertsClient();
         const actionsClient = context.actions.getActionsClient();
         const clusterClient = context.core.elasticsearch.dataClient;

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/delete_rules_bulk_route.test.ts

@@ -82,7 +82,7 @@ describe('delete_rules', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getDeleteBulkRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/delete_rules_bulk_route.ts

@@ -32,10 +32,14 @@ export const deleteRulesBulkRoute = (router: IRouter) => {
     },
   };
   const handler: Handler = async (context, request, response) => {
+    const siemResponse = buildSiemResponse(response);
+
+    if (!context.alerting || !context.actions) {
+      return siemResponse.error({ statusCode: 404 });
+    }
     const alertsClient = context.alerting.getAlertsClient();
     const actionsClient = context.actions.getActionsClient();
     const savedObjectsClient = context.core.savedObjects.client;
-    const siemResponse = buildSiemResponse(response);
 
     if (!actionsClient || !alertsClient) {
       return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/delete_rules_route.test.ts

@@ -56,7 +56,7 @@ describe('delete_rules', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getDeleteRequest(), context);
 
       expect(response.status).toEqual(404);

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/delete_rules_route.ts

@@ -33,6 +33,9 @@ export const deleteRulesRoute = (router: IRouter) => {
 
       try {
         const { id, rule_id: ruleId } = request.query;
+        if (!context.alerting || !context.actions) {
+          return siemResponse.error({ statusCode: 404 });
+        }
 
         const alertsClient = context.alerting.getAlertsClient();
         const actionsClient = context.actions.getActionsClient();

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/export_rules_route.ts

@@ -27,8 +27,11 @@ export const exportRulesRoute = (router: IRouter, config: LegacyServices['config
       },
     },
     async (context, request, response) => {
-      const alertsClient = context.alerting.getAlertsClient();
       const siemResponse = buildSiemResponse(response);
+      if (!context.alerting) {
+        return siemResponse.error({ statusCode: 404 });
+      }
+      const alertsClient = context.alerting.getAlertsClient();
 
       if (!alertsClient) {
         return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_route.test.ts

@@ -36,7 +36,7 @@ describe('find_rules', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getFindRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_route.ts

@@ -32,6 +32,9 @@ export const findRulesRoute = (router: IRouter) => {
 
       try {
         const { query } = request;
+        if (!context.alerting) {
+          return siemResponse.error({ statusCode: 404 });
+        }
         const alertsClient = context.alerting.getAlertsClient();
         const savedObjectsClient = context.core.savedObjects.client;
 

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_status_route.test.ts

@@ -29,7 +29,7 @@ describe('find_statuses', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(ruleStatusRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_status_route.ts

@@ -34,9 +34,12 @@ export const findRulesStatusesRoute = (router: IRouter) => {
     },
     async (context, request, response) => {
       const { query } = request;
+      const siemResponse = buildSiemResponse(response);
+      if (!context.alerting) {
+        return siemResponse.error({ statusCode: 404 });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const savedObjectsClient = context.core.savedObjects.client;
-      const siemResponse = buildSiemResponse(response);
 
       if (!alertsClient) {
         return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/get_prepackaged_rules_status_route.test.ts

@@ -58,7 +58,7 @@ describe('get_prepackaged_rule_status_route', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getPrepackagedRulesStatusRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/get_prepackaged_rules_status_route.ts

@@ -28,8 +28,11 @@ export const getPrepackagedRulesStatusRoute = (router: IRouter) => {
       },
     },
     async (context, request, response) => {
-      const alertsClient = context.alerting.getAlertsClient();
       const siemResponse = buildSiemResponse(response);
+      if (!context.alerting) {
+        return siemResponse.error({ statusCode: 404 });
+      }
+      const alertsClient = context.alerting.getAlertsClient();
 
       if (!alertsClient) {
         return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.test.ts

@@ -78,14 +78,14 @@ describe('import_rules_route', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(request, context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });
     });
 
     test('returns 404 if actionsClient is not available on the route', async () => {
-      context.actions.getActionsClient = jest.fn();
+      context.actions!.getActionsClient = jest.fn();
       const response = await server.inject(request, context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts

@@ -54,12 +54,16 @@ export const importRulesRoute = (router: IRouter, config: LegacyServices['config
       },
     },
     async (context, request, response) => {
+      const siemResponse = buildSiemResponse(response);
+
+      if (!context.alerting || !context.actions) {
+        return siemResponse.error({ statusCode: 404 });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const actionsClient = context.actions.getActionsClient();
       const clusterClient = context.core.elasticsearch.dataClient;
       const savedObjectsClient = context.core.savedObjects.client;
       const siemClient = context.siem.getSiemClient();
-      const siemResponse = buildSiemResponse(response);
 
       if (!actionsClient || !alertsClient) {
         return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/patch_rules_bulk_route.test.ts

@@ -48,7 +48,7 @@ describe('patch_rules_bulk', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getPatchBulkRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/patch_rules_bulk_route.ts

@@ -30,10 +30,14 @@ export const patchRulesBulkRoute = (router: IRouter) => {
       },
     },
     async (context, request, response) => {
+      const siemResponse = buildSiemResponse(response);
+
+      if (!context.alerting || !context.actions) {
+        return siemResponse.error({ statusCode: 404 });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const actionsClient = context.actions.getActionsClient();
       const savedObjectsClient = context.core.savedObjects.client;
-      const siemResponse = buildSiemResponse(response);
 
       if (!actionsClient || !alertsClient) {
         return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/patch_rules_route.test.ts

@@ -49,7 +49,7 @@ describe('patch_rules', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getPatchRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/patch_rules_route.ts

@@ -60,6 +60,10 @@ export const patchRulesRoute = (router: IRouter) => {
       const siemResponse = buildSiemResponse(response);
 
       try {
+        if (!context.alerting || !context.actions) {
+          return siemResponse.error({ statusCode: 404 });
+        }
+
         const alertsClient = context.alerting.getAlertsClient();
         const actionsClient = context.actions.getActionsClient();
         const savedObjectsClient = context.core.savedObjects.client;

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/read_rules_route.test.ts

@@ -36,7 +36,7 @@ describe('read_signals', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getReadRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/read_rules_route.ts

@@ -30,9 +30,13 @@ export const readRulesRoute = (router: IRouter) => {
     },
     async (context, request, response) => {
       const { id, rule_id: ruleId } = request.query;
+      const siemResponse = buildSiemResponse(response);
+
+      if (!context.alerting) {
+        return siemResponse.error({ statusCode: 404 });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const savedObjectsClient = context.core.savedObjects.client;
-      const siemResponse = buildSiemResponse(response);
 
       try {
         if (!alertsClient) {

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.test.ts

@@ -53,7 +53,7 @@ describe('update_rules_bulk', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getUpdateBulkRequest(), context);
       expect(response.status).toEqual(404);
       expect(response.body).toEqual({ message: 'Not Found', status_code: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.ts

@@ -30,11 +30,15 @@ export const updateRulesBulkRoute = (router: IRouter) => {
       },
     },
     async (context, request, response) => {
+      const siemResponse = buildSiemResponse(response);
+
+      if (!context.alerting || !context.actions) {
+        return siemResponse.error({ statusCode: 404 });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const actionsClient = context.actions.getActionsClient();
       const savedObjectsClient = context.core.savedObjects.client;
       const siemClient = context.siem.getSiemClient();
-      const siemResponse = buildSiemResponse(response);
 
       if (!actionsClient || !alertsClient) {
         return siemResponse.error({ statusCode: 404 });

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.test.ts

@@ -50,7 +50,7 @@ describe('update_rules', () => {
     });
 
     test('returns 404 if alertClient is not available on the route', async () => {
-      context.alerting.getAlertsClient = jest.fn();
+      context.alerting!.getAlertsClient = jest.fn();
       const response = await server.inject(getUpdateRequest(), context);
 
       expect(response.status).toEqual(404);

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.ts

@@ -60,6 +60,9 @@ export const updateRulesRoute = (router: IRouter) => {
       const siemResponse = buildSiemResponse(response);
 
       try {
+        if (!context.alerting || !context.actions) {
+          return siemResponse.error({ statusCode: 404 });
+        }
         const alertsClient = context.alerting.getAlertsClient();
         const actionsClient = context.actions.getActionsClient();
         const savedObjectsClient = context.core.savedObjects.client;

x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/tags/read_tags_route.ts

@@ -19,9 +19,13 @@ export const readTagsRoute = (router: IRouter) => {
       },
     },
     async (context, request, response) => {
-      const alertsClient = context.alerting.getAlertsClient();
       const siemResponse = buildSiemResponse(response);
 
+      if (!context.alerting) {
+        return siemResponse.error({ statusCode: 404 });
+      }
+      const alertsClient = context.alerting.getAlertsClient();
+
       if (!alertsClient) {
         return siemResponse.error({ statusCode: 404 });
       }

x-pack/plugins/actions/server/routes/create.ts

@@ -41,6 +41,9 @@ export const createActionRoute = (router: IRouter, licenseState: LicenseState) =
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
 
+      if (!context.actions) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for actions' });
+      }
       const actionsClient = context.actions.getActionsClient();
       const action = req.body;
       const actionRes: ActionResult = await actionsClient.create({ action });

x-pack/plugins/actions/server/routes/delete.ts

@@ -41,6 +41,9 @@ export const deleteActionRoute = (router: IRouter, licenseState: LicenseState) =
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.actions) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for actions' });
+      }
       const actionsClient = context.actions.getActionsClient();
       const { id } = req.params;
       await actionsClient.delete({ id });

x-pack/plugins/actions/server/routes/find.ts

@@ -57,6 +57,9 @@ export const findActionRoute = (router: IRouter, licenseState: LicenseState) =>
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.actions) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for actions' });
+      }
       const actionsClient = context.actions.getActionsClient();
       const query = req.query;
       const options: FindOptions['options'] = {

x-pack/plugins/actions/server/routes/get.ts

@@ -36,6 +36,9 @@ export const getActionRoute = (router: IRouter, licenseState: LicenseState) => {
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.actions) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for actions' });
+      }
       const actionsClient = context.actions.getActionsClient();
       const { id } = req.params;
       return res.ok({

x-pack/plugins/actions/server/routes/list_action_types.test.ts

@@ -58,7 +58,7 @@ describe('listActionTypesRoute', () => {
       }
     `);
 
-    expect(context.actions.listTypes).toHaveBeenCalledTimes(1);
+    expect(context.actions!.listTypes).toHaveBeenCalledTimes(1);
 
     expect(res.ok).toHaveBeenCalledWith({
       body: listTypes,

x-pack/plugins/actions/server/routes/list_action_types.ts

@@ -29,6 +29,9 @@ export const listActionTypesRoute = (router: IRouter, licenseState: LicenseState
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.actions) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for actions' });
+      }
       return res.ok({
         body: context.actions.listTypes(),
       });

x-pack/plugins/actions/server/routes/update.ts

@@ -43,6 +43,9 @@ export const updateActionRoute = (router: IRouter, licenseState: LicenseState) =
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.actions) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for actions' });
+      }
       const actionsClient = context.actions.getActionsClient();
       const { id } = req.params;
       const { name, config, secrets } = req.body;

x-pack/plugins/actions/server/types.ts

@@ -22,7 +22,7 @@ export interface Services {
 
 declare module 'src/core/server' {
   interface RequestHandlerContext {
-    actions: {
+    actions?: {
       getActionsClient: () => ActionsClient;
       listTypes: ActionTypeRegistry['list'];
     };

x-pack/plugins/alerting/server/routes/create.ts

@@ -57,6 +57,9 @@ export const createAlertRoute = (router: IRouter, licenseState: LicenseState) =>
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
 
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const alert = req.body;
       const alertRes: Alert = await alertsClient.create({ data: alert });

x-pack/plugins/alerting/server/routes/delete.ts

@@ -36,6 +36,9 @@ export const deleteAlertRoute = (router: IRouter, licenseState: LicenseState) =>
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       await alertsClient.delete({ id });

x-pack/plugins/alerting/server/routes/disable.ts

@@ -36,6 +36,9 @@ export const disableAlertRoute = (router: IRouter, licenseState: LicenseState) =
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       await alertsClient.disable({ id });

x-pack/plugins/alerting/server/routes/enable.ts

@@ -36,6 +36,9 @@ export const enableAlertRoute = (router: IRouter, licenseState: LicenseState) =>
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       await alertsClient.enable({ id });

x-pack/plugins/alerting/server/routes/find.ts

@@ -57,6 +57,9 @@ export const findAlertRoute = (router: IRouter, licenseState: LicenseState) => {
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const query = req.query;
       const options: FindOptions['options'] = {

x-pack/plugins/alerting/server/routes/get.ts

@@ -36,6 +36,9 @@ export const getAlertRoute = (router: IRouter, licenseState: LicenseState) => {
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       return res.ok({

x-pack/plugins/alerting/server/routes/get_alert_state.ts

@@ -36,6 +36,9 @@ export const getAlertStateRoute = (router: IRouter, licenseState: LicenseState)
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       const state = await alertsClient.getAlertState({ id });

x-pack/plugins/alerting/server/routes/list_alert_types.test.ts

@@ -70,7 +70,7 @@ describe('listAlertTypesRoute', () => {
       }
     `);
 
-    expect(context.alerting.listTypes).toHaveBeenCalledTimes(1);
+    expect(context.alerting!.listTypes).toHaveBeenCalledTimes(1);
 
     expect(res.ok).toHaveBeenCalledWith({
       body: listTypes,

x-pack/plugins/alerting/server/routes/list_alert_types.ts

@@ -29,6 +29,9 @@ export const listAlertTypesRoute = (router: IRouter, licenseState: LicenseState)
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       return res.ok({
         body: context.alerting.listTypes(),
       });

x-pack/plugins/alerting/server/routes/mute_all.ts

@@ -36,6 +36,9 @@ export const muteAllAlertRoute = (router: IRouter, licenseState: LicenseState) =
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       await alertsClient.muteAll({ id });

x-pack/plugins/alerting/server/routes/mute_instance.ts

@@ -37,6 +37,9 @@ export const muteAlertInstanceRoute = (router: IRouter, licenseState: LicenseSta
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { alertId, alertInstanceId } = req.params;
       await alertsClient.muteInstance({ alertId, alertInstanceId });

x-pack/plugins/alerting/server/routes/unmute_all.ts

@@ -36,6 +36,9 @@ export const unmuteAllAlertRoute = (router: IRouter, licenseState: LicenseState)
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       await alertsClient.unmuteAll({ id });

x-pack/plugins/alerting/server/routes/unmute_instance.ts

@@ -37,6 +37,9 @@ export const unmuteAlertInstanceRoute = (router: IRouter, licenseState: LicenseS
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { alertId, alertInstanceId } = req.params;
       await alertsClient.unmuteInstance({ alertId, alertInstanceId });

x-pack/plugins/alerting/server/routes/update.ts

@@ -57,6 +57,9 @@ export const updateAlertRoute = (router: IRouter, licenseState: LicenseState) =>
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       const { name, actions, params, schedule, tags } = req.body;

x-pack/plugins/alerting/server/routes/update_api_key.ts

@@ -36,6 +36,9 @@ export const updateApiKeyRoute = (router: IRouter, licenseState: LicenseState) =
       res: KibanaResponseFactory
     ): Promise<IKibanaResponse<any>> {
       verifyApiAccess(licenseState);
+      if (!context.alerting) {
+        return res.badRequest({ body: 'RouteHandlerContext is not registered for alerting' });
+      }
       const alertsClient = context.alerting.getAlertsClient();
       const { id } = req.params;
       await alertsClient.updateApiKey({ id });

x-pack/plugins/alerting/server/types.ts

@@ -21,7 +21,7 @@ export type SpaceIdToNamespaceFunction = (spaceId?: string) => string | undefine
 
 declare module 'src/core/server' {
   interface RequestHandlerContext {
-    alerting: {
+    alerting?: {
       getAlertsClient: () => AlertsClient;
       listTypes: AlertTypeRegistry['list'];
     };