github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ML] Using kibana's auto-refresh for jobs list (#20496) (#20512)

Browse source 
* [ML] Using kibana's auto-refresh for jobs list

* better auto refresh management

* fixing typo

* increasing default interval

* variable rename

* kill interval on page change

* updating comment

* adding minimum refresh interval

* correctly clearing the interval
This commit is contained in:
James Gowdy 2018-07-06 15:13:03 +01:00 • committed by GitHub
parent abbfb03ec4
commit ef32b06296
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 63 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

79
x-pack/plugins/ml/public/jobs/jobs_list_new/components/jobs_list_view/jobs_list_view.js
View file

@ -6,6 +6,7 @@
import './styles/main.less';
import { timefilter } from 'ui/timefilter';
import { ml } from 'plugins/ml/services/ml_api_service';
import { loadFullJob, filterJobs } from '../utils';
@ -21,6 +22,9 @@ import React, {
Component
} from 'react';
const DEFAULT_REFRESH_INTERVAL_MS = 30000;
const MINIMUM_REFRESH_INTERVAL_MS = 5000;
export class JobsListView extends Component {
constructor(props) {
super(props);
@ -40,13 +44,62 @@ export class JobsListView extends Component {
this.showDeleteJobModal = () => {};
this.showStartDatafeedModal = () => {};
this.blockAutoRefresh = false;
this.blockRefresh = false;
this.refreshInterval = null;
}
this.refreshJobSummaryList();
componentDidMount() {
timefilter.enableAutoRefreshSelector();
this.initAutoRefresh();
this.initAutoRefreshUpdate();
}
componentWillUnmount() {
this.blockAutoRefresh = true;
this.clearRefreshInterval();
}
initAutoRefresh() {
const { value, pause } = timefilter.getRefreshInterval();
if (pause === false && value === 0) {
// if the auto refresher isn't set, set it to the default
timefilter.setRefreshInterval({
pause: false,
value: DEFAULT_REFRESH_INTERVAL_MS
});
}
this.setAutoRefresh();
}
initAutoRefreshUpdate() {
// update the interval if it changes
timefilter.on('refreshIntervalUpdate', () => {
this.setAutoRefresh();
});
}
setAutoRefresh() {
const { value, pause } = timefilter.getRefreshInterval();
if (pause) {
this.clearRefreshInterval();
} else {
this.setRefreshInterval(value);
}
this.refreshJobSummaryList(true);
}
setRefreshInterval(interval) {
this.clearRefreshInterval();
if (interval >= MINIMUM_REFRESH_INTERVAL_MS) {
this.blockRefresh = false;
this.refreshInterval = setInterval(() => (this.refreshJobSummaryList()), interval);
}
}
clearRefreshInterval() {
this.blockRefresh = true;
clearInterval(this.refreshInterval);
}
toggleRow = (jobId) => {
@ -157,8 +210,8 @@ export class JobsListView extends Component {
});
}
refreshJobSummaryList(autoRefresh = true) {
if (this.blockAutoRefresh === false) {
refreshJobSummaryList(forceRefresh = false) {
if (forceRefresh === true || this.blockRefresh === false) {
const expandedJobsIds = Object.keys(this.state.itemIdToExpandedRowMap);
ml.jobs.jobsSummary(expandedJobsIds)
.then((jobs) => {
@ -179,12 +232,6 @@ export class JobsListView extends Component {
Object.keys(this.updateFunctions).forEach((j) => {
this.updateFunctions[j].setState({ job: fullJobsList[j] });
});
if (autoRefresh === true) {
setTimeout(() => {
this.refreshJobSummaryList();
}, 10000);
}
})
.catch((error) => {
console.error(error);
@ -200,7 +247,7 @@ export class JobsListView extends Component {
selectedJobs={this.state.selectedJobs}
showStartDatafeedModal={this.showStartDatafeedModal}
showDeleteJobModal={this.showDeleteJobModal}
refreshJobs={() => this.refreshJobSummaryList(false)}
refreshJobs={() => this.refreshJobSummaryList(true)}
/>
<JobFilterBar setFilters={this.setFilters} />
</div>
@ -213,22 +260,22 @@ export class JobsListView extends Component {
showEditJobFlyout={this.showEditJobFlyout}
showDeleteJobModal={this.showDeleteJobModal}
showStartDatafeedModal={this.showStartDatafeedModal}
refreshJobs={() => this.refreshJobSummaryList(false)}
refreshJobs={() => this.refreshJobSummaryList(true)}
/>
<EditJobFlyout
setShowFunction={this.setShowEditJobFlyoutFunction}
unsetShowFunction={this.unsetShowEditJobFlyoutFunction}
refreshJobs={() => this.refreshJobSummaryList(false)}
refreshJobs={() => this.refreshJobSummaryList(true)}
/>
<DeleteJobModal
setShowFunction={this.setShowDeleteJobModalFunction}
unsetShowFunction={this.unsetShowDeleteJobModalFunction}
refreshJobs={() => this.refreshJobSummaryList(false)}
refreshJobs={() => this.refreshJobSummaryList(true)}
/>
<StartDatafeedModal
setShowFunction={this.setShowStartDatafeedModalFunction}
unsetShowFunction={this.unsetShowDeleteJobModalFunction}
refreshJobs={() => this.refreshJobSummaryList(false)}
refreshJobs={() => this.refreshJobSummaryList(true)}
/>
</div>
);