github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution] Fix icon color regression (#170123)

Browse source 
## Summary

The changes in https://github.com/elastic/kibana/pull/169625 introduced
a regression on ESS when displaying the `Entity Analytics` icon,
removing the `fill` property caused the icon to be displayed using the
wrong color.

### Before
In ESS it loses the green + black color and it is shown in blue (it is
inside a link)


![before_ess](23f8657e-5cf1-4ff2-9635-ea13dbbf2edd)

In serverless it was displaying the correct black color:


![before_serverless](3f3b207d-9e41-4e62-aaf1-c12f76d46269)


### After:
In ESS it is displayed with default green + black color


![after_ess](91b8930f-5ca6-47d3-8499-b38a9e053f89)

In serverless it keeps showing in black color as expected:


![after_serverless](3f3b207d-9e41-4e62-aaf1-c12f76d46269)
This commit is contained in:
Sergi Massaneda 2023-10-30 16:10:47 +01:00 • committed by GitHub
parent d1c587ff1d
commit efc2248d32
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/kbn-management/cards_navigation/src/cards_navigation.tsx
View file

@ -184,7 +184,7 @@ export const CardsNavigation = ({
<EuiCard
data-test-subj={`app-card-${app.id}`}
layout="horizontal"
icon={<EuiIcon type={app.icon} size="l" color="darkShade" />}
icon={<EuiIcon type={app.icon} size="l" color="text" />}
titleSize="xs"
title={app.title}
description={app.description}

3
x-pack/plugins/security_solution/public/common/icons/entity_analytics.tsx
View file

@ -20,12 +20,13 @@ export const IconEntityAnalytics: React.FC<SVGProps<SVGSVGElement>> = ({ ...prop
fillRule="evenodd"
clipRule="evenodd"
d="M25.332 7C25.332 8.10457 26.2275 9 27.332 9C28.4366 9 29.332 8.10457 29.332 7C29.332 5.89543 28.4366 5 27.332 5C26.2275 5 25.332 5.89543 25.332 7ZM23.332 7C23.332 7.37644 23.384 7.74073 23.4812 8.08609L17.6976 11.1707C15.9888 8.65367 13.1035 7 9.83203 7C4.58533 7 0.332031 11.2533 0.332031 16.5C0.332031 21.7467 4.58533 26 9.83203 26C12.6903 26 15.2537 24.7377 16.9952 22.7403L23.387 26.3356C23.3508 26.5517 23.332 26.7737 23.332 27C23.332 29.2091 25.1229 31 27.332 31C29.5412 31 31.332 29.2091 31.332 27C31.332 24.7909 29.5412 23 27.332 23C26.0677 23 24.9404 23.5866 24.2074 24.5024L18.1491 21.0946C18.672 20.15 19.0387 19.1068 19.2143 18H24.4581C24.9021 19.7252 26.4682 21 28.332 21C30.5412 21 32.332 19.2091 32.332 17C32.332 14.7909 30.5412 13 28.332 13C26.4682 13 24.9021 14.2748 24.458 16H19.3191C19.2631 14.9207 19.027 13.8891 18.6403 12.9346L24.49 9.81475C25.2149 10.5466 26.2205 11 27.332 11C29.5412 11 31.332 9.20914 31.332 7C31.332 4.79086 29.5412 3 27.332 3C25.1229 3 23.332 4.79086 23.332 7ZM28.332 19C27.2275 19 26.332 18.1046 26.332 17C26.332 15.8954 27.2275 15 28.332 15C29.4366 15 30.332 15.8954 30.332 17C30.332 18.1046 29.4366 19 28.332 19ZM25.332 27C25.332 28.1046 26.2275 29 27.332 29C28.4366 29 29.332 28.1046 29.332 27C29.332 25.8954 28.4366 25 27.332 25C26.2275 25 25.332 25.8954 25.332 27ZM9.83203 24C5.68989 24 2.33203 20.6421 2.33203 16.5C2.33203 12.3579 5.6899 9 9.83203 9C13.9742 9 17.332 12.3579 17.332 16.5C17.332 20.6421 13.9742 24 9.83203 24Z"
className="euiIcon__fillSecondary"
fill="#343741"
/>
<path
fillRule="evenodd"
clipRule="evenodd"
d="M7.73203 19.1078C7.73203 18.0391 8.67423 17.1693 9.83203 17.1693C10.9898 17.1693 11.932 18.0391 11.932 19.1078H7.73203ZM8.43203 14.5843C8.43203 13.8716 9.05993 13.292 9.83203 13.292C10.6041 13.292 11.232 13.8716 11.232 14.5843C11.232 15.297 10.6041 15.8766 9.83203 15.8766C9.05993 15.8766 8.43203 15.297 8.43203 14.5843V14.5843ZM11.7878 16.4294C12.3072 15.9603 12.632 15.3077 12.632 14.5846C12.632 13.1592 11.3762 12 9.83203 12C8.28783 12 7.03203 13.1592 7.03203 14.5846C7.03203 15.3077 7.35683 15.9603 7.87623 16.4294C6.94523 17.0109 6.33203 17.9944 6.33203 19.1077V20.4H13.332V19.1077C13.332 17.9944 12.7188 17.0109 11.7878 16.4294V16.4294Z"
fill="#00BFB3"
/>
</g>
<defs>