mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
[Management] Add share as a required dependency (#144381)
## Summary This PR adds `share` as a required plugin of `management` plugin. I created a new plugin and was trying to add "management" as a dependency. This was throwing an error when starting Kibana: ``` TypeError: Cannot read properties of undefined (reading 'url') at ManagementPlugin.setup (plugin.ts:42:1) ``` caused by: https://github.com/elastic/kibana/blob/main/src/plugins/management/public/plugin.ts#L78 It looks like `share` was declared as an optional plugin but it didn't handle a scenario when it was not provided. ### Checklist Delete any items that are not applicable to this PR. ~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~ ~- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ ~- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ ~- [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~ ~- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ ~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ ~- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~ ~- [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
parent
cf281d61ca
commit
f02cf40fdc
1 changed files with 2 additions and 1 deletions
|
@ -3,7 +3,8 @@
|
|||
"version": "kibana",
|
||||
"server": true,
|
||||
"ui": true,
|
||||
"optionalPlugins": ["home", "share"],
|
||||
"optionalPlugins": ["home"],
|
||||
"requiredPlugins": ["share"],
|
||||
"requiredBundles": ["kibanaReact", "kibanaUtils"],
|
||||
"owner": {
|
||||
"name": "Vis Editors",
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue