[ML] Fix Transform runtime mappings retain original definition when cloning (#95436)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Quynh Nguyen 2021-03-26 10:25:39 -05:00 committed by GitHub
parent b1525f0af7
commit f061303282
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions

View file

@ -45,6 +45,7 @@ export const destSchema = schema.object({
export const pivotSchema = schema.object({
group_by: schema.any(),
aggregations: schema.any(),
max_page_search_size: schema.maybe(schema.number()),
});
export const latestFunctionSchema = schema.object({

View file

@ -84,11 +84,6 @@ export function getCombinedRuntimeMappings(
): StepDefineExposedState['runtimeMappings'] | undefined {
let combinedRuntimeMappings = {};
// Use runtime field mappings defined inline from API
if (isPopulatedObject(runtimeMappings)) {
combinedRuntimeMappings = { ...combinedRuntimeMappings, ...runtimeMappings };
}
// And runtime field mappings defined by index pattern
if (isIndexPattern(indexPattern)) {
const computedFields = indexPattern.getComputedFields();
@ -100,6 +95,12 @@ export function getCombinedRuntimeMappings(
}
}
// Use runtime field mappings defined inline from API
// and override fields with same name from index pattern
if (isPopulatedObject(runtimeMappings)) {
combinedRuntimeMappings = { ...combinedRuntimeMappings, ...runtimeMappings };
}
if (isPopulatedObject<StepDefineExposedState['runtimeMappings']>(combinedRuntimeMappings)) {
return combinedRuntimeMappings;
}