github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Attempts to make saving of the current query more robust (#44797) (#44836)

Browse source
This commit is contained in:
Matt Bargar 2019-09-05 13:55:28 -04:00 • committed by GitHub
parent 3ff0b88539
commit f0d9ef06b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/legacy/core_plugins/data/public/search/search_bar/components/saved_query_management/save_query_form.tsx
View file

@ -130,7 +130,7 @@ export const SaveQueryForm: FunctionComponent<Props> = ({
}
const saveQueryForm = (
<EuiForm isInvalid={hasErrors} error={formErrors}>
<EuiForm isInvalid={hasErrors} error={formErrors} data-test-subj="saveQueryForm">
<EuiFormRow>
<EuiText color="subdued">{savedQueryDescriptionText}</EuiText>
</EuiFormRow>

15
test/functional/services/saved_query_management_component.js
View file

@ -27,14 +27,12 @@ export function SavedQueryManagementComponentProvider({ getService }) {
class SavedQueryManagementComponent {
async saveNewQuery(name, description, includeFilters, includeTimeFilter) {
await this.openSavedQueryManagementComponent();
await testSubjects.click('saved-query-management-save-button');
await this.openSaveCurrentQueryModal();
await this.submitSaveQueryForm(name, description, includeFilters, includeTimeFilter);
}
async saveNewQueryWithNameError(name) {
await this.openSavedQueryManagementComponent();
await testSubjects.click('saved-query-management-save-button');
await this.openSaveCurrentQueryModal();
if (name) {
await testSubjects.setValue('saveQueryFormTitle', name);
}
@ -137,6 +135,15 @@ export function SavedQueryManagementComponentProvider({ getService }) {
await testSubjects.click('saved-query-management-popover-button');
}
async openSaveCurrentQueryModal() {
await this.openSavedQueryManagementComponent();
await retry.try(async () => {
await testSubjects.click('saved-query-management-save-button');
await testSubjects.existOrFail('saveQueryForm');
});
}
async saveNewQueryMissingOrFail() {
await this.openSavedQueryManagementComponent();
await testSubjects.missingOrFail('saved-query-management-save-button');