github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Remove Open and New menu buttons from Visualize.

Browse source
This commit is contained in:
CJ Cenizal 2017-02-01 17:07:55 -08:00
parent 93c9533beb
commit f243762d8f
2 changed files with 6 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/core_plugins/kibana/public/visualize/editor/editor.js
View file

@ -104,20 +104,10 @@ function VisEditor($scope, $route, timefilter, AppState, $window, kbnUrl, courie
const searchSource = savedVis.searchSource;
$scope.topNavMenu = [{
key: 'new',
description: 'New Visualization',
run: function () { kbnUrl.change('/visualize/step/1', {}); },
testId: 'visualizeNewButton',
}, {
key: 'save',
description: 'Save Visualization',
template: require('plugins/kibana/visualize/editor/panels/save.html'),
testId: 'visualizeSaveButton',
}, {
key: 'open',
description: 'Open Saved Visualization',
run: function () { kbnUrl.change('/visualize', {}); },
testId: 'visualizeOpenButton',
}, {
key: 'share',
description: 'Share Visualization',
@ -225,7 +215,7 @@ function VisEditor($scope, $route, timefilter, AppState, $window, kbnUrl, courie
$state.replace();
$scope.getVisualizationTitle = function getVisualizationTitle() {
return savedVis.lastSavedTitle || 'New Visualization';
return savedVis.lastSavedTitle || `${savedVis.title} (unsaved)`;
};
$scope.$watch('searchSource.get("index").timeFieldName', function (timeField) {

11
test/support/page_objects/visualize_page.js
View file

@ -296,11 +296,6 @@ export default class VisualizePage {
});
}
clickNewVisualization() {
return PageObjects.common.findTestSubject('visualizeNewButton')
.click();
}
saveVisualization(vizName) {
return PageObjects.common.findTestSubject('visualizeSaveButton')
.click()
@ -337,7 +332,11 @@ export default class VisualizePage {
}
clickLoadSavedVisButton() {
return PageObjects.common.findTestSubject('visualizeOpenButton')
// TODO: Use a test subject selector once we rewrite breadcrumbs to accept each breadcrumb
// element as a child instead of building the breadcrumbs dynamically.
return self.remote
.setFindTimeout(defaultFindTimeout)
.findByCssSelector('[href="#/visualize"]')
.click();
}