github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Visualize] unskip visualize flaky tests (#190249)

Browse source 
## Summary

Fixes https://github.com/elastic/kibana/issues/181884
Fixes https://github.com/elastic/kibana/issues/181883
Fixes https://github.com/elastic/kibana/issues/181895
Fixes https://github.com/elastic/kibana/issues/181881
This commit is contained in:
Marta Bondyra 2024-08-15 21:19:49 +02:00 • committed by GitHub
parent 17b2be16f5
commit f27a477719
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 29 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

41
src/plugins/vis_types/vislib/public/vis_wrapper.tsx
View file

@ -48,37 +48,32 @@ const VislibWrapper = ({ core, charts, visData, visConfig, handlers }: VislibWra
const visController = useRef<VislibVisController | null>(null);
const skipRenderComplete = useRef<boolean>(true);
const renderComplete = useMemo(
() => () => {
const usageCollection = getUsageCollectionStart();
const containerType = extractContainerType(handlers.getExecutionContext());
const renderComplete = useCallback(() => {
if (skipRenderComplete.current) {
return;
}
const usageCollection = getUsageCollectionStart();
const containerType = extractContainerType(handlers.getExecutionContext());
if (usageCollection && containerType) {
usageCollection.reportUiCounter(
containerType,
METRIC_TYPE.COUNT,
`render_agg_based_${visConfig!.type}`
);
}
handlers.done();
},
[handlers, visConfig]
);
if (usageCollection && containerType) {
usageCollection.reportUiCounter(
containerType,
METRIC_TYPE.COUNT,
`render_agg_based_${visConfig!.type}`
);
}
handlers.done();
skipRenderComplete.current = true;
}, [handlers, visConfig]);
const renderChart = useMemo(
() =>
debounce(() => {
if (visController.current) {
visController.current.render(
visData,
visConfig,
handlers,
skipRenderComplete.current ? undefined : renderComplete
);
visController.current.render(visData, visConfig, handlers, renderComplete);
}
skipRenderComplete.current = true;
}, 100),
[handlers, renderComplete, skipRenderComplete, visConfig, visData]
[handlers, renderComplete, visConfig, visData]
);
const onResize: EuiResizeObserverProps['onResize'] = useCallback(() => {

9
test/functional/apps/visualize/group2/_gauge_chart.ts
View file

@ -18,8 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['visualize', 'visEditor', 'visChart', 'timePicker']);
// FLAKY: https://github.com/elastic/kibana/issues/181883
describe.skip('gauge chart', function indexPatternCreation() {
describe('gauge chart', function indexPatternCreation() {
before(async () => {
await PageObjects.visualize.initTests();
});
@ -57,7 +56,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.click('gaugePercentageMode');
await testSubjects.setValue('gaugePercentageModeFormatPattern', '0.0%');
await PageObjects.visChart.waitForVisualizationRenderingStabilized();
await PageObjects.visEditor.clickGo();
await PageObjects.visEditor.clickGo(false);
await retry.try(async function tryingForTime() {
const expectedTexts = ['57.3%', 'Average bytes'];
@ -77,7 +76,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.selectField('machine.os.raw');
log.debug('Size = 4');
await PageObjects.visEditor.setSize(4);
await PageObjects.visEditor.clickGo();
await PageObjects.visEditor.clickGo(false);
});
it('should show Split Gauges', async () => {
@ -113,7 +112,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visEditor.clickBucket('Metric', 'metrics');
await PageObjects.visEditor.selectAggregation('Min', 'metrics');
await PageObjects.visEditor.selectField('bytes', 'metrics');
await PageObjects.visEditor.clickGo();
await PageObjects.visEditor.clickGo(false);
await retry.try(async function tryingForTime() {
const metricValue = await PageObjects.visChart.getGaugeValue();

9
test/functional/apps/visualize/group2/_heatmap_chart.ts
View file

@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const inspector = getService('inspector');
const PageObjects = getPageObjects(['visualize', 'visEditor', 'visChart', 'timePicker']);
// FLAKY: https://github.com/elastic/kibana/issues/181884
describe.skip('heatmap chart', function indexPatternCreation() {
describe('heatmap chart', function indexPatternCreation() {
const vizName1 = 'Visualization HeatmapChart';
let isNewChartsLibraryEnabled = false;
@ -38,7 +37,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
log.debug('Field = @timestamp');
await PageObjects.visEditor.selectField('@timestamp');
// leaving Interval set to Auto
await PageObjects.visEditor.clickGo();
await PageObjects.visEditor.clickGo(isNewChartsLibraryEnabled);
});
it('should save and load', async function () {
@ -97,7 +96,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('should show 6 color ranges if changed on options', async function () {
await PageObjects.visEditor.clickOptionsTab();
await PageObjects.visEditor.changeHeatmapColorNumbers(6);
await PageObjects.visEditor.clickGo();
await PageObjects.visEditor.clickGo(isNewChartsLibraryEnabled);
await PageObjects.visChart.waitForVisualizationRenderingStabilized();
const legends = await PageObjects.visChart.getLegendEntries();
@ -138,7 +137,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
log.debug('customize 2 last ranges');
await PageObjects.visEditor.setCustomRangeByIndex(6, '650', '720');
await PageObjects.visEditor.setCustomRangeByIndex(7, '800', '905');
await PageObjects.visEditor.clickGo();
await PageObjects.visEditor.clickGo(isNewChartsLibraryEnabled);
await PageObjects.visChart.waitForVisualizationRenderingStabilized();
const legends = await PageObjects.visChart.getLegendEntries();

2
test/functional/page_objects/visualize_editor_page.ts
View file

@ -68,6 +68,8 @@ export class VisualizeEditorPageObject extends FtrService {
await this.elasticChart.setNewChartUiDebugFlag();
}
await this.common.sleep(500); // wait for the visualization to render
const prevRenderingCount = await this.visChart.getVisualizationRenderingCount();
this.log.debug(`Before Rendering count ${prevRenderingCount}`);
await this.testSubjects.clickWhenNotDisabledWithoutRetry('visualizeEditorRenderButton');

3
x-pack/test/functional/apps/lens/open_in_lens/agg_based/gauge.ts
View file

@ -21,8 +21,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const elasticChart = getService('elasticChart');
// Failing: See https://github.com/elastic/kibana/issues/181895
describe.skip('Gauge', function describeIndexTests() {
describe('Gauge', function describeIndexTests() {
const isNewChartsLibraryEnabled = true;
before(async () => {