github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Inspect action shows on dashboard for every chart (#65998)

Browse source 
Closes: #60372
This commit is contained in:
Alexey Antonov 2020-05-12 11:24:03 +03:00 • committed by GitHub
parent 2ad2bfa906
commit f3548d6c83
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
View file

@ -71,6 +71,8 @@ export interface VisualizeOutput extends EmbeddableOutput {
type ExpressionLoader = InstanceType<ExpressionsStart['ExpressionLoader']>;
const visTypesWithoutInspector = ['markdown', 'input_control_vis', 'metrics', 'vega', 'timelion'];
export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOutput> {
private handler?: ExpressionLoader;
private timefilter: TimefilterContract;
@ -126,7 +128,7 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
}
public getInspectorAdapters = () => {
if (!this.handler) {
if (!this.handler || visTypesWithoutInspector.includes(this.vis.type.name)) {
return undefined;
}
return this.handler.inspect();
@ -215,19 +217,7 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
// this is a hack to make editor still work, will be removed once we clean up editor
// @ts-ignore
hasInspector = () => {
const visTypesWithoutInspector = [
'markdown',
'input_control_vis',
'metrics',
'vega',
'timelion',
];
if (visTypesWithoutInspector.includes(this.vis.type.name)) {
return false;
}
return this.getInspectorAdapters();
};
hasInspector = () => Boolean(this.getInspectorAdapters());
/**
*