github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Serverless] Improve fleet and integrations serverless breadcrumbs (#169772)

Browse source 
## Summary

This fixes deeper context breadcrumbs in serverless navigation for fleet
and integration apps.
This builds on top of https://github.com/elastic/kibana/pull/169513
where we added merging of navigational project breadcrumbs with deeper
context breadcrumbs set by `chrome.setBreadcrumbs`. The merging is based
on `deepLinkId`, so we're adding it to base breadcrumbs. The
`deepLinkId` is type checked.


Example Before/After: 

Before:

![Screenshot 2023-10-25 at 12 05
33](4a6a0bab-1cef-4b24-8349-246b9612563e)

![Screenshot 2023-10-25 at 12 05
37](63435c3c-1397-4b41-8d46-3d0e9bd32515)


After:
![Screenshot 2023-10-25 at 12 06
10](a7519fdd-b21a-40e7-a774-d867bb4e79ec)

![Screenshot 2023-10-25 at 12 06
14](1e99e005-1317-4c62-af1e-c445c9038fc4)
This commit is contained in:
Anton Dosov 2023-10-25 14:43:20 +02:00 • committed by GitHub
parent 1fdcb41f29
commit f378b87cad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/fleet/public/applications/fleet/hooks/use_breadcrumbs.tsx
View file

@ -24,6 +24,7 @@ const BASE_BREADCRUMB: Breadcrumb = {
text: i18n.translate('xpack.fleet.breadcrumbs.appTitle', {
defaultMessage: 'Fleet',
}),
deepLinkId: 'fleet',
};
const INTEGRATIONS_BASE_BREADCRUMB: Breadcrumb = {
@ -32,6 +33,7 @@ const INTEGRATIONS_BASE_BREADCRUMB: Breadcrumb = {
defaultMessage: 'Integrations',
}),
useIntegrationsBasePath: true,
deepLinkId: 'integrations',
};
const breadcrumbGetters: {

1
x-pack/plugins/fleet/public/applications/integrations/hooks/use_breadcrumbs.tsx
View file

@ -19,6 +19,7 @@ const BASE_BREADCRUMB: ChromeBreadcrumb = {
text: i18n.translate('xpack.fleet.breadcrumbs.integrationsAppTitle', {
defaultMessage: 'Integrations',
}),
deepLinkId: 'integrations',
};
const breadcrumbGetters: {

15
x-pack/test_serverless/functional/test_suites/observability/navigation.ts
View file

@ -128,5 +128,20 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
});
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Cases', 'Settings']);
});
it('navigates to integrations', async () => {
await svlCommonNavigation.sidenav.openSection('project_settings_project_nav');
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'integrations' });
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts([
'Integrations',
'Browse integrations',
]);
});
it('navigates to fleet', async () => {
await svlCommonNavigation.sidenav.openSection('project_settings_project_nav');
await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'fleet' });
await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Fleet', 'Agents']);
});
});
}