github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[UA] Add aria-labelledby missing on flyouts (#218401)

Browse source 
Fixes https://github.com/elastic/kibana/issues/218028

## Summary
This PR introduces the `aria-labelledby` missing in Migrate system
indices flyout. It also introduces it in the ES deprecation logs (this
wasn't requested in the Issue but was also missed). The changes are
correctly displayed with Voiceover in Safari.

<img width="1508" alt="Screenshot 2025-04-16 at 11 13 29"
src="https://github.com/user-attachments/assets/400e9416-6f74-4cda-94f6-52a69c37799d"
/>
<img width="1109" alt="Screenshot 2025-04-16 at 11 39 57"
src="https://github.com/user-attachments/assets/e834967d-b4ab-4d2d-9b3d-c218203bb98a"
/>

<img width="1511" alt="Screenshot 2025-04-16 at 15 39 07"
src="https://github.com/user-attachments/assets/cabd9feb-5b6c-4005-9d41-25e2a9ab80f3"
/>

<img width="1508" alt="Screenshot 2025-04-16 at 15 38 29"
src="https://github.com/user-attachments/assets/cc61db5b-d642-48c9-931f-b696b3367774"
/>
This commit is contained in:
Sonia Sanz Vivas 2025-04-16 18:03:00 +02:00 • committed by GitHub
parent c99566ad0b
commit f46afe0307
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/es_deprecation_logs/fix_deprecation_logs/es_deprecation_logs_flyout.tsx
View file

@ -193,7 +193,7 @@ export const EsDeprecationLogsFlyout = ({
<>
<EuiFlyoutHeader hasBorder>
<EuiTitle size="s" data-test-subj="flyoutTitle">
<h2>
<h2 id="esDeprecationLogsFlyoutTitle">
<FormattedMessage
id="xpack.upgradeAssistant.esDeprecationLogs.pageTitle"
defaultMessage="Elasticsearch deprecation logs"

2
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/overview/logs_step/logs_step.tsx
View file

@ -183,6 +183,8 @@ const LogsStep = ({ setIsComplete, hasPrivileges, privilegesMissing }: LogStepPr
},
flyoutProps: {
onClose: closeFlyout,
'data-test-subj': 'esDeprecationLogsFlyout',
'aria-labelledby': 'esDeprecationLogsFlyoutTitle',
},
});
}

2
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/overview/migrate_system_indices/flyout.tsx
View file

@ -250,7 +250,7 @@ export const SystemIndicesFlyout = ({
<>
<EuiFlyoutHeader hasBorder>
<EuiTitle size="s" data-test-subj="flyoutTitle">
<h2>{i18nTexts.flyoutTitle}</h2>
<h2 id="migrateSystemIndicesFlyoutTitle">{i18nTexts.flyoutTitle}</h2>
</EuiTitle>
</EuiFlyoutHeader>
<EuiFlyoutBody data-test-subj="flyoutDetails">

2
x-pack/platform/plugins/private/upgrade_assistant/public/application/components/overview/migrate_system_indices/use_migrate_system_indices.ts
View file

@ -77,6 +77,8 @@ export const useMigrateSystemIndices = () => {
},
flyoutProps: {
onClose: closeFlyout,
'data-test-subj': 'migrateSystemIndicesFlyout',
'aria-labelledby': 'migrateSystemIndicesFlyoutTitle',
},
});
}