mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
[Vega] Fixes problem with controls not being displayed on a map (#97373)
* add element for vegaControls * Fix check types * Fixed type check Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
parent
249f9aca15
commit
f5a8405eb9
4 changed files with 6 additions and 2 deletions
|
@ -34,6 +34,7 @@ export class VegaBaseView {
|
|||
destroy(): Promise<void>;
|
||||
|
||||
_$container: any;
|
||||
_$controls: any;
|
||||
_parser: any;
|
||||
_vegaViewConfig: any;
|
||||
_serviceSettings: VegaViewParams['serviceSettings'];
|
||||
|
|
|
@ -36,6 +36,7 @@ describe('vega_map_view/tms_raster_layer', () => {
|
|||
vegaView: ({
|
||||
initialize: jest.fn(),
|
||||
} as unknown) as View,
|
||||
vegaControls: 'element',
|
||||
updateVegaView: jest.fn(),
|
||||
};
|
||||
});
|
||||
|
|
|
@ -13,12 +13,13 @@ import type { LayerParameters } from './types';
|
|||
export interface VegaLayerContext {
|
||||
vegaView: View;
|
||||
updateVegaView: (map: Map, view: View) => void;
|
||||
vegaControls: any;
|
||||
}
|
||||
|
||||
export function initVegaLayer({
|
||||
id,
|
||||
map: mapInstance,
|
||||
context: { vegaView, updateVegaView },
|
||||
context: { vegaView, vegaControls, updateVegaView },
|
||||
}: LayerParameters<VegaLayerContext>) {
|
||||
const vegaLayer: CustomLayerInterface = {
|
||||
id,
|
||||
|
@ -34,7 +35,7 @@ export function initVegaLayer({
|
|||
vegaContainer.style.height = mapCanvas.style.height;
|
||||
|
||||
mapContainer.appendChild(vegaContainer);
|
||||
vegaView.initialize(vegaContainer);
|
||||
vegaView.initialize(vegaContainer, vegaControls);
|
||||
},
|
||||
render() {
|
||||
updateVegaView(mapInstance, vegaView);
|
||||
|
|
|
@ -175,6 +175,7 @@ export class VegaMapView extends VegaBaseView {
|
|||
map: mapBoxInstance,
|
||||
context: {
|
||||
vegaView,
|
||||
vegaControls: this._$controls.get(0),
|
||||
updateVegaView,
|
||||
},
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue