Add wait for page load to methods (#20390)

* Add wait for page load to methods

* fix trailing space
This commit is contained in:
liza-mae 2018-07-03 10:38:16 -06:00 committed by GitHub
parent 2d4bb6a19f
commit f6237dc112
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -40,22 +40,27 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
async clickAreaChart() {
await find.clickByPartialLinkText('Area');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickDataTable() {
await find.clickByPartialLinkText('Data Table');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickLineChart() {
await find.clickByPartialLinkText('Line');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickRegionMap() {
await find.clickByPartialLinkText('Region Map');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickMarkdownWidget() {
await find.clickByPartialLinkText('Markdown');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickAddMetric() {
@ -68,30 +73,37 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
async clickMetric() {
await find.clickByPartialLinkText('Metric');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickGauge() {
await find.clickByPartialLinkText('Gauge');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickPieChart() {
await find.clickByPartialLinkText('Pie');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickTileMap() {
await find.clickByPartialLinkText('Coordinate Map');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickTagCloud() {
await find.clickByPartialLinkText('Tag Cloud');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickVega() {
await find.clickByPartialLinkText('Vega');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickVisualBuilder() {
await find.clickByPartialLinkText('Visual Builder');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickEditorSidebarCollapse() {
@ -118,14 +130,17 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
async clickVerticalBarChart() {
await find.clickByPartialLinkText('Vertical Bar');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickHeatmapChart() {
await find.clickByPartialLinkText('Heat Map');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickInputControlVis() {
await find.clickByPartialLinkText('Controls');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async getChartTypeCount() {
@ -311,10 +326,6 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
await options[optionIndex].click();
}
async clickGoButton() {
await testSubjects.click('timepickerGoButton');
}
async isInspectorButtonEnabled() {
const button = await testSubjects.find('openInspectorButton');
const ariaDisabled = await button.getAttribute('aria-disabled');
@ -575,6 +586,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
async clickOptions() {
await find.clickByPartialLinkText('Options');
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickMetricsAndAxes() {
@ -634,6 +646,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
// or extended character sets
// https://github.com/elastic/kibana/issues/6300
await input.type(vizName.replace('-', ' '));
await PageObjects.header.waitUntilLoadingHasFinished();
}
async clickVisualizationByName(vizName) {
@ -656,6 +669,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
async openSavedVisualization(vizName) {
await this.clickVisualizationByName(vizName);
await PageObjects.header.waitUntilLoadingHasFinished();
}
async getXAxisLabels() {