Migrate browser-side rendering service to packages (#139996)

* move scss to styles folder

* create empty packages

* move code to packages

* adapt usages

* fix scss import path

* update packages and readmes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

package.json

@@ -250,6 +250,8 @@
     "@kbn/core-preboot-server": "link:bazel-bin/packages/core/preboot/core-preboot-server",
     "@kbn/core-preboot-server-internal": "link:bazel-bin/packages/core/preboot/core-preboot-server-internal",
     "@kbn/core-preboot-server-mocks": "link:bazel-bin/packages/core/preboot/core-preboot-server-mocks",
+    "@kbn/core-rendering-browser-internal": "link:bazel-bin/packages/core/rendering/core-rendering-browser-internal",
+    "@kbn/core-rendering-browser-mocks": "link:bazel-bin/packages/core/rendering/core-rendering-browser-mocks",
     "@kbn/core-saved-objects-api-browser": "link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-browser",
     "@kbn/core-saved-objects-api-server": "link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-server",
     "@kbn/core-saved-objects-api-server-internal": "link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-server-internal",
@@ -934,6 +936,8 @@
     "@types/kbn__core-preboot-server-internal": "link:bazel-bin/packages/core/preboot/core-preboot-server-internal/npm_module_types",
     "@types/kbn__core-preboot-server-mocks": "link:bazel-bin/packages/core/preboot/core-preboot-server-mocks/npm_module_types",
     "@types/kbn__core-public-internal-base": "link:bazel-bin/packages/core/public/internal-base/npm_module_types",
+    "@types/kbn__core-rendering-browser-internal": "link:bazel-bin/packages/core/rendering/core-rendering-browser-internal/npm_module_types",
+    "@types/kbn__core-rendering-browser-mocks": "link:bazel-bin/packages/core/rendering/core-rendering-browser-mocks/npm_module_types",
     "@types/kbn__core-saved-objects-api-browser": "link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-browser/npm_module_types",
     "@types/kbn__core-saved-objects-api-server": "link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-server/npm_module_types",
     "@types/kbn__core-saved-objects-api-server-internal": "link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-server-internal/npm_module_types",

packages/BUILD.bazel

@@ -115,6 +115,8 @@ filegroup(
     "//packages/core/preboot/core-preboot-server:build",
     "//packages/core/preboot/core-preboot-server-internal:build",
     "//packages/core/preboot/core-preboot-server-mocks:build",
+    "//packages/core/rendering/core-rendering-browser-internal:build",
+    "//packages/core/rendering/core-rendering-browser-mocks:build",
     "//packages/core/saved-objects/core-saved-objects-api-browser:build",
     "//packages/core/saved-objects/core-saved-objects-api-server:build",
     "//packages/core/saved-objects/core-saved-objects-api-server-internal:build",
@@ -418,6 +420,8 @@ filegroup(
     "//packages/core/preboot/core-preboot-server:build_types",
     "//packages/core/preboot/core-preboot-server-internal:build_types",
     "//packages/core/preboot/core-preboot-server-mocks:build_types",
+    "//packages/core/rendering/core-rendering-browser-internal:build_types",
+    "//packages/core/rendering/core-rendering-browser-mocks:build_types",
     "//packages/core/saved-objects/core-saved-objects-api-browser:build_types",
     "//packages/core/saved-objects/core-saved-objects-api-server:build_types",
     "//packages/core/saved-objects/core-saved-objects-api-server-internal:build_types",

packages/core/rendering/core-rendering-browser-internal/BUILD.bazel

@@ -0,0 +1,138 @@
+load("@npm//@bazel/typescript:index.bzl", "ts_config")
+load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
+load("//src/dev/bazel:index.bzl", "jsts_transpiler", "pkg_npm", "pkg_npm_types", "ts_project")
+
+PKG_DIRNAME = "core-rendering-browser-internal"
+PKG_REQUIRE_NAME = "@kbn/core-rendering-browser-internal"
+
+SOURCE_FILES = glob(
+  [
+    "**/*.ts",
+    "**/*.tsx",
+  ],
+  exclude = [
+    "**/*.config.js",
+    "**/*.mock.*",
+    "**/*.test.*",
+    "**/*.stories.*",
+    "**/__snapshots__/**",
+    "**/integration_tests/**",
+    "**/mocks/**",
+    "**/scripts/**",
+    "**/storybook/**",
+    "**/test_fixtures/**",
+    "**/test_helpers/**",
+  ],
+)
+
+SRCS = SOURCE_FILES
+
+filegroup(
+  name = "srcs",
+  srcs = SRCS,
+)
+
+NPM_MODULE_EXTRA_FILES = [
+  "package.json",
+]
+
+RUNTIME_DEPS = [
+  "@npm//react",
+  "@npm//react-dom",
+  "@npm//rxjs",
+  "@npm//classnames",
+  "@npm//react-use",
+  "//packages/core/application/core-application-common",
+  "//packages/core/theme/core-theme-browser-internal",
+  ### test dependencies
+  "//packages/core/application/core-application-browser-mocks",
+  "//packages/core/chrome/core-chrome-browser-mocks",
+  "//packages/core/overlays/core-overlays-browser-mocks",
+  "//packages/core/theme/core-theme-browser-mocks",
+  "//packages/core/i18n/core-i18n-browser-mocks",
+]
+
+TYPES_DEPS = [
+  "@npm//@types/node",
+  "@npm//@types/jest",
+  "@npm//@types/react",
+  "@npm//@types/classnames",
+  "@npm//@types/react-dom",
+  "@npm//rxjs",
+  "@npm//react-use",
+  "//packages/core/application/core-application-common:npm_module_types",
+  "//packages/core/application/core-application-browser-internal:npm_module_types",
+  "//packages/core/theme/core-theme-browser:npm_module_types",
+  "//packages/core/theme/core-theme-browser-internal:npm_module_types",
+  "//packages/core/i18n/core-i18n-browser:npm_module_types",
+  "//packages/core/overlays/core-overlays-browser:npm_module_types",
+  "//packages/core/chrome/core-chrome-browser-internal:npm_module_types",
+]
+
+jsts_transpiler(
+  name = "target_node",
+  srcs = SRCS,
+  build_pkg_name = package_name(),
+)
+
+jsts_transpiler(
+  name = "target_web",
+  srcs = SRCS,
+  build_pkg_name = package_name(),
+  web = True,
+)
+
+ts_config(
+  name = "tsconfig",
+  src = "tsconfig.json",
+  deps = [
+    "//:tsconfig.base.json",
+    "//:tsconfig.bazel.json",
+  ],
+)
+
+ts_project(
+  name = "tsc_types",
+  args = ['--pretty'],
+  srcs = SRCS,
+  deps = TYPES_DEPS,
+  declaration = True,
+  declaration_map = True,
+  emit_declaration_only = True,
+  out_dir = "target_types",
+  tsconfig = ":tsconfig",
+)
+
+js_library(
+  name = PKG_DIRNAME,
+  srcs = NPM_MODULE_EXTRA_FILES,
+  deps = RUNTIME_DEPS + [":target_node", ":target_web"],
+  package_name = PKG_REQUIRE_NAME,
+  visibility = ["//visibility:public"],
+)
+
+pkg_npm(
+  name = "npm_module",
+  deps = [":" + PKG_DIRNAME],
+)
+
+filegroup(
+  name = "build",
+  srcs = [":npm_module"],
+  visibility = ["//visibility:public"],
+)
+
+pkg_npm_types(
+  name = "npm_module_types",
+  srcs = SRCS,
+  deps = [":tsc_types"],
+  package_name = PKG_REQUIRE_NAME,
+  tsconfig = ":tsconfig",
+  visibility = ["//visibility:public"],
+)
+
+filegroup(
+  name = "build_types",
+  srcs = [":npm_module_types"],
+  visibility = ["//visibility:public"],
+)

packages/core/rendering/core-rendering-browser-internal/README.md

@@ -0,0 +1,4 @@
+# @kbn/core-rendering-browser-internal
+
+This package contains the internal types and implementation for Core's browser-side rendering service.
+

packages/core/rendering/core-rendering-browser-internal/index.ts

@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export { RenderingService } from './src';

packages/core/rendering/core-rendering-browser-internal/jest.config.js

@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+module.exports = {
+  preset: '@kbn/test',
+  rootDir: '../../../..',
+  roots: ['<rootDir>/packages/core/rendering/core-rendering-browser-internal'],
+};

packages/core/rendering/core-rendering-browser-internal/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@kbn/core-rendering-browser-internal",
+  "private": true,
+  "version": "1.0.0",
+  "main": "./target_node/index.js",
+  "browser": "./target_web/index.js",
+  "author": "Kibana Core",
+  "license": "SSPL-1.0 OR Elastic License 2.0"
+}

packages/core/rendering/core-rendering-browser-internal/src/rendering_service.test.tsx

@@ -10,12 +10,12 @@ import React from 'react';
 import { act } from 'react-dom/test-utils';
 import { BehaviorSubject } from 'rxjs';
 
-import { RenderingService } from './rendering_service';
 import { applicationServiceMock } from '@kbn/core-application-browser-mocks';
 import { chromeServiceMock } from '@kbn/core-chrome-browser-mocks';
 import { overlayServiceMock } from '@kbn/core-overlays-browser-mocks';
 import { themeServiceMock } from '@kbn/core-theme-browser-mocks';
 import { i18nServiceMock } from '@kbn/core-i18n-browser-mocks';
+import { RenderingService } from './rendering_service';
 
 describe('RenderingService#start', () => {
   let application: ReturnType<typeof applicationServiceMock.createInternalStartContract>;

packages/core/rendering/core-rendering-browser-internal/tsconfig.json

@@ -0,0 +1,19 @@
+{
+  "extends": "../../../../tsconfig.bazel.json",
+  "compilerOptions": {
+    "declaration": true,
+    "declarationMap": true,
+    "emitDeclarationOnly": true,
+    "outDir": "target_types",
+    "stripInternal": false,
+    "types": [
+      "jest",
+      "node",
+      "react"
+    ]
+  },
+  "include": [
+    "**/*.ts",
+      "**/*.tsx",
+  ]
+}

packages/core/rendering/core-rendering-browser-mocks/BUILD.bazel

@@ -0,0 +1,114 @@
+load("@npm//@bazel/typescript:index.bzl", "ts_config")
+load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
+load("//src/dev/bazel:index.bzl", "jsts_transpiler", "pkg_npm", "pkg_npm_types", "ts_project")
+
+PKG_DIRNAME = "core-rendering-browser-mocks"
+PKG_REQUIRE_NAME = "@kbn/core-rendering-browser-mocks"
+
+SOURCE_FILES = glob(
+  [
+    "**/*.ts",
+    "**/*.tsx",
+  ],
+  exclude = [
+    "**/*.config.js",
+    "**/*.test.*",
+    "**/*.stories.*",
+    "**/__snapshots__/**",
+    "**/integration_tests/**",
+    "**/mocks/**",
+    "**/scripts/**",
+    "**/storybook/**",
+    "**/test_fixtures/**",
+    "**/test_helpers/**",
+  ],
+)
+
+SRCS = SOURCE_FILES
+
+filegroup(
+  name = "srcs",
+  srcs = SRCS,
+)
+
+NPM_MODULE_EXTRA_FILES = [
+  "package.json",
+]
+
+RUNTIME_DEPS = [
+]
+
+TYPES_DEPS = [
+  "@npm//@types/node",
+  "@npm//@types/jest",
+  "//packages/kbn-utility-types:npm_module_types",
+  "//packages/core/rendering/core-rendering-browser-internal:npm_module_types",
+]
+
+jsts_transpiler(
+  name = "target_node",
+  srcs = SRCS,
+  build_pkg_name = package_name(),
+)
+
+jsts_transpiler(
+  name = "target_web",
+  srcs = SRCS,
+  build_pkg_name = package_name(),
+  web = True,
+)
+
+ts_config(
+  name = "tsconfig",
+  src = "tsconfig.json",
+  deps = [
+    "//:tsconfig.base.json",
+    "//:tsconfig.bazel.json",
+  ],
+)
+
+ts_project(
+  name = "tsc_types",
+  args = ['--pretty'],
+  srcs = SRCS,
+  deps = TYPES_DEPS,
+  declaration = True,
+  declaration_map = True,
+  emit_declaration_only = True,
+  out_dir = "target_types",
+  tsconfig = ":tsconfig",
+)
+
+js_library(
+  name = PKG_DIRNAME,
+  srcs = NPM_MODULE_EXTRA_FILES,
+  deps = RUNTIME_DEPS + [":target_node", ":target_web"],
+  package_name = PKG_REQUIRE_NAME,
+  visibility = ["//visibility:public"],
+)
+
+pkg_npm(
+  name = "npm_module",
+  deps = [":" + PKG_DIRNAME],
+)
+
+filegroup(
+  name = "build",
+  srcs = [":npm_module"],
+  visibility = ["//visibility:public"],
+)
+
+pkg_npm_types(
+  name = "npm_module_types",
+  srcs = SRCS,
+  deps = [":tsc_types"],
+  package_name = PKG_REQUIRE_NAME,
+  tsconfig = ":tsconfig",
+  visibility = ["//visibility:public"],
+)
+
+filegroup(
+  name = "build_types",
+  srcs = [":npm_module_types"],
+  visibility = ["//visibility:public"],
+)

packages/core/rendering/core-rendering-browser-mocks/README.md

@@ -0,0 +1,4 @@
+# @kbn/core-rendering-browser-mocks
+
+This package contains mocks for Core's browser-side rendering service.
+- `renderingServiceMock`

packages/core/rendering/core-rendering-browser-mocks/index.ts

@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export { renderingServiceMock } from './src';

packages/core/rendering/core-rendering-browser-mocks/jest.config.js

@@ -0,0 +1,13 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+module.exports = {
+  preset: '@kbn/test',
+  rootDir: '../../../..',
+  roots: ['<rootDir>/packages/core/rendering/core-rendering-browser-mocks'],
+};

packages/core/rendering/core-rendering-browser-mocks/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@kbn/core-rendering-browser-mocks",
+  "private": true,
+  "version": "1.0.0",
+  "main": "./target_node/index.js",
+  "browser": "./target_web/index.js",
+  "author": "Kibana Core",
+  "license": "SSPL-1.0 OR Elastic License 2.0"
+}

packages/core/rendering/core-rendering-browser-mocks/src/index.ts

@@ -0,0 +1,9 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+export { renderingServiceMock } from './rendering_service.mock';

packages/core/rendering/core-rendering-browser-mocks/src/rendering_service.mock.ts

@@ -7,9 +7,10 @@
  */
 
 import type { PublicMethodsOf } from '@kbn/utility-types';
-import { RenderingService } from './rendering_service';
+import type { RenderingService } from '@kbn/core-rendering-browser-internal';
 
 type RenderingServiceContract = PublicMethodsOf<RenderingService>;
+
 const createMock = () => {
   const mocked: jest.Mocked<RenderingServiceContract> = {
     start: jest.fn(),

packages/core/rendering/core-rendering-browser-mocks/tsconfig.json

@@ -0,0 +1,18 @@
+{
+  "extends": "../../../../tsconfig.bazel.json",
+  "compilerOptions": {
+    "declaration": true,
+    "declarationMap": true,
+    "emitDeclarationOnly": true,
+    "outDir": "target_types",
+    "stripInternal": false,
+    "types": [
+      "jest",
+      "node"
+    ]
+  },
+  "include": [
+    "**/*.ts",
+    "**/*.tsx",
+  ]
+}

src/core/public/core_system.test.mocks.ts

@@ -19,7 +19,7 @@ import { notificationServiceMock } from '@kbn/core-notifications-browser-mocks';
 import { overlayServiceMock } from '@kbn/core-overlays-browser-mocks';
 import { pluginsServiceMock } from './plugins/plugins_service.mock';
 import { uiSettingsServiceMock } from '@kbn/core-ui-settings-browser-mocks';
-import { renderingServiceMock } from './rendering/rendering_service.mock';
+import { renderingServiceMock } from '@kbn/core-rendering-browser-mocks';
 import { integrationsServiceMock } from '@kbn/core-integrations-browser-mocks';
 import { coreAppMock } from './core_app/core_app.mock';
 
@@ -114,7 +114,7 @@ jest.doMock('@kbn/core-doc-links-browser-internal', () => ({
 
 export const MockRenderingService = renderingServiceMock.create();
 export const RenderingServiceConstructor = jest.fn().mockImplementation(() => MockRenderingService);
-jest.doMock('./rendering', () => ({
+jest.doMock('@kbn/core-rendering-browser-internal', () => ({
   RenderingService: RenderingServiceConstructor,
 }));
 

src/core/public/core_system.ts

@@ -37,10 +37,10 @@ import {
   type InternalApplicationSetup,
   type InternalApplicationStart,
 } from '@kbn/core-application-browser-internal';
+import { RenderingService } from '@kbn/core-rendering-browser-internal';
 import { fetchOptionalMemoryInfo } from './fetch_optional_memory_info';
 import { CoreSetup, CoreStart } from '.';
 import { PluginsService } from './plugins';
-import { RenderingService } from './rendering';
 import { CoreApp } from './core_app';
 
 import {

src/core/public/index.scss

@@ -1,5 +1,4 @@
 @import './variables';
 @import './mixins';
 @import './core';
-@import './rendering/index';
 @import './styles/index';

src/core/public/styles/_index.scss

@@ -1,3 +1,4 @@
 @import './base';
 @import './ace_overrides';
 @import './chrome/index';
+@import './rendering/index';

src/core/public/styles/rendering/_base.scss

@@ -1,4 +1,4 @@
-@import '../mixins';
+@import '../../mixins';
 
 /**
  * Stretch the root element of the Kibana application to set the base-size that

yarn.lock

@@ -3139,6 +3139,14 @@
   version "0.0.0"
   uid ""
 
+"@kbn/core-rendering-browser-internal@link:bazel-bin/packages/core/rendering/core-rendering-browser-internal":
+  version "0.0.0"
+  uid ""
+
+"@kbn/core-rendering-browser-mocks@link:bazel-bin/packages/core/rendering/core-rendering-browser-mocks":
+  version "0.0.0"
+  uid ""
+
 "@kbn/core-saved-objects-api-browser@link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-browser":
   version "0.0.0"
   uid ""
@@ -7229,6 +7237,14 @@
   version "0.0.0"
   uid ""
 
+"@types/kbn__core-rendering-browser-internal@link:bazel-bin/packages/core/rendering/core-rendering-browser-internal/npm_module_types":
+  version "0.0.0"
+  uid ""
+
+"@types/kbn__core-rendering-browser-mocks@link:bazel-bin/packages/core/rendering/core-rendering-browser-mocks/npm_module_types":
+  version "0.0.0"
+  uid ""
+
 "@types/kbn__core-saved-objects-api-browser@link:bazel-bin/packages/core/saved-objects/core-saved-objects-api-browser/npm_module_types":
   version "0.0.0"
   uid ""