Migrate deprecated components in Logstash pipelines section. (#161512)

## Summary

Migrates the deprecated components in Logstash pipelines view based on
[the gude](https://elastic.github.io/eui/#/layout/page-components).
A list of deprecated components in Logstash pipelines can be found
[here](https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Flogstash%2F&type=code).

### Tests
Opened a dev tools and proceeded manual tests on local dev env (based on
[local env setup
guide](https://docs.elastic.dev/kibana-dev-docs/getting-started/setup-dev-env)):
- create pipeline(s)
- check list of pipeline(s)
- delete pipeline(s)
- check alerts when deleting the pipeline
- check Elasticsearch .logstash_pipelines index (`GET
_logstash/pipeline`) to check the data shape which Logstash polls and
uses.


- Closes: #161417 

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
~~- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~~
- [x ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
~~- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard
accessibility](https://webaim.org/techniques/keyboard/))~~
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
~~- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Mashhur 2023-09-27 12:44:32 -07:00 committed by GitHub
parent 594cb14a28
commit fb13b2181d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 18 deletions

View file

@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`PipelineEditor component includes required error message for falsy pipeline id 1`] = `
<EuiPageContentBody_Deprecated
<EuiPageSection
data-test-subj="pipelineEdit pipelineEdit-"
restrictWidth={true}
style={
@ -289,11 +289,11 @@ Default value: 1024"
</EuiButton>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageContentBody_Deprecated>
</EuiPageSection>
`;
exports[`PipelineEditor component invalidates form for invalid pipeline id input 1`] = `
<EuiPageContentBody_Deprecated
<EuiPageSection
data-test-subj="pipelineEdit pipelineEdit-$invalid-pipeline-name"
restrictWidth={true}
style={
@ -580,11 +580,11 @@ Default value: 1024"
</EuiButton>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageContentBody_Deprecated>
</EuiPageSection>
`;
exports[`PipelineEditor component invalidates form for pipeline id with spaces 1`] = `
<EuiPageContentBody_Deprecated
<EuiPageSection
data-test-subj="pipelineEdit pipelineEdit-pipeline id with spaces"
restrictWidth={true}
style={
@ -871,11 +871,11 @@ Default value: 1024"
</EuiButton>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageContentBody_Deprecated>
</EuiPageSection>
`;
exports[`PipelineEditor component matches snapshot for clone pipeline 1`] = `
<EuiPageContentBody_Deprecated
<EuiPageSection
data-test-subj="pipelineEdit pipelineEdit-pipelineId"
restrictWidth={true}
style={
@ -1148,11 +1148,11 @@ Default value: 1024"
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageContentBody_Deprecated>
</EuiPageSection>
`;
exports[`PipelineEditor component matches snapshot for create pipeline 1`] = `
<EuiPageContentBody_Deprecated
<EuiPageSection
data-test-subj="pipelineEdit pipelineEdit-pipelineId"
restrictWidth={true}
style={
@ -1435,11 +1435,11 @@ Default value: 1024"
</EuiButton>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageContentBody_Deprecated>
</EuiPageSection>
`;
exports[`PipelineEditor component matches snapshot for edit pipeline 1`] = `
<EuiPageContentBody_Deprecated
<EuiPageSection
data-test-subj="pipelineEdit pipelineEdit-pipelineId"
restrictWidth={true}
style={
@ -1712,5 +1712,5 @@ Default value: 1024"
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageContentBody_Deprecated>
</EuiPageSection>
`;

View file

@ -22,7 +22,7 @@ import {
EuiFieldText,
EuiForm,
EuiFormRow,
EuiPageContentBody_Deprecated as EuiPageContentBody,
EuiPageSection,
EuiSelect,
EuiSpacer,
EuiPageHeader,
@ -266,7 +266,7 @@ class PipelineEditorUi extends React.Component {
const { intl } = this.props;
return (
<EuiPageContentBody
<EuiPageSection
style={{ width: '100%' }}
restrictWidth
data-test-subj={`pipelineEdit pipelineEdit-${this.state.pipeline.id}`}
@ -480,7 +480,7 @@ class PipelineEditorUi extends React.Component {
confirmDeletePipeline={this.deletePipeline}
/>
)}
</EuiPageContentBody>
</EuiPageSection>
);
}
}

View file

@ -12,7 +12,7 @@ import {
EuiCallOut,
EuiEmptyPrompt,
EuiLoadingSpinner,
EuiPageContentBody_Deprecated as EuiPageContentBody,
EuiPageSection,
EuiPageHeader,
EuiSpacer,
} from '@elastic/eui';
@ -291,7 +291,7 @@ class PipelineListUi extends React.Component {
const { clonePipeline, createPipeline, isReadOnly, openPipeline } = this.props;
const { isSelectable, message, pipelines, selection, showConfirmDeleteModal } = this.state;
return (
<EuiPageContentBody data-test-subj="pipelineList">
<EuiPageSection data-test-subj="pipelineList">
<EuiPageHeader
pageTitle={
<FormattedMessage id="xpack.logstash.pipelineList.head" defaultMessage="Pipelines" />
@ -329,7 +329,7 @@ class PipelineListUi extends React.Component {
showAddRoleAlert={this.state.showAddRoleAlert}
showEnableMonitoringAlert={this.state.showEnableMonitoringAlert}
/>
</EuiPageContentBody>
</EuiPageSection>
);
}
}