github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[SharedUxChromeNavigation] Use deeplink id instead of href (#159125)

Browse source
This commit is contained in:
Sébastien Loix 2023-06-13 18:10:10 +01:00 • committed by GitHub
parent b1128ea67b
commit fb41ca56f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
125 changed files with 2598 additions and 1627 deletions
Download patch file Download diff file Expand all files Collapse all files

8
packages/core/application/core-application-browser/src/application.ts
View file

@ -286,9 +286,9 @@ export type PublicAppDeepLinkInfo = Omit<
* user-accessible.
* @public
*/
export type AppDeepLink = {
export type AppDeepLink<Id extends string = string> = {
/** Identifier to represent this sublink, should be unique for this application */
id: string;
id: Id;
/** Title to label represent this deep link */
title: string;
/** Optional keywords to match with in deep links search. Omit if this part of the hierarchy does not have a page URL. */
@ -303,13 +303,13 @@ export type AppDeepLink = {
/** URL path to access this link, relative to the application's appRoute. */
path: string;
/** Optional array of links that are 'underneath' this section in the hierarchy */
deepLinks?: AppDeepLink[];
deepLinks?: Array<AppDeepLink<Id>>;
}
| {
/** Optional path to access this section. Omit if this part of the hierarchy does not have a page URL. */
path?: string;
/** Array links that are 'underneath' this section in this hierarchy. */
deepLinks: AppDeepLink[];
deepLinks: Array<AppDeepLink<Id>>;
}
);