github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Check for toast before waiting for page to finish loading to avoid mi… (#24424)

Browse source 
* Check for toast before waiting for page to finish loading to avoid missing the toast by the time the page finishes

* turn test back on
This commit is contained in:
Stacey Gammon 2018-10-30 09:57:55 -04:00 • committed by GitHub
parent a86998a0fc
commit fb7dbaeb6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/functional/apps/dashboard/_embeddable_rendering.js
View file

@ -80,7 +80,7 @@ export default function ({ getService, getPageObjects }) {
await dashboardExpect.vegaTextsDoNotExist(['5,000']);
};
describe.skip('dashboard embeddable rendering', function describeIndexTests() {
describe('dashboard embeddable rendering', function describeIndexTests() {
before(async () => {
await PageObjects.dashboard.clickNewDashboard();

4
test/functional/page_objects/dashboard_page.js
View file

@ -317,11 +317,9 @@ export function DashboardPageProvider({ getService, getPageObjects }) {
await this.clickSave();
}
await PageObjects.header.waitUntilLoadingHasFinished();
// Confirm that the Dashboard has actually been saved
await testSubjects.existOrFail('saveDashboardSuccess');
await PageObjects.header.waitUntilLoadingHasFinished();
await this.waitForSaveModalToClose();
}