mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
# Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases] De-duplicate assignees object name (#194359)](https://github.com/elastic/kibana/pull/194359) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Toby Brain","email":"tobio85@gmail.com"},"sourceCommit":{"committedDate":"2024-09-30T09:15:38Z","message":"[ResponseOps][Cases] De-duplicate assignees object name (#194359)\n\n## Summary\r\n\r\nCommon client generators fail with the current Kibana spec due to\r\nduplicate type names used within the Case API.\r\n\r\n```\r\n❯ go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen -package=kibana -generate=types,client -o ../generated/kibana.gen.go ../kibana-openapi-source.yaml\r\nerror generating code: error generating type definitions: error generating code for type definitions: duplicate typename 'CasesAssignees' detected, can't auto-rename, please use x-go-name to specify your own name for one of them\r\nexit status 1\r\n```\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"874d17e263f6d2b6fbd77b82559f7519cada30e9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Cases] De-duplicate assignees object name","number":194359,"url":"https://github.com/elastic/kibana/pull/194359","mergeCommit":{"message":"[ResponseOps][Cases] De-duplicate assignees object name (#194359)\n\n## Summary\r\n\r\nCommon client generators fail with the current Kibana spec due to\r\nduplicate type names used within the Case API.\r\n\r\n```\r\n❯ go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen -package=kibana -generate=types,client -o ../generated/kibana.gen.go ../kibana-openapi-source.yaml\r\nerror generating code: error generating type definitions: error generating code for type definitions: duplicate typename 'CasesAssignees' detected, can't auto-rename, please use x-go-name to specify your own name for one of them\r\nexit status 1\r\n```\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"874d17e263f6d2b6fbd77b82559f7519cada30e9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194359","number":194359,"mergeCommit":{"message":"[ResponseOps][Cases] De-duplicate assignees object name (#194359)\n\n## Summary\r\n\r\nCommon client generators fail with the current Kibana spec due to\r\nduplicate type names used within the Case API.\r\n\r\n```\r\n❯ go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen -package=kibana -generate=types,client -o ../generated/kibana.gen.go ../kibana-openapi-source.yaml\r\nerror generating code: error generating type definitions: error generating code for type definitions: duplicate typename 'CasesAssignees' detected, can't auto-rename, please use x-go-name to specify your own name for one of them\r\nexit status 1\r\n```\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"874d17e263f6d2b6fbd77b82559f7519cada30e9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Toby Brain <tobio85@gmail.com>
This commit is contained in:
parent
7f1f3fc711
commit
fd821844d3
6 changed files with 9 additions and 9 deletions
|
@ -6937,7 +6937,7 @@ paths:
|
|||
feature privileges, depending on the owner of the cases you're seeking.
|
||||
operationId: findCasesDefaultSpace
|
||||
parameters:
|
||||
- $ref: '#/components/parameters/Cases_assignees'
|
||||
- $ref: '#/components/parameters/Cases_assignees_filter'
|
||||
- $ref: '#/components/parameters/Cases_category'
|
||||
- $ref: '#/components/parameters/Cases_defaultSearchOperator'
|
||||
- $ref: '#/components/parameters/Cases_from'
|
||||
|
@ -24271,7 +24271,7 @@ components:
|
|||
schema:
|
||||
example: 09f0c261e39e36351d75995b78bb83673774d1bc2cca9df2d15f0e5c0a99a540
|
||||
type: string
|
||||
Cases_assignees:
|
||||
Cases_assignees_filter:
|
||||
description: >
|
||||
Filters the returned cases by assignees. Valid values are `none` or
|
||||
unique identifiers for the user profiles. These identifiers can be found
|
||||
|
|
|
@ -6684,7 +6684,7 @@ paths:
|
|||
feature privileges, depending on the owner of the cases you're seeking.
|
||||
operationId: findCasesDefaultSpace
|
||||
parameters:
|
||||
- $ref: '#/components/parameters/Cases_assignees'
|
||||
- $ref: '#/components/parameters/Cases_assignees_filter'
|
||||
- $ref: '#/components/parameters/Cases_category'
|
||||
- $ref: '#/components/parameters/Cases_defaultSearchOperator'
|
||||
- $ref: '#/components/parameters/Cases_from'
|
||||
|
@ -16418,7 +16418,7 @@ components:
|
|||
schema:
|
||||
example: 09f0c261e39e36351d75995b78bb83673774d1bc2cca9df2d15f0e5c0a99a540
|
||||
type: string
|
||||
Cases_assignees:
|
||||
Cases_assignees_filter:
|
||||
description: >
|
||||
Filters the returned cases by assignees. Valid values are `none` or
|
||||
unique identifiers for the user profiles. These identifiers can be found
|
||||
|
|
|
@ -179,7 +179,7 @@
|
|||
],
|
||||
"parameters": [
|
||||
{
|
||||
"$ref": "#/components/parameters/assignees"
|
||||
"$ref": "#/components/parameters/assignees_filter"
|
||||
},
|
||||
{
|
||||
"$ref": "#/components/parameters/category"
|
||||
|
@ -1897,7 +1897,7 @@
|
|||
},
|
||||
"example": "d4e7abb0-b462-11ec-9a8d-698504725a43"
|
||||
},
|
||||
"assignees": {
|
||||
"assignees_filter": {
|
||||
"in": "query",
|
||||
"name": "assignees",
|
||||
"description": "Filters the returned cases by assignees. Valid values are `none` or unique identifiers for the user profiles. These identifiers can be found by using the suggest user profile API.\n",
|
||||
|
|
|
@ -112,7 +112,7 @@ paths:
|
|||
tags:
|
||||
- cases
|
||||
parameters:
|
||||
- $ref: '#/components/parameters/assignees'
|
||||
- $ref: '#/components/parameters/assignees_filter'
|
||||
- $ref: '#/components/parameters/category'
|
||||
- $ref: '#/components/parameters/defaultSearchOperator'
|
||||
- $ref: '#/components/parameters/from'
|
||||
|
@ -1230,7 +1230,7 @@ components:
|
|||
minItems: 1
|
||||
maxItems: 100
|
||||
example: d4e7abb0-b462-11ec-9a8d-698504725a43
|
||||
assignees:
|
||||
assignees_filter:
|
||||
in: query
|
||||
name: assignees
|
||||
description: |
|
||||
|
|
|
@ -8,7 +8,7 @@ get:
|
|||
tags:
|
||||
- cases
|
||||
parameters:
|
||||
- $ref: '../components/parameters/assignees.yaml'
|
||||
- $ref: '../components/parameters/assignees_filter.yaml'
|
||||
- $ref: '../components/parameters/category.yaml'
|
||||
- $ref: '../components/parameters/defaultSearchOperator.yaml'
|
||||
- $ref: '../components/parameters/from.yaml'
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue