github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.9] [Security Solution] fix investigation guide label turning red even though form value is valid (#160577) (#160630)

Browse source 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] fix investigation guide label turning red even
though form value is valid
(#160577)](https://github.com/elastic/kibana/pull/160577)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2023-06-27T13:56:31Z","message":"[Security
Solution] fix investigation guide label turning red even though form
value is valid
(#160577)","sha":"849cc89b7607ddbad650e8872b6abdd968c98737","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","v8.9.0","v8.10.0"],"number":160577,"url":"https://github.com/elastic/kibana/pull/160577","mergeCommit":{"message":"[Security
Solution] fix investigation guide label turning red even though form
value is valid
(#160577)","sha":"849cc89b7607ddbad650e8872b6abdd968c98737"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160577","number":160577,"mergeCommit":{"message":"[Security
Solution] fix investigation guide label turning red even though form
value is valid
(#160577)","sha":"849cc89b7607ddbad650e8872b6abdd968c98737"}}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
This commit is contained in:
Kibana Machine 2023-06-27 11:52:57 -04:00 • committed by GitHub
parent 0deef92c50
commit fddb90ac7f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
x-pack/plugins/security_solution/public/common/components/markdown_editor/plugins/insight/index.tsx
View file

@ -449,7 +449,10 @@ const InsightEditorComponent = ({
<EuiFormRow
label={i18n.LABEL}
helpText={i18n.LABEL_TEXT}
isInvalid={labelController.field.value != null}
isInvalid={
labelController.field.value !== undefined &&
labelController.field.value.trim().length === 0
}
fullWidth
>
<EuiFieldText
@ -520,10 +523,10 @@ const exampleInsight = `${insightPrefix}{
"label": "Test action",
"description": "Click to investigate",
"providers": [
[
[
{"field": "event.id", "value": "{{kibana.alert.original_event.id}}", "queryType": "phrase", "excluded": "false"}
],
[
[
{"field": "event.action", "value": "", "queryType": "exists", "excluded": "false"},
{"field": "process.pid", "value": "{{process.pid}}", "queryType": "phrase", "excluded":"false"}
]